Re: [PATCH v3 0/4] gpiolib: get rid of exessive ->of_gpio_ranges_fallback()

Stefan Wahren
2023-01-19T17:31:40Z

Hi Andy,

Am 13.01.23 um 22:53 schrieb Andy Shevchenko:
> The ->of_gpio_ranges_fallback() repeats the idea that lies behind
> ->add_pin_ranges(), while the latter covers more cases that the former
> hook. Drop the former one for good.

i successful tested booting of this series with multi_v7_defconfig on
Raspberry Pi 4 (with and without gpio-ranges in DTB):

Tested-by: Stefan Wahren <stefan.wahren@i2se.com>

>
> Changelog v3:
> - moved check of the property presense to GPIO library
> - split out the refcount fix in a separate patch
> - added cover letter
>
> Andy Shevchenko (4):
> gpiolib: Check "gpio-ranges" before calling ->add_pin_ranges()
> pinctrl: bcm2835: Remove of_node_put() in
> bcm2835_of_gpio_ranges_fallback()
> pinctrl: bcm2835: Switch to use ->add_pin_ranges()
> Revert "gpiolib: of: Introduce hook for missing gpio-ranges"
>
> drivers/gpio/gpiolib-of.c | 5 -----
> drivers/gpio/gpiolib.c | 8 ++++++++
> drivers/pinctrl/bcm/pinctrl-bcm2835.c | 10 ++++------
> include/linux/gpio/driver.h | 12 ------------
> 4 files changed, 12 insertions(+), 23 deletions(-)