Re: [PATCH] arm64: defconfig: enable Qualcomm PCIe modem drivers

Johan Hovold
2023-01-15T17:42:53Z

On Sun, Jan 15, 2023 at 01:11:08PM +0100, Daniele Palmas wrote:
> Hello Johan,
>
> Il giorno sab 14 gen 2023 alle ore 17:23 Johan Hovold
> <johan+linaro@kernel.org> ha scritto:
> >
> > Enable the MHI PCI controller driver and MHI WWAN drivers for Qualcomm
> > based PCIe modems such as the ones found on the SC8280XP Compute
> > Reference Design (CRD) and Lenovo Thinkpad X13s.
> >
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > ---

> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 86aa3730a8b6..117b49f3f1c1 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -250,6 +250,7 @@ CONFIG_DEVTMPFS_MOUNT=y
> > CONFIG_FW_LOADER_USER_HELPER=y
> > CONFIG_HISILICON_LPC=y
> > CONFIG_TEGRA_ACONNECT=m
> > +CONFIG_MHI_BUS_PCI_GENERIC=m
> > CONFIG_ARM_SCMI_PROTOCOL=y
> > CONFIG_ARM_SCPI_PROTOCOL=y
> > CONFIG_RASPBERRYPI_FIRMWARE=y
> > @@ -405,6 +406,9 @@ CONFIG_MWIFIEX_SDIO=m
> > CONFIG_MWIFIEX_PCIE=m
> > CONFIG_WL18XX=m
> > CONFIG_WLCORE_SDIO=m
> > +CONFIG_WWAN=m
> > +CONFIG_MHI_WWAN_CTRL=m
> > +CONFIG_MHI_WWAN_MBIM=m
>
> wondering if it could make sense to also enable CONFIG_MHI_NET, since
> in mhi_pci_generic there are also modems bound to that driver and, if
> not enabled, those would show just the control device, but not the
> netdevice.

Yes, indeed, that's a good idea. I had it enabled in my local config but
didn't include it as it isn't needed for the two machines I'm currently
working on.

I'll send a v2. Thanks!

Johan