From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2725C32793 for ; Wed, 18 Jan 2023 17:06:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=Wtt0svhMQ/KZSRH6Yrr42YvcnvI3r6nZyON/5uSvWGA=; b=SGereJEM8jkPCF PKSWWHbqxCnpLYJbNRnCRwnTITYZnaftM7bDp7UqPGb90WgGbfcejIgDZbmXLdKr9g7AmuyMk4TnS jg13uyScJAwjrZtZA6d9fYLPs0CQ2pJ3U449qBTCzFgYdgbqix7VAp/upjee+Nz/wXE5LPAfcnqcj C4ms9PlbslDCo7EtOyleHFSuDpBJY3MiEV4iioqPzyaF16tNHmdgrTk10J2cageRlAr0f4le/6Pdr xVPJW0SUH8wWZG8Os3GLnV4ToBtg9K+YCLRc3e0zDKjtjoNiusv2CqZkIXZLWOsdmyuMKez9Iclo6 mwuyST7657GROBqwKqyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIBs0-001xbZ-9C; Wed, 18 Jan 2023 17:05:04 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIBrw-001xa5-CO for linux-arm-kernel@lists.infradead.org; Wed, 18 Jan 2023 17:05:02 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B7137B81DE2; Wed, 18 Jan 2023 17:04:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1FEFFC433D2; Wed, 18 Jan 2023 17:04:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674061497; bh=rR4Df/erjWsP9GOk0L3bcywVdAHQZXw0SV5ORmLxzZ0=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=aDzcpyZdaG3x7s6fAheRNzA6NiffEhz4slQEgEBhwtaleCVPKAyDxuN43JBXRKp9v 2//s1Z8HnYz4bKzNnHp+g8a9OFfyWXACYmcFkFkY+R1nHmYz3eLHcmScnrlJovyd7j TwzMooDaHeKyyC7+GuQa63Xq0kE19j9kdcWfnXL+01j0M72DdzNvV4Y+7Cvbwy0gnw i7I6BEC2EMxY3och7sMWC1a/8ZUYiQhmRzpLzbTzYqrN8t+O92Mz4bWpv0JCPiFhnO nIiLxWK9gJLsEvjqT7lXYHRt6/sUERm7oGtVTKLRHnBdOpfkCYoyRIzrrG6vS9YKoI cSO25hKk7dl4A== Date: Wed, 18 Jan 2023 11:04:54 -0600 From: Bjorn Helgaas To: Achal Verma Cc: Tom Joseph , Lorenzo Pieralisi , Rob Herring , Krzysztof Wilczy_ski , Bjorn Helgaas , Vignesh Raghavendra , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Milind Parab , Jian Wang Subject: Re: [PATCH] PCI: cadence: Fix next function value in case of ARI Message-ID: <20230118170454.GA225634@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230118072035.3381993-1-a-verma1@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230118_090500_753666_FA33B152 X-CRM114-Status: GOOD ( 26.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 18, 2023 at 12:50:35PM +0530, Achal Verma wrote: > From: Jasko-EXT Wojciech > > Next function field in ARI_CAP_AND_CTR field register for last > function should be zero but thats not the case, so this patch > programs the next function field for last function as zero. s/thats/that's/ When you fix the comment formatting, also update the commit log to be imperative style and use the terms from the spec, e.g., Clear the ARI Capability Next Function Number of the last function. ARI_CAP_AND_CTR is a Cadence-specific name (and doesn't seem to appear even in that driver). The commit log should use the PCIe term. See https://chris.beams.io/posts/git-commit/ > Signed-off-by: Jasko-EXT Wojciech > Signed-off-by: Achal Verma > --- > drivers/pci/controller/cadence/pcie-cadence-ep.c | 15 ++++++++++++++- > drivers/pci/controller/cadence/pcie-cadence.h | 6 ++++++ > 2 files changed, 20 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/cadence/pcie-cadence-ep.c b/drivers/pci/controller/cadence/pcie-cadence-ep.c > index b8b655d4047e..6b6904cf0123 100644 > --- a/drivers/pci/controller/cadence/pcie-cadence-ep.c > +++ b/drivers/pci/controller/cadence/pcie-cadence-ep.c > @@ -565,7 +565,8 @@ static int cdns_pcie_ep_start(struct pci_epc *epc) > struct cdns_pcie *pcie = &ep->pcie; > struct device *dev = pcie->dev; > int max_epfs = sizeof(epc->function_num_map) * 8; > - int ret, value, epf; > + int ret, epf, last_fn; > + u32 reg, value; > > /* > * BIT(0) is hardwired to 1, hence function 0 is always enabled > @@ -573,6 +574,18 @@ static int cdns_pcie_ep_start(struct pci_epc *epc) > */ > cdns_pcie_writel(pcie, CDNS_PCIE_LM_EP_FUNC_CFG, epc->function_num_map); > > + /* Setup ARI Next Function Number. > + * This field should point to the next physical Function and 0 for > + * last Function. > + */ > + last_fn = find_last_bit(&epc->function_num_map, BITS_PER_LONG); > + reg = CDNS_PCIE_CORE_PF_I_ARI_CAP_AND_CTRL(last_fn); > + > + // Clear Next Function Number for the last function used. > + value = cdns_pcie_readl(pcie, reg); > + value &= ~CDNS_PCIE_ARI_CAP_NFN_MASK; > + cdns_pcie_writel(pcie, reg, value); > + > if (ep->quirk_disable_flr) { > for (epf = 0; epf < max_epfs; epf++) { > if (!(epc->function_num_map & BIT(epf))) > diff --git a/drivers/pci/controller/cadence/pcie-cadence.h b/drivers/pci/controller/cadence/pcie-cadence.h > index 190786e47df9..68c4c7878111 100644 > --- a/drivers/pci/controller/cadence/pcie-cadence.h > +++ b/drivers/pci/controller/cadence/pcie-cadence.h > @@ -130,6 +130,12 @@ > #define CDNS_PCIE_EP_FUNC_DEV_CAP_OFFSET 0xc0 > #define CDNS_PCIE_EP_FUNC_SRIOV_CAP_OFFSET 0x200 > > +/* > + * Endpoint PF Registers > + */ > +#define CDNS_PCIE_CORE_PF_I_ARI_CAP_AND_CTRL(fn) (0x144 + (fn) * 0x1000) > +#define CDNS_PCIE_ARI_CAP_NFN_MASK GENMASK(15, 8) > + > /* > * Root Port Registers (PCI configuration space for the root port function) > */ > -- > 2.25.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel