From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5020AC32793 for ; Wed, 18 Jan 2023 18:22:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0Ijx1wJ5ilWIYrJwZ0wQ1GScvA6PtqcHHEaEiuM37zQ=; b=MFgp0r2RJGZc4A M44KHRDRHWB1ZxLTXjE7ZSuKwRXOivjgrcvNsfdgSFtRnw7k/pACM2m80BuDmEWPtVPj4nVEAoUcC 1qMz+eHwJZ1AUasYcBD2KaNPGaB+/HlBnJqQejfT95V43CJ68nRW+2jVVpux2PuT2xv32qdD4rfpV +NAiT5t8/kg876AoA5Ur8Mofh6Fy6uM8NGvSR1IQ2M21XMeKEh7LHTx4Q1nABUaosY35R7Y2Qkho/ ujzoasw+UOlpQ8+qd9qi/96oFUiesMZTxFpd3D0upbXfCWQyWGZzAR3F9Gsm9GslEqpttKa8BO3AZ 4NboJdlRBQl2WfBJqFGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pID3T-002HDw-Hw; Wed, 18 Jan 2023 18:21:00 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pICyL-002FRw-BZ for linux-arm-kernel@lists.infradead.org; Wed, 18 Jan 2023 18:15:43 +0000 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30II0R2t008180; Wed, 18 Jan 2023 18:15:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : content-transfer-encoding : in-reply-to; s=qcppdkim1; bh=IVmEkhTc43W3TP+gBU3TATYyuv7VwQ4Vmb7MxTOEwZk=; b=VH6B8feRsEEnGWiThkPbFe04ezSBSzzQFZTi/Ljz+o1h5RQfwXMDL/Nc6KD+G5WrXWk8 tFMzvfzir7Z5d7VOtjD02koo/PxMJbgFsZR2BjRLfFw9bw4lrzlfza+GcxDCrfDGOG1H Cd4y7APw4XmQlRuzwtNWrbe6fpztk76tXZ1zWCmP1H5xEPE+ZAluVaWIpFyCeT2zlj8o j9nPwipXPDi/OKP/Qge+O/V97ksihb3BYIljNIsDsoPEpeJHpZ4LoLyuY1CP2QRlfUxm tJyssLUbZSHPn7cVx/Sw0xpGjswr6m5GZHqamU3rsYS+PgFUPqmNvGpSZGSWK6gINxVu CA== Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3n5t4jbm5m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 18 Jan 2023 18:15:26 +0000 Received: from nasanex01a.na.qualcomm.com ([10.52.223.231]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 30IIFPXM016321 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 18 Jan 2023 18:15:25 GMT Received: from hu-bjorande-lv.qualcomm.com (10.49.16.6) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 18 Jan 2023 10:15:25 -0800 Date: Wed, 18 Jan 2023 10:15:23 -0800 From: Bjorn Andersson To: =?iso-8859-1?Q?N=EDcolas_F=2E_R=2E_A=2E?= Prado CC: Matthias Brugger , , AngeloGioacchino Del Regno , Arnd Bergmann , Catalin Marinas , Dmitry Baryshkov , Krzysztof Kozlowski , Marcel Ziswiler , Shawn Guo , Will Deacon , , Subject: Re: [PATCH] arm64: defconfig: Enable missing configs for mt8192-asurada Message-ID: <20230118181523.GD3322341@hu-bjorande-lv.qualcomm.com> References: <20230112151238.1930126-1-nfraprado@collabora.com> <20230117155854.GE2350793@hu-bjorande-lv.qualcomm.com> <20230117201159.pcxnftapsjr2eotn@notapiano> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230117201159.pcxnftapsjr2eotn@notapiano> X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01c.na.qualcomm.com (10.47.97.35) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: Rn1t54kR2QSjXXMnalnqOHuURT1O2XIC X-Proofpoint-ORIG-GUID: Rn1t54kR2QSjXXMnalnqOHuURT1O2XIC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-18_05,2023-01-18_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 mlxscore=0 spamscore=0 priorityscore=1501 impostorscore=0 mlxlogscore=965 phishscore=0 adultscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301180154 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230118_101541_570592_A6A5CE3C X-CRM114-Status: GOOD ( 36.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 17, 2023 at 03:11:59PM -0500, N=EDcolas F. R. A. Prado wrote: > On Tue, Jan 17, 2023 at 07:58:54AM -0800, Bjorn Andersson wrote: > > On Thu, Jan 12, 2023 at 10:12:38AM -0500, N=EDcolas F. R. A. Prado wrot= e: > > > Enable missing configs in the arm64 defconfig to get all devices prob= ing > > > on mt8192-asurada based machines. > > > = > > > The devices enabled are: MediaTek Bluetooth USB controller, MediaTek > > > PCIe Gen3 MAC controller, MT7921E wireless adapter, Elan I2C Trackpad, > > > MediaTek SPI NOR flash controller, Mediatek SPMI Controller, ChromeOS= EC > > > regulators, MT6315 PMIC, MediaTek Video Codec, MT8192 sound cards, > > > ChromeOS EC rpmsg communication, all MT8192 clocks. > > > = > > > Support for DMA Restricted Pool is also enabled since it is used by t= he > > > WiFi card on this platform. > > > = > > > REGULATOR_CROS_EC is enabled as builtin since it powers the MMC > > > controller for the SD card, making it required for booting on some > > > setups. > > = > > I presume this implies that there's no ramdisk to carry these additional > > modules? > = > There may or may not be, at the discretion of the user, so enable by defa= ult. > = As long as the dependency chain is reasonably short this is okay with me. > > = > > > = > > > By enabling the support for all of this platform's devices on the > > > defconfig we make it effortless to test the relevant hardware both by > > > developers as well as CI systems like KernelCI. > > > = > > > Signed-off-by: N=EDcolas F. R. A. Prado > > > = > > > --- > > > = > > > arch/arm64/configs/defconfig | 25 +++++++++++++++++++++++++ > > > 1 file changed, 25 insertions(+) > > > = > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defcon= fig > > > index f3053e7018fe..4e806d8068f6 100644 > > > --- a/arch/arm64/configs/defconfig > > > +++ b/arch/arm64/configs/defconfig > [..] > > > @@ -1092,6 +1104,18 @@ CONFIG_CLK_IMX8QXP=3Dy > > > CONFIG_CLK_IMX8ULP=3Dy > > > CONFIG_CLK_IMX93=3Dy > > > CONFIG_TI_SCI_CLK=3Dy > > > +CONFIG_COMMON_CLK_MT8192_AUDSYS=3Dy > > > +CONFIG_COMMON_CLK_MT8192_CAMSYS=3Dy > > > +CONFIG_COMMON_CLK_MT8192_IMGSYS=3Dy > > > +CONFIG_COMMON_CLK_MT8192_IMP_IIC_WRAP=3Dy > > > +CONFIG_COMMON_CLK_MT8192_IPESYS=3Dy > > > +CONFIG_COMMON_CLK_MT8192_MDPSYS=3Dy > > > +CONFIG_COMMON_CLK_MT8192_MFGCFG=3Dy > > > +CONFIG_COMMON_CLK_MT8192_MMSYS=3Dy > > > +CONFIG_COMMON_CLK_MT8192_MSDC=3Dy > > > +CONFIG_COMMON_CLK_MT8192_SCP_ADSP=3Dy > > > +CONFIG_COMMON_CLK_MT8192_VDECSYS=3Dy > > > +CONFIG_COMMON_CLK_MT8192_VENCSYS=3Dy > > = > > Are all these clock drivers needed in order to reach a ramdisk, with > > working uart, where further kernel modules could be loaded? > = > No, but currently these configs can't be enabled as modules. So my intent= ion is > to enable all of them as builtin for now so we get the functionality ther= e, and > after the drivers and configs are reworked to allow building as modules (= which > should happen shortly after [1] is merged), I'll update the defconfig so = that > the non-essential ones for boot are set to =3Dm. > = Sounds good to me. Thanks, Bjorn > [1] https://lore.kernel.org/all/20230113110616.111001-1-angelogioacchino.= delregno@collabora.com/ > = > > = > > > CONFIG_COMMON_CLK_QCOM=3Dy > > > CONFIG_QCOM_A53PLL=3Dy > > > CONFIG_QCOM_CLK_APCS_MSM8916=3Dy > > > @@ -1398,6 +1422,7 @@ CONFIG_CRYPTO_DEV_HISI_SEC2=3Dm > > > CONFIG_CRYPTO_DEV_HISI_ZIP=3Dm > > > CONFIG_CRYPTO_DEV_HISI_HPRE=3Dm > > > CONFIG_CRYPTO_DEV_HISI_TRNG=3Dm > > > +CONFIG_DMA_RESTRICTED_POOL=3Dy > > = > > As this would alter the behavior of other platforms and devices, could > > we please carry this in a patch of its own to aid bisection? > = > Sure. > = > Thanks, > N=EDcolas > = > > = > > Thanks, > > Bjorn > > = > > > CONFIG_CMA_SIZE_MBYTES=3D32 > > > CONFIG_PRINTK_TIME=3Dy > > > CONFIG_DEBUG_KERNEL=3Dy > > > -- = > > > 2.39.0 > > > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel