From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43B83C38147 for ; Wed, 18 Jan 2023 23:02:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aHic/A/sce2CxLqv7w+luwPO0kY+nam/LlBSMpNF7HI=; b=yBKKUXcA71kBjG ZYnGK6RPx8XX1kWsHuv0JEPyiD0yOQ+qESQDVpkfETKGwnLZcpce9ankiT6v2kYFMsAUxm8TdLUmg bm2fyHaz6trc4fM+48W+sA+3lk+vFUFlijjnLErsUGaEwW0CJhwNyhYN3uPmD2Rmny56kGzFEe0D9 YceiGJY9Z5rlTR8V+mj/roLgpbhRXK9n1qA3mZ32fEX4600HDHTYMY2mZCWmtBbtdD8SGhOG8/Sg6 xNlOZqa3Mc2D0NWn+M4jKuQctG7ObK79cL1hjXEZZXG08bQlKuQnZ4IVS0bX6ZIk+X9r+VprwD3mj qeqMLYODhGOoyBhKPwVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIHRH-002v2E-Jk; Wed, 18 Jan 2023 23:01:51 +0000 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIHRE-002v1U-Le; Wed, 18 Jan 2023 23:01:50 +0000 Received: by mail-ej1-x632.google.com with SMTP id qx13so1115493ejb.13; Wed, 18 Jan 2023 15:01:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JG0zmDr4Gx7JTYrA4JUjYF+9TusUlPQwAzE14ZbaLBE=; b=oRqBiOJYIlMdDowmL/wHGABFcI0fDixl2PMB36ctD5uSKk3azFGtf6qd2Fvk85nbjC RZGiY6WOS6aL3GADhFTaSpq9sDvNd66O4zvJIfSzbuoiU8TfqAStjiekALks5NkGSaKe ovGZ8gH0HmxO9jFlluSL74dBYh1vn5KfO7NSBBuv+DCGaPm6jsuW1hq8QeP+fNTfmlqX 3IcskUgDBjlFzRib6paxCj+S90vgVnJVBiNY0ccVMPpVBJ9PeZVJOHdXXs+2uIBtQoT/ vlsHkNs0iO6OaL9F9gRjvD02YML4zxlAojbWSyksCeYa74+TLtrx2SxLVb3arsFe5b7r ZhGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JG0zmDr4Gx7JTYrA4JUjYF+9TusUlPQwAzE14ZbaLBE=; b=VYQONW+MMFKggpXZSkhLOJ7fpgmiYEspqcWnrcV53/Ro89P8v2BMCEq/cM5h4ZgT7a OMvTvO7u0H0lQ4Jc7Dov5dgvO2rnG58DnfLazVWwTou/eF97eGwUB8hsY5lLQm6qD7iL 4r9Itkvifp69iurljVZqJ3KAa4ogbAPti/KUiL6ctQL0Qpj4euatkko/PKyxbB0SnKPO LgJcVflRRE6TadPhNYbVoqI6bwDoxKuFxpoNWbnHYVFXfc43ud99YI/tC0Z/mr49BlRZ UK7yryFOElqgvfcbR8ha0az1Li5i3/xnj89cz37WICCSmKLlt0FtjcXzJFyOBEgyPKgL hk4g== X-Gm-Message-State: AFqh2kpgvQilcN7cSdi7f8VjMe+lEQHjA+uPHFNFD8LkYyKF0rOkjKLx v8ZvuT8sKbR4BhdT3o+IEVg= X-Google-Smtp-Source: AMrXdXuoqpi45+sG2pftBtwBbFskPfB44UC+cRcWbZWXXc+n+Hirrb16NdbKE6aaVF+8KoKPwtvNJQ== X-Received: by 2002:a17:907:1019:b0:84c:69f8:2ec2 with SMTP id ox25-20020a170907101900b0084c69f82ec2mr8598505ejb.22.1674082899134; Wed, 18 Jan 2023 15:01:39 -0800 (PST) Received: from skbuf ([188.27.185.42]) by smtp.gmail.com with ESMTPSA id k11-20020a1709062a4b00b0073022b796a7sm15579629eje.93.2023.01.18.15.01.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jan 2023 15:01:38 -0800 (PST) Date: Thu, 19 Jan 2023 01:01:35 +0200 From: Vladimir Oltean To: netdev@kapio-technology.com Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , "maintainer:MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER" , Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , =?utf-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Russell King , Christian Marangi , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "open list:RENESAS RZ/N1 A5PSW SWITCH DRIVER" , "moderated list:ETHERNET BRIDGE" Subject: Re: [RFC PATCH net-next 2/5] net: dsa: propagate flags down towards drivers Message-ID: <20230118230135.szu6a7kvt2mjb3i5@skbuf> References: <20230117185714.3058453-1-netdev@kapio-technology.com> <20230117185714.3058453-3-netdev@kapio-technology.com> <20230117231750.r5jr4hwvpadgopmf@skbuf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230118_150148_748058_601E2D52 X-CRM114-Status: GOOD ( 18.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 18, 2023 at 11:35:08PM +0100, netdev@kapio-technology.com wrote: > I am not sure I understand you entirely. > From my standpoint I see it as so: that until now any fdb entry coming to > port_fdb_add() (or port_fdb_del()) are seen as static entries. And this > changes nothing with respect to those static entries as how drivers handle > them. This is true; it is implicit that the port_fdb_add() and port_fdb_del() DSA methods request switches to operate on static FDB entries (in hardware). > When the new dynamic flag is true, all drivers will ignore it in patch #3, > so basically nothing will change by that. This is not true, because it assumes that DSA never called port_fdb_add() up until now for bridge FDB entries with the BR_FDB_STATIC flag unset, which is incorrect (it did). So what will change is that drivers which used to react to those bridge FDB entries will stop doing so. > Then in patch #5 the dynamic flag is handled by the mv88e6xxx driver. > > I don't know the assisted_learning_on_cpu_port feature you mention, but > there has still not been anything but static entries going towards > port_fdb_add() yet... For starters, you can read the commit message of the patch that introduced it, which is d5f19486cee7 ("net: dsa: listen for SWITCHDEV_{FDB,DEL}_ADD_TO_DEVICE on foreign bridge neighbors"). _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel