From: Christoph Hellwig <hch@lst.de>
To: Janne Grunau <j@jannau.net>
Cc: Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Eric Curtin <ecurtin@redhat.com>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] nvme-apple: Reset controller during shutdown
Date: Thu, 19 Jan 2023 07:14:52 +0100 [thread overview]
Message-ID: <20230119061452.GA17695@lst.de> (raw)
In-Reply-To: <20230118052450.GA24742@lst.de>
Folks, can you chime in if this comment makes sense? I'd really
like to send the patches off to Jens before rc5.
On Wed, Jan 18, 2023 at 06:24:50AM +0100, Christoph Hellwig wrote:
> On Tue, Jan 17, 2023 at 07:25:00PM +0100, Janne Grunau wrote:
> > + /*
> > + * Always reset the NVMe controller on shutdown. The reset is
> > + * required to shutdown the co-processor cleanly.
> > + */
>
> Hmm. This comment doesn't seem to match the discussion we had last
> week. Which would be:
>
> /*
> * NVMe requires a reset before setting up a controller to
> * ensure it is in a clean state. For NVMe PCIe this is
> * done in the setup path to be able to deal with controllers
> * in any kind of state. For for Apple devices, the firmware
> * will not be available at that time and the reset will
> * time out. Thus reset after shutting the NVMe controller
> * down and before shutting the firmware down.
> */
---end quoted text---
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-19 6:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230114-apple-nvme-suspend-fixes-v6.2-v2-0-9157bf633dba@jannau.net>
[not found] ` <20230114-apple-nvme-suspend-fixes-v6.2-v2-1-9157bf633dba@jannau.net>
2023-01-18 5:24 ` [PATCH v2 1/2] nvme-apple: Reset controller during shutdown Christoph Hellwig
2023-01-19 6:14 ` Christoph Hellwig [this message]
2023-01-19 7:58 ` Hector Martin "marcan"
2023-01-19 8:08 ` Christoph Hellwig
2023-01-19 8:12 ` Janne Grunau
2023-01-19 7:48 ` Janne Grunau
2023-01-18 5:25 ` [PATCH v2 0/2] nvme-apple: Fix suspend-resume regression Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230119061452.GA17695@lst.de \
--to=hch@lst.de \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=axboe@fb.com \
--cc=ecurtin@redhat.com \
--cc=j@jannau.net \
--cc=kbusch@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=marcan@marcan.st \
--cc=sagi@grimberg.me \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).