From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 150CAC38142 for ; Thu, 19 Jan 2023 06:16:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ts+bMiBQe6pnijMOSN7G++My5xomawcfBQMnToq6kDU=; b=D4FqcjzI54LGSW +Zk3pkdJI0Ttxzhop3U/krGmLcysBfwWYVtLqNMiQTylMd8PyZBhgwcbwQS/0SEAwat3HHt6lfczI WherBA2Y/mjCpYlQSvyMSCjIC4PgjUQTnog4nYTzSvalmJiNOlLuhMJMcR3DnxAoICQbBwQRCjR8Z JTx85KCb/UFC45GP59qgoR1a3j2/9fCAGCckQpEkICHlBCpCkK8ouVEkldmjh2k9i2Ejgh3LMmYIz QJg1hWLoCHNucot2q6Ar+3zrj9gvJmilRIu1iIhkoboo6dxVBtlmlZiUSFdKsWEQB8uQqHNW0uSqb sH086HLA9fiu3btnU+PQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIOCT-003it3-CZ; Thu, 19 Jan 2023 06:15:01 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIOCQ-003isP-Ok; Thu, 19 Jan 2023 06:15:00 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 657DC67373; Thu, 19 Jan 2023 07:14:53 +0100 (CET) Date: Thu, 19 Jan 2023 07:14:52 +0100 From: Christoph Hellwig To: Janne Grunau Cc: Hector Martin , Sven Peter , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Alyssa Rosenzweig , Eric Curtin , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] nvme-apple: Reset controller during shutdown Message-ID: <20230119061452.GA17695@lst.de> References: <20230114-apple-nvme-suspend-fixes-v6.2-v2-0-9157bf633dba@jannau.net> <20230114-apple-nvme-suspend-fixes-v6.2-v2-1-9157bf633dba@jannau.net> <20230118052450.GA24742@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230118052450.GA24742@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230118_221458_970451_3684AF0B X-CRM114-Status: GOOD ( 20.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Folks, can you chime in if this comment makes sense? I'd really like to send the patches off to Jens before rc5. On Wed, Jan 18, 2023 at 06:24:50AM +0100, Christoph Hellwig wrote: > On Tue, Jan 17, 2023 at 07:25:00PM +0100, Janne Grunau wrote: > > + /* > > + * Always reset the NVMe controller on shutdown. The reset is > > + * required to shutdown the co-processor cleanly. > > + */ > > Hmm. This comment doesn't seem to match the discussion we had last > week. Which would be: > > /* > * NVMe requires a reset before setting up a controller to > * ensure it is in a clean state. For NVMe PCIe this is > * done in the setup path to be able to deal with controllers > * in any kind of state. For for Apple devices, the firmware > * will not be available at that time and the reset will > * time out. Thus reset after shutting the NVMe controller > * down and before shutting the firmware down. > */ ---end quoted text--- _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel