public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Jagan Teki <jagan@amarulasolutions.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>,
	Inki Dae <inki.dae@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Joonyoung Shim <jy0922.shim@samsung.com>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Frieder Schrempf <frieder.schrempf@kontron.de>,
	Fancy Fang <chen.fang@nxp.com>,
	Tim Harvey <tharvey@gateworks.com>,
	Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
	Adam Ford <aford173@gmail.com>,
	Neil Armstrong <narmstrong@linaro.org>,
	Robert Foss <robert.foss@linaro.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Tommaso Merciai <tommaso.merciai@amarulasolutions.com>,
	Marek Vasut <marex@denx.de>
Cc: Matteo Lisi <matteo.lisi@engicam.com>,
	dri-devel@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-amarula <linux-amarula@amarulasolutions.com>,
	Jagan Teki <jagan@amarulasolutions.com>
Subject: [RESEND PATCH v11 07/18] drm: exynos: dsi: Introduce hw_type platform data
Date: Mon, 23 Jan 2023 20:42:01 +0530	[thread overview]
Message-ID: <20230123151212.269082-8-jagan@amarulasolutions.com> (raw)
In-Reply-To: <20230123151212.269082-1-jagan@amarulasolutions.com>

Samsung MIPI DSIM controller is common DSI IP that can be used
in various SoCs like Exynos, i.MX8M Mini/Nano/Plus.

Add hw_type enum via platform_data so that accessing the different
controller data between various platforms becomes easy and meaningful.

Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Suggested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v11:
- collect RB from Frieder
- drop extra line
Changes for v10:
- split from previous series patch
"drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge"
- update enum type names

 drivers/gpu/drm/exynos/exynos_drm_dsi.c | 83 ++++++++++++++++++++-----
 1 file changed, 68 insertions(+), 15 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index 7a845badb1b2..902bd46964cb 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -254,6 +254,15 @@ struct exynos_dsi_transfer {
 #define DSIM_STATE_CMD_LPM		BIT(2)
 #define DSIM_STATE_VIDOUT_AVAILABLE	BIT(3)
 
+enum exynos_dsi_type {
+	DSIM_TYPE_EXYNOS3250,
+	DSIM_TYPE_EXYNOS4210,
+	DSIM_TYPE_EXYNOS5410,
+	DSIM_TYPE_EXYNOS5422,
+	DSIM_TYPE_EXYNOS5433,
+	DSIM_TYPE_COUNT,
+};
+
 struct exynos_dsi_driver_data {
 	const unsigned int *reg_ofs;
 	unsigned int plltmr_reg;
@@ -267,6 +276,10 @@ struct exynos_dsi_driver_data {
 	const unsigned int *reg_values;
 };
 
+struct exynos_dsi_plat_data {
+	enum exynos_dsi_type hw_type;
+};
+
 struct exynos_dsi {
 	struct drm_encoder encoder;
 	struct mipi_dsi_host dsi_host;
@@ -297,6 +310,7 @@ struct exynos_dsi {
 	struct list_head transfer_list;
 
 	const struct exynos_dsi_driver_data *driver_data;
+	const struct exynos_dsi_plat_data *plat_data;
 };
 
 #define host_to_dsi(host) container_of(host, struct exynos_dsi, dsi_host)
@@ -524,18 +538,13 @@ static const struct exynos_dsi_driver_data exynos5422_dsi_driver_data = {
 	.reg_values = exynos5422_reg_values,
 };
 
-static const struct of_device_id exynos_dsi_of_match[] = {
-	{ .compatible = "samsung,exynos3250-mipi-dsi",
-	  .data = &exynos3_dsi_driver_data },
-	{ .compatible = "samsung,exynos4210-mipi-dsi",
-	  .data = &exynos4_dsi_driver_data },
-	{ .compatible = "samsung,exynos5410-mipi-dsi",
-	  .data = &exynos5_dsi_driver_data },
-	{ .compatible = "samsung,exynos5422-mipi-dsi",
-	  .data = &exynos5422_dsi_driver_data },
-	{ .compatible = "samsung,exynos5433-mipi-dsi",
-	  .data = &exynos5433_dsi_driver_data },
-	{ }
+static const struct exynos_dsi_driver_data *
+exynos_dsi_types[DSIM_TYPE_COUNT] = {
+	[DSIM_TYPE_EXYNOS3250] = &exynos3_dsi_driver_data,
+	[DSIM_TYPE_EXYNOS4210] = &exynos4_dsi_driver_data,
+	[DSIM_TYPE_EXYNOS5410] = &exynos5_dsi_driver_data,
+	[DSIM_TYPE_EXYNOS5422] = &exynos5422_dsi_driver_data,
+	[DSIM_TYPE_EXYNOS5433] = &exynos5433_dsi_driver_data,
 };
 
 static void exynos_dsi_wait_for_reset(struct exynos_dsi *dsi)
@@ -1468,8 +1477,6 @@ static const struct drm_bridge_funcs exynos_dsi_bridge_funcs = {
 	.attach				= exynos_dsi_attach,
 };
 
-MODULE_DEVICE_TABLE(of, exynos_dsi_of_match);
-
 static int exynos_dsi_host_attach(struct mipi_dsi_host *host,
 				  struct mipi_dsi_device *device)
 {
@@ -1659,7 +1666,8 @@ static int exynos_dsi_probe(struct platform_device *pdev)
 	dsi->dsi_host.dev = dev;
 
 	dsi->dev = dev;
-	dsi->driver_data = of_device_get_match_data(dev);
+	dsi->plat_data = of_device_get_match_data(dev);
+	dsi->driver_data = exynos_dsi_types[dsi->plat_data->hw_type];
 
 	dsi->supplies[0].supply = "vddcore";
 	dsi->supplies[1].supply = "vddio";
@@ -1817,6 +1825,51 @@ static const struct dev_pm_ops exynos_dsi_pm_ops = {
 				pm_runtime_force_resume)
 };
 
+static const struct exynos_dsi_plat_data exynos3250_dsi_pdata = {
+	.hw_type = DSIM_TYPE_EXYNOS3250,
+};
+
+static const struct exynos_dsi_plat_data exynos4210_dsi_pdata = {
+	.hw_type = DSIM_TYPE_EXYNOS4210,
+};
+
+static const struct exynos_dsi_plat_data exynos5410_dsi_pdata = {
+	.hw_type = DSIM_TYPE_EXYNOS5410,
+};
+
+static const struct exynos_dsi_plat_data exynos5422_dsi_pdata = {
+	.hw_type = DSIM_TYPE_EXYNOS5422,
+};
+
+static const struct exynos_dsi_plat_data exynos5433_dsi_pdata = {
+	.hw_type = DSIM_TYPE_EXYNOS5433,
+};
+
+static const struct of_device_id exynos_dsi_of_match[] = {
+	{
+		.compatible = "samsung,exynos3250-mipi-dsi",
+		.data = &exynos3250_dsi_pdata,
+	},
+	{
+		.compatible = "samsung,exynos4210-mipi-dsi",
+		.data = &exynos4210_dsi_pdata,
+	},
+	{
+		.compatible = "samsung,exynos5410-mipi-dsi",
+		.data = &exynos5410_dsi_pdata,
+	},
+	{
+		.compatible = "samsung,exynos5422-mipi-dsi",
+		.data = &exynos5422_dsi_pdata,
+	},
+	{
+		.compatible = "samsung,exynos5433-mipi-dsi",
+		.data = &exynos5433_dsi_pdata,
+	},
+	{ /* sentinel. */ }
+};
+MODULE_DEVICE_TABLE(of, exynos_dsi_of_match);
+
 struct platform_driver dsi_driver = {
 	.probe = exynos_dsi_probe,
 	.remove = exynos_dsi_remove,
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-01-23 16:21 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-23 15:11 [RESEND PATCH v11 00/18] drm: Add Samsung MIPI DSIM bridge Jagan Teki
2023-01-23 15:11 ` [RESEND PATCH v11 01/18] drm: of: Lookup if child node has DSI panel or bridge Jagan Teki
2023-01-23 15:11 ` [RESEND PATCH v11 02/18] drm: bridge: panel: Add devm_drm_of_dsi_get_bridge helper Jagan Teki
2023-01-26 12:12   ` Maxime Ripard
2023-01-26 15:18     ` Jagan Teki
2023-01-27 17:39       ` Jagan Teki
2023-01-30 12:56         ` Maxime Ripard
2023-01-30 13:24           ` Jagan Teki
2023-01-31 12:45             ` Maxime Ripard
2023-01-31 13:47               ` Jagan Teki
2023-01-31 13:59                 ` Maxime Ripard
2023-01-31 14:14                   ` Jagan Teki
2023-01-30 12:58       ` Maxime Ripard
2023-01-30 13:22         ` Jagan Teki
2023-02-02 16:52         ` Jagan Teki
2023-02-03  8:26           ` Maxime Ripard
2023-02-03 10:43             ` Jagan Teki
2023-02-03 10:49               ` Maxime Ripard
2023-02-03 10:58                 ` Jagan Teki
2023-02-03 11:04                   ` Maxime Ripard
2023-02-27 11:25                     ` Jagan Teki
2023-01-23 15:11 ` [RESEND PATCH v11 03/18] drm: exynos: dsi: Drop explicit call to bridge detach Jagan Teki
2023-01-23 15:11 ` [RESEND PATCH v11 04/18] drm: exynos: dsi: Switch to devm_drm_of_dsi_get_bridge Jagan Teki
2023-01-23 15:11 ` [RESEND PATCH v11 05/18] drm: exynos: dsi: Mark PHY as optional Jagan Teki
2023-01-23 15:12 ` [RESEND PATCH v11 06/18] drm: exynos: dsi: Add platform PLL_P (PMS_P) offset Jagan Teki
2023-01-23 15:12 ` Jagan Teki [this message]
2023-01-24 20:54   ` [RESEND PATCH v11 07/18] drm: exynos: dsi: Introduce hw_type platform data Marek Vasut
2023-01-23 15:12 ` [RESEND PATCH v11 08/18] drm: exynos: dsi: Handle proper host initialization Jagan Teki
2023-01-24 21:00   ` Marek Vasut
2023-01-23 15:12 ` [RESEND PATCH v11 09/18] drm: exynos: dsi: Add atomic check Jagan Teki
2023-01-24 20:55   ` Marek Vasut
2023-01-23 15:12 ` [RESEND PATCH v11 10/18] drm: exynos: dsi: Add input_bus_flags Jagan Teki
2023-01-24 20:55   ` Marek Vasut
2023-01-23 15:12 ` [RESEND PATCH v11 11/18] drm: exynos: dsi: Add atomic_get_input_bus_fmts Jagan Teki
2023-01-24 20:45   ` Marek Vasut
2023-01-24 21:16     ` Jagan Teki
2023-01-24 21:19       ` Marek Vasut
2023-01-24 21:22         ` Jagan Teki
2023-01-23 15:12 ` [RESEND PATCH v11 12/18] drm: exynos: dsi: Consolidate component and bridge Jagan Teki
2023-01-24 21:04   ` Marek Vasut
2023-01-23 15:12 ` [RESEND PATCH v11 13/18] drm: exynos: dsi: Add Exynos based host irq hooks Jagan Teki
2023-01-24 20:48   ` Marek Vasut
2023-01-24 21:01     ` Jagan Teki
2023-01-24 21:12       ` Marek Vasut
2023-01-24 21:24         ` Jagan Teki
2023-01-24 21:24           ` Jagan Teki
2023-01-25  6:54             ` Jagan Teki
2023-01-25 13:53               ` Marek Vasut
2023-01-25 14:04                 ` Jagan Teki
2023-01-25 16:46                   ` Marek Vasut
2023-01-25 17:12                     ` Jagan Teki
2023-01-25 17:27                       ` Marek Vasut
2023-01-25 17:35                         ` Jagan Teki
2023-01-25 18:03                           ` Marek Vasut
2023-01-25 19:24                             ` Jagan Teki
2023-01-25 21:53                               ` Marek Vasut
2023-01-25 16:02         ` Jagan Teki
2023-01-23 15:12 ` [RESEND PATCH v11 15/18] dt-bindings: display: exynos: dsim: Add NXP i.MX8M Mini/Nano support Jagan Teki
2023-01-24 20:56   ` Marek Vasut
2023-01-23 15:12 ` [RESEND PATCH v11 16/18] drm: bridge: samsung-dsim: Add " Jagan Teki
2023-01-24 20:56   ` Marek Vasut
2023-01-23 15:12 ` [RESEND PATCH v11 17/18] dt-bindings: display: exynos: dsim: Add NXP i.MX8M Plus support Jagan Teki
2023-01-24 20:57   ` Marek Vasut
2023-01-23 15:12 ` [RESEND PATCH v11 18/18] drm: bridge: samsung-dsim: Add " Jagan Teki
2023-01-24 20:59   ` Marek Vasut
2023-01-24 19:12 ` [RESEND PATCH v11 00/18] drm: Add Samsung MIPI DSIM bridge Jagan Teki
     [not found] ` <20230123151212.269082-15-jagan@amarulasolutions.com>
2023-01-24 20:57   ` [RESEND PATCH v11 14/18] drm: bridge: Generalize Exynos-DSI driver into a Samsung " Marek Vasut
2023-01-24 21:13 ` [RESEND PATCH v11 00/18] drm: Add Samsung MIPI " Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230123151212.269082-8-jagan@amarulasolutions.com \
    --to=jagan@amarulasolutions.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=aford173@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=chen.fang@nxp.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=frieder.schrempf@kontron.de \
    --cc=inki.dae@samsung.com \
    --cc=jy0922.shim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-amarula@amarulasolutions.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=marex@denx.de \
    --cc=matteo.lisi@engicam.com \
    --cc=michael@amarulasolutions.com \
    --cc=narmstrong@linaro.org \
    --cc=robert.foss@linaro.org \
    --cc=sw0312.kim@samsung.com \
    --cc=tharvey@gateworks.com \
    --cc=tommaso.merciai@amarulasolutions.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox