From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C8DAC54E94 for ; Wed, 25 Jan 2023 08:34:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y9WpGCsazoUs9DVtz4krszbb1XzAjWntwP/K+uL9Wpw=; b=bLe9wfYW7gnlis f0kFMhMANNLm2v4tfwsXw1HILud6nG529xw2eQD66xXYTM07B9wdGu53LOj+soePQ4RRKM+ls26jV uyvZ/5j8jkh4V3IaJeAgkHYaqgCbVwU+cu1jC7txtfTTIsxto0i4oztRMlAo3vhIaRI5V6W7x4ACY +GQU3omXFNEP3SEIeIevrHqu73DThtijwgtb8WRKDq+qOTiUyt9OLvf9fYxMnpKRvplHUfdTIZM8f LI+P9PIv5xC+QHOWrpgD9ovfqUcZcvFKpHzeBBQe0RLuE/jCvGI/KgbyxaRlPbDj1Qj+303ffWFdP hFdr75tDNCkvaw4/+VOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKbDh-006S5k-Ud; Wed, 25 Jan 2023 08:33:26 +0000 Received: from forward500b.mail.yandex.net ([178.154.239.144]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKbDe-006S1S-C8 for linux-arm-kernel@lists.infradead.org; Wed, 25 Jan 2023 08:33:24 +0000 Received: from sas8-92ddc00f49ef.qloud-c.yandex.net (sas8-92ddc00f49ef.qloud-c.yandex.net [IPv6:2a02:6b8:c1b:2988:0:640:92dd:c00f]) by forward500b.mail.yandex.net (Yandex) with ESMTP id D8C285F39A; Wed, 25 Jan 2023 11:33:16 +0300 (MSK) Received: by sas8-92ddc00f49ef.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id CXKlpM8YBeA1-MrFzk96U; Wed, 25 Jan 2023 11:33:16 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=maquefel.me; s=mail; t=1674635596; bh=Iu7kC5v6n5QYhMcI1r9TLZt9aPN3xDWmxLQey5H8/Sc=; h=Cc:Message-ID:Subject:Date:References:To:From:In-Reply-To; b=fBIvUJjSADfV0T9Xa3qtwCwY5pN92MQzDF2KhoQm8bB4GVPvcjCQdTPhlN5+qiUUr S++rIecuSu/WVFVwrkjTh15i/Y2pHGTsqHUIpPbGT0cUPmio7Pgj1DtNrR4hGdHn+d XfzmtzALnXKiv0CZBuhU/yIjEr71jRACDBQIBqOs= Authentication-Results: sas8-92ddc00f49ef.qloud-c.yandex.net; dkim=pass header.i=@maquefel.me Date: Wed, 25 Jan 2023 11:33:11 +0300 From: Nikita Shubin To: "Arnd Bergmann" Cc: "open list:GPIO SUBSYSTEM" , "Linus Walleij" , "Hartley Sweeten" , "Alexander Sverdlin" , "Russell King" , "Lukasz Majewski" , "Bartosz Golaszewski" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] gpio: ep93xx: convert driver to DT Message-ID: <20230125113311.2aff259d@redslave.neermore.group> In-Reply-To: References: <20230117100845.16708-1-nikita.shubin@maquefel.me> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230125_003322_632032_C13F8554 X-CRM114-Status: GOOD ( 15.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Arnd! On Tue, 17 Jan 2023 11:15:20 +0100 "Arnd Bergmann" wrote: > On Tue, Jan 17, 2023, at 11:08, Nikita Shubin wrote: > > > > > +#ifdef CONFIG_OF > > +static const struct of_device_id ep93xx_gpio_match[] = { > > + { .compatible = "cirrus,ep93xx-gpio" }, > > + { /* end of table */ }, > > +}; > > +MODULE_DEVICE_TABLE(of, ep93xx_gpio_match); > > +#endif > > + > > static struct platform_driver ep93xx_gpio_driver = { > > .driver = { > > .name = "gpio-ep93xx", > > + .of_match_table = ep93xx_gpio_match, > > }, > > .probe = ep93xx_gpio_probe, > > The #ifdef here is wrong and will cause a build failure because > of the unconditional reference to the variable. > > Just remove the #ifdef/#endif. Sorry about that - i remember that i should drop it everywhere, which did for all but ep93xx-gpio, i am dropping match currently, as it will produce a warning without dt-bindings documentation, it will be introduced together with the rest of series. > > Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel