From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F17EAC27C76 for ; Wed, 25 Jan 2023 21:14:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EWtAnRh8pv7GNuvwr7rNiA3OJA4d8zzaM9E5LdGpuzo=; b=qwkcc3o25addlF AyJTzqMzKvwnKmHN8hzWLpOXhCEO10z4cHLEhiSBWOZTx7aUVzMQiebVE8v7Rjfivq2IIMCZDP5Nr 7nifbvVxtKtJwsIvkYdjSpHLBo4d1KewyGgYuIW1NqqVFEEUzhX9ovnG2FrINXI7OEy5jlvdRfGFe E0TNotwCuoXaRW/H2Sm20PzMR0otioyRmP6tANVbvWzF7543L9XlsuE5IikD8AL5YVz1Np06X8wZI T35g0bgV6lHpF0SphZsPIwMQMQb+K0QCclVxMXSaIM6TtIE71gxobDtqI43p6ck2IDO80qUItei/w /W47hvfxYvI3InsWXnxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKn5M-008p0c-PA; Wed, 25 Jan 2023 21:13:36 +0000 Received: from mail-oi1-f176.google.com ([209.85.167.176]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKn5I-008ozs-Lm for linux-arm-kernel@lists.infradead.org; Wed, 25 Jan 2023 21:13:34 +0000 Received: by mail-oi1-f176.google.com with SMTP id bm8so2185200oib.0 for ; Wed, 25 Jan 2023 13:13:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mxxLu5neQmd1wkijNxY+uQAZdlFfbPPJYNilQTfY588=; b=0rTNeY751ypzUBtU87BUZJcKL0iSQhwfjBOSS3iYoN9DxEB/+ydKausMLki7Gq6IhE 8wG2JmfgKOakLbNLanYIc9sMjdNRyAx1fnBf/n91ie0ZL0w9SqROhCxVY6srdNlx5xru nAtKisM8KZeWg2lxWZ1OczhQvjqLq/C2WQaV6X0pCVessy1bem/48V348Mp/YxgGTqdX xvi9lHVB3gVLHaixtd7RurZlveb/8uqzHJKWpRk9ZtFFkSbNhqIjU4y6kZKIp/sprxuN jjWvQeL/omv3EEkeH0HLzeewyagB0iG++CNWz/ENhAsDaxOVgE/81X3TI/vfjv6uF/p7 c45Q== X-Gm-Message-State: AFqh2kqW8+MGTUlBnA6CF39XnDfu/8XnPf3zmoGk04nm/tUea8Pv7cZu rc1Wmj9bp1k9ZTzos6VgDA== X-Google-Smtp-Source: AMrXdXu/SugN1OZvYht+GqN+hP045IwbIzwV4tVY82cvphVKskkZ9RCsN4cRd8p4EMcNXA2Injxghg== X-Received: by 2002:aca:1b0a:0:b0:364:ef1f:90e with SMTP id b10-20020aca1b0a000000b00364ef1f090emr14953639oib.28.1674681210360; Wed, 25 Jan 2023 13:13:30 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id h22-20020a9d6016000000b00670461b8be4sm2607200otj.33.2023.01.25.13.13.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 13:13:30 -0800 (PST) Received: (nullmailer pid 2902560 invoked by uid 1000); Wed, 25 Jan 2023 21:13:29 -0000 Date: Wed, 25 Jan 2023 15:13:29 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: Greg Kroah-Hartman , Krzysztof Kozlowski , Alim Akhtar , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: usb: samsung,exynos-dwc3: allow unit address in DTS Message-ID: <20230125211329.GA2899932-robh@kernel.org> References: <20230125175943.675823-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230125175943.675823-1-krzysztof.kozlowski@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230125_131332_729709_AD97D183 X-CRM114-Status: GOOD ( 20.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 25, 2023 at 06:59:43PM +0100, Krzysztof Kozlowski wrote: > The Samsung Exynos SoC USB 3.0 DWC3 Controller is a simple wrapper of > actual DWC3 Controller device node. It handles necessary Samsung > Exynos-specific resources (regulators, clocks), but does not have its > own MMIO address space. > > However neither simple-bus bindings nor dtc W=1 accept device nodes in > soc@ node which do not have unit address. Therefore allow using > the address space of child device (actual DWC3 Controller) as the > wrapper's address. The correct fix is 'ranges' should have a value. Though the whole wrapper thing when there are no registers I dislike... > Signed-off-by: Krzysztof Kozlowski > > --- > > DTS fixes are here: > https://lore.kernel.org/linux-samsung-soc/20230125175751.675090-1-krzysztof.kozlowski@linaro.org/T/#t > --- > .../devicetree/bindings/usb/samsung,exynos-dwc3.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml b/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml > index 6b9a3bcb3926..a94b1926dda0 100644 > --- a/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml > +++ b/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml > @@ -29,6 +29,9 @@ properties: > > ranges: true > > + reg: > + maxItems: 1 > + > '#size-cells': > const: 1 > > @@ -108,8 +111,9 @@ examples: > #include > #include > > - usb { > + usb-wrapper@12000000 { > compatible = "samsung,exynos5250-dwusb3"; > + reg = <0x12000000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges; > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel