From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30C38C54E94 for ; Wed, 25 Jan 2023 21:19:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0y7V9aGAJqMkf8SsW77cFX+hC7+wHLpPFIS9ZrbFX04=; b=wdSLgyZ+sWMylc K7tN0Tqyn2HgNdfkEQoEa+swbGbrAnssxAoqpUK9O0h/QVilQZCzUhHipo13FXnDa4DJdLHHYCUPd 4tJcGF4jOsPzxu7WuoJOeX0Ma9fRWdvX2zISYQR1cjB79wiAu74Tj9EpyBwYcmfF5mOtIOfsXvKIK QK0mDDvzScd0JRs33vp3NcUU1KGtc5RthyyGmNvDwiMnYY2q6rgPjKAcH3AYH5ciegGOngrb4BYIl yfYKK5I7/CN4BXbVCV+DBG0MEl/UPYc4UPeijGK3r7eM1YNeovGcKFgSZjSDjRzi5O+ndYL7ZSJ05 4uwyc6I5yPl1Hs7VK4xQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKn9t-008q3d-Jj; Wed, 25 Jan 2023 21:18:17 +0000 Received: from mail-oo1-f54.google.com ([209.85.161.54]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKn9q-008q2s-OA for linux-arm-kernel@lists.infradead.org; Wed, 25 Jan 2023 21:18:16 +0000 Received: by mail-oo1-f54.google.com with SMTP id u13-20020a4aa34d000000b004f5219f9424so17823ool.5 for ; Wed, 25 Jan 2023 13:18:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bp0mxhbOHK5m7E/8vPnnoJoZCeVsj8BETflMMGfFRwo=; b=L0XhdE2C8t6BWA1qu0DY5P82NuO9b5eIhXaIh7lP41+ACjoYgdmNiDBx6uQilzzarK b+M/YPgLHeuJWZ4AJufn/jKIaVGUJPLaKJ6yWiaS3lbOjLNFGK1NLFhzjxNmHO8LdK79 qcXQiUzYOXwaDbM3zLG4Hsm5CS++/gcUsmW6pC205WLm2SY1InrWjdxsIqaXaC/jyEiu 8mfRwi0Qrzb+P3VDTpVea33F/itXSmvJsMHtc6nn5p4wqv7iDqialdm6UcBBs6Q3Ng5N yTBJj0hmQ8L8y923RaQ4Sfna2TC45U7PgVjsciTLr0e/RABw9YXPcurJ1MU2ZD7Dg63f 8hyA== X-Gm-Message-State: AFqh2kqEJT1NAtIt8sz3RLTtd1k8+LgsBowBMgpweu78b7/UO2vRVBVf goEtcXA/CXt9IsGW03pdag== X-Google-Smtp-Source: AMrXdXtVWuRQFhdtS4eZUn6+6TSg6l1vpWoxw0m087w2Ydp334vj17fhVuVkwi0NjMRkFZvJ5FeGOg== X-Received: by 2002:a4a:a509:0:b0:4f2:2208:46a2 with SMTP id v9-20020a4aa509000000b004f2220846a2mr16168854ook.8.1674681492788; Wed, 25 Jan 2023 13:18:12 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id b1-20020a4aba01000000b004f269f9b8f3sm2316082oop.25.2023.01.25.13.18.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 13:18:12 -0800 (PST) Received: (nullmailer pid 2907514 invoked by uid 1000); Wed, 25 Jan 2023 21:18:11 -0000 Date: Wed, 25 Jan 2023 15:18:11 -0600 From: Rob Herring To: nick.hawkins@hpe.com Cc: verdun@hpe.com, krzysztof.kozlowski+dt@linaro.org, linux@armlinux.org.uk, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, joel@jms.id.au Subject: Re: [PATCH v4 2/5] dt-bindings: i2c: Add hpe,gxp-i2c Message-ID: <20230125211811.GA2902717-robh@kernel.org> References: <20230125184438.28483-1-nick.hawkins@hpe.com> <20230125184438.28483-3-nick.hawkins@hpe.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230125184438.28483-3-nick.hawkins@hpe.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230125_131814_803918_AE915641 X-CRM114-Status: GOOD ( 24.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 25, 2023 at 12:44:35PM -0600, nick.hawkins@hpe.com wrote: > From: Nick Hawkins > > Document compatibility string to support I2C controller > in GXP. > > Signed-off-by: Nick Hawkins > > --- > v4: > *Provide even greater description with the use > of Phandle > *Reorder properties so they match the required > order > v3: > *Provide better description with use of Phandle > v2: > *Removed uneccessary size-cells and address-cells > *Removed phandle from hpe,sysreg-phandle > *Changed hpe,i2c-max-bus-freq to clock-frequency > --- > .../devicetree/bindings/i2c/hpe,gxp-i2c.yaml | 59 +++++++++++++++++++ > 1 file changed, 59 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/hpe,gxp-i2c.yaml > > diff --git a/Documentation/devicetree/bindings/i2c/hpe,gxp-i2c.yaml b/Documentation/devicetree/bindings/i2c/hpe,gxp-i2c.yaml > new file mode 100644 > index 000000000000..6604dcd47251 > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/hpe,gxp-i2c.yaml > @@ -0,0 +1,59 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/i2c/hpe,gxp-i2c.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HPE GXP SoC I2C Controller > + > +maintainers: > + - Nick Hawkins > + > +allOf: > + - $ref: /schemas/i2c/i2c-controller.yaml# > + > +properties: > + compatible: > + const: hpe,gxp-i2c > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clock-frequency: > + default: 100000 > + > + hpe,sysreg: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to the global status and enable interrupt registers shared > + between each I2C engine controller instance. It enables the I2C > + engine controller to act as both a master or slave by being able to > + arm and respond to interrupts from its engine. Each bit in the > + registers represent the respective bit position. Each bit represents the bit position? AIUI, each I2C instance has a bit in it needs to control. How does the driver know what instance (and therefore the correct bit)? Typically you would have a 2nd cell here with that information. > + > +required: > + - compatible > + - reg > + - interrupts > + > +unevaluatedProperties: false > + > +examples: > + - | > + i2c@2600 { > + compatible = "hpe,gxp-i2c"; > + reg = <0x2500 0x70>; > + interrupts = <9>; > + #address-cells = <1>; > + #size-cells = <0>; > + hpe,sysreg = <&sysreg_system_controller>; > + clock-frequency = <10000>; > + > + eeprom@50 { > + compatible = "atmel,24c128"; > + reg = <0x50>; > + }; > + }; > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel