From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34472C54E94 for ; Thu, 26 Jan 2023 15:51:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=TuV0mAU5rTskktHEb3WDQUPL7x+xUfX0MS08pH34mN4=; b=p+DKMUzPUEYmHl ziEQCkRKrGAZXsfUIGFM8zLUQuNHyidSem9egnkx9mgRgM3wu/vV3CVOjXFgoyEUWHiqpSs1gw3Or zJAdxTkKXtJ0TX3rtTAJoC6MhRozPrSokXeGPzor9boZuyvmR5N8gevsrNlBXmx6SyRxUVs4payK7 TQC7UVXzhRXO+S0CfmhV8LDrKQdizXLWBaUvNOVZyitZu1QLAgI6Au9yVq5gUUXb0okXTiaM/Ax6G OxRRmoI1taRDmocyInCgR9ig1/8qJiDcv8rl2/Ia032VcMrSnKJs5kt3WeljN2O8VDeHsnGz/O6X6 RbkA1741HvLhNvRQdxNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pL4Vp-00Bbo9-6W; Thu, 26 Jan 2023 15:50:05 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pL4Vl-00Bbll-LX; Thu, 26 Jan 2023 15:50:03 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0A286B81E6F; Thu, 26 Jan 2023 15:50:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F9D5C4339B; Thu, 26 Jan 2023 15:49:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674748198; bh=tz37H93KJoXT7koLr1H4HT5GaXKxGQjDxvtFWm7fYOY=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=jqXQMHePLVFSiJqj0BgbGZMSJfFzBNY1s6BwEQB8uiax+WOjHz0lV4186ZtQdvbU3 VlcXlHGw+7BSYxkQhOdJkzk5JGC3Sjei/OXUTgUyXuis2MgcgbNTcTFDhBGwtHsapv BWjzD2QkPbh4tcAjQOAWHKvfEIc7v7GVmCAWqYo0dL1dMpif0lnkTtRgmiIgdyTYnv HVwbngVuGhfvugMn/7DfKFiw47VQtQ6TJQaM9BwGmw6P3Q2Xitjm1qmI9trS1Atlk8 JJoBV0NzEojUnCR5P0ARoBsXnZYnZ7iK+BEISeiOB51RuC05DGjF6/mWBB0AUtiM01 iL+0jwwg2LTxg== Date: Thu, 26 Jan 2023 09:49:56 -0600 From: Bjorn Helgaas To: Rick Wertenbroek Cc: alberto.dassatti@heig-vd.ch, xxm@rock-chips.com, wenrui.li@rock-chips.com, rick.wertenbroek@heig-vd.ch, Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Jani Nikula , Greg Kroah-Hartman , Rodrigo Vivi , Mikko Kovanen , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 0/8] PCI: rockchip: Fix PCIe endpoint controller driver Message-ID: <20230126154956.GA1278063@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230126_075001_945301_C8AF9867 X-CRM114-Status: GOOD ( 29.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 26, 2023 at 04:23:57PM +0100, Rick Wertenbroek wrote: > Le jeu. 26 janv. 2023 =E0 15:52, Bjorn Helgaas a =E9= crit : > > Thanks very much for your work. > > > > On Thu, Jan 26, 2023 at 02:50:40PM +0100, Rick Wertenbroek wrote: > > > This is a series of patches that fixes the PCIe endpoint controller d= river > > > for the Rockchip RK3399 SoC. It is based on Linux kernel 6.0.19 > > > > > > The original driver in mainline had issues and would not allow for the > > > RK3399 to operate in PCIe endpoint mode. This patch series fixes that= so > > > that the PCIe core controller of the RK3399 SoC can now act as a PCIe > > > endpoint. > > > > So we merged cf590b078391 ("PCI: rockchip: Add EP driver for Rockchip > > PCIe controller") when it actually didn't work? Ouch. Thanks for > > fixing it and testing it. > = > It seems it wasn't fully tested, the code compiles and kernel module load= s, > but further functionality didn't seem to have been tested > (e.g., lspci, and with the pcitest tool and pci_endpoit_test_driver). OK, I guess that happens sometimes. Glad you're getting it into shape! > Does this mean I should refer to the commit cf590b078391 > ("PCI: rockchip: Add EP driver for Rockchip PCIe controller") ? > Because it wasn't working in the first place ? Yes, I think so. > Thank you for all the pointers, I'll take them into account for the > next iteration. This is the first time I actually submitted a series of > patches to the LKML so it's all relatively new to me. Welcome to Linux, and great start! Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel