Re: [PATCH 0/3] Rust enablement for AArch64

Miguel Ojeda
2023-01-25T18:02:26Z

Hi Jamie,

On Wed, Jan 25, 2023 at 5:37 PM Jamie Cunliffe <Jamie.Cunliffe@arm.com> wrote:
>
> The first patch is from Miguel's tree to enable Rust support for
> AArch64. This has been tested with the Rust samples, and the generated
> code has also been manually inspected.

Thanks a lot for this -- it is great to hear the prototype arm64
support we had at least made some basic sense :)

I imagine eventually we will need more changes on the target like BE
vs. LE, shadow call stack, extensions, etc., right?

> The second patch enables the PAC ret and BTI options in the Rust build
> flags to match the options that are used when building C.
>
> The third patch disables the neon and fp target features to avoid fp &
> simd registers. The use of fp-armv8 will cause a warning from rustc
> about an unknown feature that is specified. The target feature is
> still passed through to LLVM, this behaviour is documented as part of
> the warning. This will be fixed in a future version of the rustc
> toolchain. This pull request should address it,
> https://github.com/rust-lang/rust/pull/107294

Great, thanks a lot. I have linked this one at
https://github.com/Rust-for-Linux/linux/issues/355 (if you have
others, please let me know, it would be ideal to track them there)

On upstreaming: it would be great if ARM64 maintainers can take a look
(and please feel free to take it through your tree as well!).

Cheers,
Miguel