From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF5FEC54E94 for ; Thu, 26 Jan 2023 16:50:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3LKxYry/csw0dTBYpBmOYGZBm9Tv6s+/w5Lo7VdiOIg=; b=Yfn6YCGA3L22Gy fkdylMwB2EnKJMXNHrME7kUfsUhMBnD+xcuNUIc+RHcL7eoHF1oyry7RSIY1v3hniLu0YXlKB+JV4 Hui6qGzVumHJ6RMDoMJuP68oUVUklDkdKhlMO5O7XewprZxm5LyMdrm49/7sGPD1UZm1j5nZ4oa4I rOuy42Ranchv4eUrHdn+CJ7k42EOF5tm2POM/Zh0JS08K/nKhMZzn1WscdBjKBITRiXOtPhXWymR9 em8fQ2TGFCen1s9zdnQ8wQxKgfXKJQ0P9Nl9U7CRpFH7ku4Rp0vc7iusRnzooCDAm5z6yYH4nn6LY a2IYhgHr3du/VyuCkc8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pL5RO-00BrvU-Uo; Thu, 26 Jan 2023 16:49:35 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pL5GD-00BoXg-LN for linux-arm-kernel@lists.infradead.org; Thu, 26 Jan 2023 16:38:03 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id ED12FB81EAA; Thu, 26 Jan 2023 16:37:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7ECF3C4339C; Thu, 26 Jan 2023 16:37:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674751078; bh=YqJQPd6i+gA5E2jZwlvWvEvyUYqWpVbVfimCUEJBLMA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qOoCtEScxidUmhC1+tzaExoii3UN3nWJNV3aPzHGU/YaZyfIVd3o6XGFZi1InXRvX ZK6L960rHyONjKWliHj0QfYlIKy4KlOZZrj0G84O1FOhf875jeI2kEMQ5TXxa937YD DVtNrjQouRjYaX9XvuOssbWQ3ogaDeCIrrCrI8W0BWhDafLXT8xsomwfy48BqokVgR hDpbAFDrxtwQmjZjtgJAtBjA/+MAgJCAgKrKf7DsF3vFO/Mq4QYJmb6e1tbSUQ7LZu mJ0wAq4rY2alqAgJCcLIfn9ukYa89IHEhjtcnk6CBgzb7fMdrWwSCSpPVQloZ/roId zBZgTheNaPMbQ== Date: Thu, 26 Jan 2023 16:37:54 +0000 From: Will Deacon To: Jamie Cunliffe Cc: linux-arm-kernel@lists.infradead.org, rust-for-linux@vger.kernel.org, Miguel Ojeda , Catalin Marinas , steve.capper@arm.com Subject: Re: [PATCH 3/3] arm64: rust: Disable neon and fp target features. Message-ID: <20230126163752.GE29438@willie-the-truck> References: <20230125163739.3798252-1-Jamie.Cunliffe@arm.com> <20230125163739.3798252-4-Jamie.Cunliffe@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230125163739.3798252-4-Jamie.Cunliffe@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230126_083801_891072_33D9857D X-CRM114-Status: GOOD ( 17.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 25, 2023 at 04:37:39PM +0000, Jamie Cunliffe wrote: > Disable the neon and fp target features to avoid fp & simd > registers. The use of fp-armv8 will cause a warning from rustc about > an unknown feature that is specified. The target feature is still > passed through to LLVM, this behaviour is documented as part of the > warning. This will be fixed in a future version of the rustc > toolchain. > > Signed-off-by: Jamie Cunliffe > --- > arch/arm64/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile > index b53ab6aa2dfe..33ae20fc3f56 100644 > --- a/arch/arm64/Makefile > +++ b/arch/arm64/Makefile > @@ -41,6 +41,8 @@ KBUILD_CFLAGS += -mgeneral-regs-only \ > KBUILD_CFLAGS += $(call cc-disable-warning, psabi) > KBUILD_AFLAGS += $(compat_vdso) > > +KBUILD_RUSTFLAGS += -C target-feature="-neon,-fp-armv8" Why do we advertise these features as present in scripts/generate_rust_target.rs? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel