From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFE0DC52D11 for ; Thu, 26 Jan 2023 17:05:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UJRWe/b7VuppccLOccsuMfEau843q2p1TKqvbDTVk/0=; b=xY78RbIbbLvRqg /BWfq1i/LytvVkXkUYlrAbGVE/R6cOfrgzKSK0n0vXbfktJXaEy4Z0BXL6U1oSFBCBM+RAgAVcCTm xASXzwhb+qpCkbOf0ZC+HMWf1fK046bGxomgHR35Mk15qSpLImIR4Y477GBu/97e+H/keWVp9vr8Y fWDJYIgsi6u/YZcdp8eBteSCjjnCYUTcYg30OXKBu+ET0NEuSIvIAG3s1cFirT8fzCn8OlBeEwiT3 VDb2c9EN/bph9OwHDCxZz/BfKbYBSmIgRdIM4YwMzN5p6KgfShZnu3PROMG02kM+yjrWgTGrCko6b DsaOIBgneoEmwEwmTxeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pL5fj-00Bx6a-3l; Thu, 26 Jan 2023 17:04:23 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pL5ff-00Bx3e-A9 for linux-arm-kernel@lists.infradead.org; Thu, 26 Jan 2023 17:04:21 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6310A4B3; Thu, 26 Jan 2023 09:04:57 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 889473F64C; Thu, 26 Jan 2023 09:04:14 -0800 (PST) Date: Thu, 26 Jan 2023 17:04:12 +0000 From: Sudeep Holla To: Rob Herring Cc: Cristian Marussi , Sudeep Holla , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: firmware: arm,scmi: Restrict protocol child node properties Message-ID: <20230126170412.4ytcky6a7lnll6it@bogus> References: <20230124222023.316089-1-robh@kernel.org> <20230125141113.kkbowopusikuogx6@bogus> <20230126144647.6q3qlu5sqz27cmyc@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230126_090419_505216_9CE48B9B X-CRM114-Status: GOOD ( 37.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 26, 2023 at 09:25:12AM -0600, Rob Herring wrote: > On Thu, Jan 26, 2023 at 8:46 AM Sudeep Holla wrote: > > > > On Thu, Jan 26, 2023 at 09:43:44AM +0000, Cristian Marussi wrote: > > > On Wed, Jan 25, 2023 at 02:11:13PM +0000, Sudeep Holla wrote: > > > > On Wed, Jan 25, 2023 at 01:43:48PM +0000, Cristian Marussi wrote: > > > > > so now that the catch-all protocol@ patternProperty is gone in favour > > > > > of the 'protocol-node' definition and $refs, does that mean that any > > > > > current and future SCMI officially published protocol has to be > > > > > added to the above explicit protocol list, even though it does not > > > > > have any special additional required property beside reg ? > > > > > (like protocol@18 above...) > > > > > > > > > > > > > If there are no consumers, should we just not add and deal with it > > > > entirely within the kernel. I know we rely today on presence of node > > > > before we initialise, but hey we have exception for system power protocol > > > > for other reasons, why not add this one too. > > > > > > > > In short we shouldn't have to add a node if there are no consumers. It > > > > was one of the topic of discussion initially when SCMI binding was added > > > > and they exist only for the consumers otherwise we don't need it as > > > > everything is discoverable from the interface. > > > > > > It is fine for me the no-consumers/no-node argument (which anyway would > > > require a few changes in the core init logic anyway to work this way...), > > > BUT is it not that ANY protocol (even future-ones) does have, potentially, > > > consumers indeed, since each protocol-node can potentially have a dedicated > > > channel and related DT channel-descriptor ? (when multiple channels are > > > allowed by the transport) > > > > > > I mean, as an example, you dont strictly need protos 0x18/0x12 nodes for > > > anything (if we patch the core init as said) UNLESS you want to dedicate > > > a channel to those protocols; so I'm just checking here if these kind of > > > scenarios will still be allowed with this binding change, or if I am > > > missing something. > > > > Ah, good point on the transport information. Yes we will need a node if > > a protocol has a dedicated transport. No one has used so far other than > > Juno perf, but we never know. We can always extended the bindings if > > needed. > > > > Sorry for missing the dedicated transport part. > > So I need to add back 'protocol@.*' or not? IMO it is better to know what exactly gets added under each of these protocol sub-nodes and so better to have entry specific to each known protocols. I liked that fact with this change as I have seen some crazy vendor extensions adding all sorts of non-sense defining some vendor protocol. For example [1], in which case we can catch those better than existing schema which matches all. So let's not add protocol@.* if possible or until that becomes the only cleaner way to maintain this. -- Regards, Sudeep [1] https://lore.kernel.org/all/1667451512-9655-2-git-send-email-quic_sibis@quicinc.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel