From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E0C8C38142 for ; Sat, 28 Jan 2023 07:14:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0IexPSPKB90K9omdJK85jSk3X3pAE5PdBGKkXnpt0iI=; b=OKocMLZsdmxXy1 inGOadep0ypNpSZtcR8iFyHVoHjKM8iYGrCwHACtn9tKd+i2dH8fE5f7ZMSl/FI+vWmO4lsGatpUo pETX+suHJv6Ew0WJM6J6p9dhML+IAmC9VEbWGyXL115l6zUzuW60CX2juoWJIHdPZ815kII0UpM36 dCuXtWYiJctifvCQpJVDjs4IDecs0Y0H1h2y0oH1YDzPMJqALafICvMmEJ7hiXXu5inmtFDgT0Hm3 ix/XG25S1lvrPgADnb2WUUyQHRLp7HB3saDUrCWH6hrX97UlvGzculv3sbniV6zsJFipeA6mmZNLH LNufP65f6G8aQabWBoXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLfOy-00HKFN-CQ; Sat, 28 Jan 2023 07:13:28 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLfOv-00HKF2-VZ for linux-arm-kernel@lists.infradead.org; Sat, 28 Jan 2023 07:13:27 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C349860906; Sat, 28 Jan 2023 07:13:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C660FC433D2; Sat, 28 Jan 2023 07:13:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674890004; bh=q0lYhtfJI2Xy2767Vzy1SEGyYt0U3k0GB0QJkNmaVJY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nWC2UPLY8wGEXTHo4SvSVCzGEvNVtu3ejt/pihbdy7C+8AOg6cwB2XvvV3A7q638D vizRwHQZeOf7xdgujjZAGW41AMhkfZLmG4ECJ34c+TYlTLpJm21c/hn5SmS0ayIP9M 7BmiM5itdzQZyLjPtpPV7JO64NBDNcdc1mm/CPIZBy6cUc2nJLr+3XLikEOvIqs09z 78QkU3n3hoY1LfoiY9stN26Un4Gbe8WP6peWVhvW5wJ1uOkoU1YAv/x3M2SQVQeSYT qBHWq2qzOSLFf13ab9s0Q6bsZxXqTMEtWOpR5GX92wcfaF+Nrx5jNA7Ojc6Tc09Vh+ QcSKH/4Hbbn+g== Date: Fri, 27 Jan 2023 23:13:22 -0800 From: Jakub Kicinski To: Jonas Suhr Christensen Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, michal.simek@xilinx.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, esben@geanix.com Subject: Re: [PATCH 2/2] net: ll_temac: improve reset of buffer on dma mapping Message-ID: <20230127231322.08b75b36@kernel.org> In-Reply-To: <20230126101607.88407-2-jsc@umbraculum.org> References: <20230126101607.88407-1-jsc@umbraculum.org> <20230126101607.88407-2-jsc@umbraculum.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230127_231326_103989_B213B291 X-CRM114-Status: UNSURE ( 7.55 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 26 Jan 2023 11:16:07 +0100 Jonas Suhr Christensen wrote: > Free buffer and set pointer to null on dma mapping error. Why? I don't see a leak. You should provide motivation in the commit message. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel