From: Jakub Kicinski <kuba@kernel.org>
To: Jonas Suhr Christensen <jsc@umbraculum.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, michal.simek@xilinx.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, esben@geanix.com
Subject: Re: [PATCH 1/2] net: ll_temac: fix DMA resources leak
Date: Fri, 27 Jan 2023 23:20:34 -0800 [thread overview]
Message-ID: <20230127232034.1da0f4e1@kernel.org> (raw)
In-Reply-To: <20230126101607.88407-1-jsc@umbraculum.org>
On Thu, 26 Jan 2023 11:16:06 +0100 Jonas Suhr Christensen wrote:
> Add missing conversion of address when unmapping dma region causing
> unmapping to silently fail. At some point resulting in buffer
> overrun eg. when releasing device.
Could you add a Fixes tag pointing to the commit which introduced
the bug? It will help the stable teams backport the patch.
When reposting please put [PATCH net v2] as the prefix (noting
the target tree for the benefit of bots/CIs).
> Signed-off-by: Jonas Suhr Christensen <jsc@umbraculum.org>
> ---
> drivers/net/ethernet/xilinx/ll_temac_main.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c
> index 1066420d6a83..66c04027f230 100644
> --- a/drivers/net/ethernet/xilinx/ll_temac_main.c
> +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
> @@ -300,6 +300,7 @@ static void temac_dma_bd_release(struct net_device *ndev)
> {
> struct temac_local *lp = netdev_priv(ndev);
> int i;
> + struct cdmac_bd *bd;
nit: we like variable declarations longest to shortest in networking
so before the int i; pls
> /* Reset Local Link (DMA) */
> lp->dma_out(lp, DMA_CONTROL_REG, DMA_CONTROL_RST);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-28 7:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 10:16 [PATCH 1/2] net: ll_temac: fix DMA resources leak Jonas Suhr Christensen
2023-01-26 10:16 ` [PATCH 2/2] net: ll_temac: improve reset of buffer on dma mapping Jonas Suhr Christensen
2023-01-28 7:13 ` Jakub Kicinski
2023-01-30 12:40 ` esben
2023-01-30 20:42 ` Jakub Kicinski
2023-01-28 7:20 ` Jakub Kicinski [this message]
2023-01-30 12:30 ` [PATCH 1/2] net: ll_temac: fix DMA resources leak esben
2023-01-30 21:56 ` Christophe JAILLET
2023-01-31 0:20 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230127232034.1da0f4e1@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=esben@geanix.com \
--cc=jsc@umbraculum.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).