From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2542CC27C76 for ; Sat, 28 Jan 2023 07:21:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2ywPLBvUgNoElDLq3ZFR8YQHg/B5b9Yt/3fdM4mjwM0=; b=LmM1BRmOyBLxn6 nx0/LDeUsxCKX1Oc3spJAFGYYotWnqzjkuL3vkxGRCbZXqWv80ga7GLYfwlp7Z3Groqrxh0Yfi9Mu EtSc4pqADPKuJ9rhPZmchOj3mzK9jGKlPw6YnY71dVNzxH1OST27Ol7bsl7KyXW3IFylWv7Z95BWU LF/b49ux6TIBKN0YH5OCFG6Y3AW3M+Nt1RHwjtdBV9Wp+PXnPqPqWgxFVGY6WkfzCbx/GI8RwLpsh 2BYmxpmm6mQ9GPIqOZh95OBZ3i3OhbCOaJIeyGcuVRX8+EL2uSM7cF5oR94QhHqU/KmDcFml9ZPtY DOmvWEny0q+f856jbCrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLfVx-00HKm1-56; Sat, 28 Jan 2023 07:20:41 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLfVu-00HKlE-9d for linux-arm-kernel@lists.infradead.org; Sat, 28 Jan 2023 07:20:39 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C3AD960A24; Sat, 28 Jan 2023 07:20:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C975FC433EF; Sat, 28 Jan 2023 07:20:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674890436; bh=HSM5+WHccH9bmMsZMOH7J0fLCjzl8QAwBswxLLCva8Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XjzKqu9BhG4LhxwImMSrK04c2BkLJkDIon4rxnks5ZNfvBRs/Wp1aHOoUbxny7Dc2 JZqK51rQGybT4zlCnceFMKILV7hufhWXwmfZ+WPehr7txZdi+1DYW+9YkoWh5Fw/lT HrltlW76/yCmsW6H+sgKTmaKYCFxZgdnGQ1g9WA/o9UIKMkt7QycYXtrI0FwOsJUgl s22mzdVh+9V0yxk0r0dPuvSaikS/YnK27TEju4GcYonr0g5MtG78KfgqLptK2Cnglq QQSflOs9NDi5YA2dvuW1dB+mqllrLzXqDpJkCYykQ0naHq7olfafJ2jIV1xMVmZHyZ rKiHwv+bb0IKg== Date: Fri, 27 Jan 2023 23:20:34 -0800 From: Jakub Kicinski To: Jonas Suhr Christensen Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, michal.simek@xilinx.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, esben@geanix.com Subject: Re: [PATCH 1/2] net: ll_temac: fix DMA resources leak Message-ID: <20230127232034.1da0f4e1@kernel.org> In-Reply-To: <20230126101607.88407-1-jsc@umbraculum.org> References: <20230126101607.88407-1-jsc@umbraculum.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230127_232038_406991_E483B1E9 X-CRM114-Status: GOOD ( 16.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 26 Jan 2023 11:16:06 +0100 Jonas Suhr Christensen wrote: > Add missing conversion of address when unmapping dma region causing > unmapping to silently fail. At some point resulting in buffer > overrun eg. when releasing device. Could you add a Fixes tag pointing to the commit which introduced the bug? It will help the stable teams backport the patch. When reposting please put [PATCH net v2] as the prefix (noting the target tree for the benefit of bots/CIs). > Signed-off-by: Jonas Suhr Christensen > --- > drivers/net/ethernet/xilinx/ll_temac_main.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c > index 1066420d6a83..66c04027f230 100644 > --- a/drivers/net/ethernet/xilinx/ll_temac_main.c > +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c > @@ -300,6 +300,7 @@ static void temac_dma_bd_release(struct net_device *ndev) > { > struct temac_local *lp = netdev_priv(ndev); > int i; > + struct cdmac_bd *bd; nit: we like variable declarations longest to shortest in networking so before the int i; pls > /* Reset Local Link (DMA) */ > lp->dma_out(lp, DMA_CONTROL_REG, DMA_CONTROL_RST); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel