From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E17CAC27C76 for ; Sat, 28 Jan 2023 15:35:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8+JM24eLRrtiSWDEvvGVtUA0Y5hJAwOpb0WFHxIhv6U=; b=Njxx4HIYPXRMNq fMkZUihelJ8j9IULT9x4LexXD4qmDMPimsV2vVHAKh9/WJP3Oi6pehrV2QZyMquBqOoX+IZ+D+UKc x2VwS0NWi8ZNzm2n/RrRKbqGvoC8LdDf6muA5hA7bJ22fDUACBhZPHcyodHRUahcHkONzp1Z7BnAz J2FC9IUvKUSCuNNdZbjvHOymVtQSFSG/2oZQ/EhEx8WI0wZNMaG4ryko++pq+fGMBfKwsAsXcX7hv lq4BBziO8DqzhvRsnSpTLgU/rrNIYYKNDqJA85Nk/L5WAEp8+dWJmk1LmUrJNDoxNFvO61n7nvk05 5tKRd2EVHMHaa+odXlpg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLnE3-000LxT-6A; Sat, 28 Jan 2023 15:34:43 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLnDz-000Lwf-F6; Sat, 28 Jan 2023 15:34:40 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 004CC60C1E; Sat, 28 Jan 2023 15:34:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD3AFC433D2; Sat, 28 Jan 2023 15:34:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674920078; bh=9p78P6cXR1b4UU7LmDHxucqXQwLRZGC/wmG/lLypzGo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Sy0kkDvx7E1gVGfY9fcdg6jg5BXRuQjvDhZ65C8k3WA9gemy6YC6wX3Gx8hJ6J27H 8x4NyS2i9dc7yo7IjeKLfkJbdrwJvnmDYjTa4VHC3ZyoFewAW5vk21MiodWH4XZwsX hne0KUqKUSiitaWQeznzMa5EsGNKQWvl+kY3QxWw+anNiuYxGsLpiX903y2CKtuGcp 1fpsi44mIXd51SeVfoW/J74LAmTLYdVHs6Gm3e4i8FSUlAL+oM3JvIYVMzXpMO2fFv E1feNPP7OEIcUHmrswPBcbUTonWBEPjeef08rq4yiie66P9WWGcsokUtwiNIK3F1g9 /JHmxQiRyr/aQ== Date: Sat, 28 Jan 2023 15:48:27 +0000 From: Jonathan Cameron To: Gatien Chevallier Cc: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Loic PALLARDY Subject: Re: [PATCH v3 3/6] dt-bindings: bus: add STM32 System Bus Message-ID: <20230128154827.4f23534e@jic23-huawei> In-Reply-To: <20230127164040.1047583-4-gatien.chevallier@foss.st.com> References: <20230127164040.1047583-1-gatien.chevallier@foss.st.com> <20230127164040.1047583-4-gatien.chevallier@foss.st.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230128_073439_577123_7049C894 X-CRM114-Status: GOOD ( 10.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 27 Jan 2023 17:40:37 +0100 Gatien Chevallier wrote: > Document STM32 System Bus. This bus is intended to control firewall > access for the peripherals connected to it. > > Signed-off-by: Gatien Chevallier > Signed-off-by: Loic PALLARDY Trivial comment on formatting. > + > +examples: > + - | > + // In this example, the rng1 device refers to etzpc as its domain controller. > + // Same goes for fmc. > + // Access rights are verified before creating devices. > + > + #include > + #include > + #include > + > + etzpc: bus@5c007000 { > + compatible = "st,stm32mp15-sys-bus"; > + reg = <0x5c007000 0x400>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + feature-domain-controller; > + #feature-domain-cells = <1>; > + > + rng1: rng@54003000 { Odd mixture of 4 spacing and 2 spacing in this example. I'd suggest one or the other (slight preference for 4 space indents). > + compatible = "st,stm32-rng"; > + reg = <0x54003000 0x400>; > + clocks = <&rcc RNG1_K>; > + resets = <&rcc RNG1_R>; > + feature-domains = <&etzpc 7>; > + status = "disabled"; > + }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel