From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A4DFC61D97 for ; Sun, 29 Jan 2023 02:51:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=OKI4s81hevIcUzyeF0VnrtK1wX4Ek6YXFkNkJAUEfww=; b=2Aktdvr50EufaP fgTmn8nuN7K/UnO/sGwktNMd2vXqR1SyiWxOrk/+fhjVc44mPglf8Kgm0jF/otPGEAdttwUr/eiYf A0RWUOg4yNwA9ooHFTbGILKQII5llFRKk+LQu5U4XpdBxcBomrh2B4cTY6d7VnaEfjk3T0NMncmTe c/3/FsHEd/X9PqVBc3LQ+4jaUY5leZwUj9ZCBqEAUDL0EiHoTncLmFtjKhpjE8OL3hC3O1wMO006/ MoyEwPDwKcXCJ+Gvlco2cer2QtZsjK7bZSCZwET/QpqUmBK7B6Qyfz97/gzEjqgwyU9F/CqA5jfvG wVX9Rc7GIlDjmaC4K1jw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLxll-000wfm-Uu; Sun, 29 Jan 2023 02:50:14 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLxlj-000wez-2C for linux-arm-kernel@lists.infradead.org; Sun, 29 Jan 2023 02:50:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674960611; x=1706496611; h=date:from:to:cc:subject:message-id:mime-version; bh=doxV5brD4WXUlkEwbHkmS2EH9JFHVIxKm5A4Lru2B70=; b=IkaToOd+WUgxFe8qt7ajGPGn6dauH8/2Ss+FNbKPGWIEqpKYLjP0xyMt b3mPC/BC4jeTU7v17R6ReChN0PQt3tGAy6s1AmcPSK7bAk+i0lyniiCNQ +ZV8HC8hubQFLuwUfR47tCmZkg2NdC1jIAITQESQybMrKWwc51Y/VbavH 8xdZRF+9u7hwDL7SBwgjS4f1L0OCDZQjwyhnrSTPMyNUK/GEQdv4EoWpr T3KgETjp1VLLczU+0NyHSbv4XOe3kE22eoEqz3w2ur3IIcPWQi/y3TQ3w WYTSBCeX3rzAZpCz7MC1p300WnzQvLMeOCMEU/9OtfeKsmrF82vQnH5eo Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10604"; a="307006668" X-IronPort-AV: E=Sophos;i="5.97,254,1669104000"; d="scan'208";a="307006668" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2023 18:50:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10604"; a="657040899" X-IronPort-AV: E=Sophos;i="5.97,254,1669104000"; d="scan'208";a="657040899" Received: from lkp-server01.sh.intel.com (HELO ffa7f14d1d0f) ([10.239.97.150]) by orsmga007.jf.intel.com with ESMTP; 28 Jan 2023 18:50:04 -0800 Received: from kbuild by ffa7f14d1d0f with local (Exim 4.96) (envelope-from ) id 1pLxlb-0001NP-2F; Sun, 29 Jan 2023 02:50:03 +0000 Date: Sun, 29 Jan 2023 10:49:32 +0800 From: kernel test robot To: Shravya Kumbham Cc: oe-kbuild-all@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Michal Simek , Harini Katakam Subject: [xilinx-xlnx:master 12130/14332] drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2650:5: warning: no previous prototype for 'axienet_ethtools_sset_count' Message-ID: <202301291046.6aAzSO4R-lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230128_185011_140802_69ABE143 X-CRM114-Status: GOOD ( 12.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Shravya, FYI, the error/warning still remains. tree: https://github.com/Xilinx/linux-xlnx master head: f9c8e14ae03c937a79e1c904d004d80a0db3647e commit: 0605a36e057480f3a83ae401e7ff59739da78e82 [12130/14332] net: xilinx: Ethtool statistics support config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20230129/202301291046.6aAzSO4R-lkp@intel.com/config) compiler: s390-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/Xilinx/linux-xlnx/commit/0605a36e057480f3a83ae401e7ff59739da78e82 git remote add xilinx-xlnx https://github.com/Xilinx/linux-xlnx git fetch --no-tags xilinx-xlnx master git checkout 0605a36e057480f3a83ae401e7ff59739da78e82 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/net/ethernet/xilinx/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All warnings (new ones prefixed by >>): In file included from arch/s390/include/asm/bitops.h:36, from include/linux/bitops.h:29, from include/linux/kernel.h:12, from include/linux/clk.h:13, from drivers/net/ethernet/xilinx/xilinx_axienet_main.c:25: drivers/net/ethernet/xilinx/xilinx_axienet_main.c: In function 'axienet_create_tsheader': include/linux/typecheck.h:12:25: warning: comparison of distinct pointer types lacks a cast 12 | (void)(&__dummy == &__dummy2); \ | ^~ include/linux/spinlock.h:251:17: note: in expansion of macro 'typecheck' 251 | typecheck(unsigned long, flags); \ | ^~~~~~~~~ include/linux/spinlock.h:384:9: note: in expansion of macro 'raw_spin_lock_irqsave' 384 | raw_spin_lock_irqsave(spinlock_check(lock), flags); \ | ^~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1124:17: note: in expansion of macro 'spin_lock_irqsave' 1124 | spin_lock_irqsave(&lp->ptp_tx_lock, flags); | ^~~~~~~~~~~~~~~~~ drivers/net/ethernet/xilinx/xilinx_axienet_main.c: At top level: >> drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2650:5: warning: no previous prototype for 'axienet_ethtools_sset_count' [-Wmissing-prototypes] 2650 | int axienet_ethtools_sset_count(struct net_device *ndev, int sset) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2673:6: warning: no previous prototype for 'axienet_ethtools_get_stats' [-Wmissing-prototypes] 2673 | void axienet_ethtools_get_stats(struct net_device *ndev, | ^~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2700:6: warning: no previous prototype for 'axienet_ethtools_strings' [-Wmissing-prototypes] 2700 | void axienet_ethtools_strings(struct net_device *ndev, u32 sset, u8 *data) | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/xilinx/xilinx_axienet_main.c: In function 'axienet_probe': drivers/net/ethernet/xilinx/xilinx_axienet_main.c:3232:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 3232 | bool slave = false; | ^~~~ drivers/net/ethernet/xilinx/xilinx_axienet_main.c: At top level: drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1761:12: warning: 'axienet_open' defined but not used [-Wunused-function] 1761 | static int axienet_open(struct net_device *ndev) | ^~~~~~~~~~~~ drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1449:12: warning: 'axienet_start_xmit' defined but not used [-Wunused-function] 1449 | static int axienet_start_xmit(struct sk_buff *skb, struct net_device *ndev) | ^~~~~~~~~~~~~~~~~~ vim +/axienet_ethtools_sset_count +2650 drivers/net/ethernet/xilinx/xilinx_axienet_main.c 2640 2641 /** 2642 * axienet_ethtools_sset_count - Get number of strings that 2643 * get_strings will write. 2644 * @ndev: Pointer to net_device structure 2645 * @sset: Get the set strings 2646 * 2647 * Return: number of strings, on success, Non-zero error value on 2648 * failure. 2649 */ > 2650 int axienet_ethtools_sset_count(struct net_device *ndev, int sset) 2651 { 2652 switch (sset) { 2653 case ETH_SS_STATS: 2654 #ifdef CONFIG_AXIENET_HAS_MCDMA 2655 return axienet_sset_count(ndev, sset); 2656 #else 2657 return AXIENET_ETHTOOLS_SSTATS_LEN; 2658 #endif 2659 default: 2660 return -EOPNOTSUPP; 2661 } 2662 } 2663 2664 /** 2665 * axienet_ethtools_get_stats - Get the extended statistics 2666 * about the device. 2667 * @ndev: Pointer to net_device structure 2668 * @stats: Pointer to ethtool_stats structure 2669 * @data: To store the statistics values 2670 * 2671 * Return: None. 2672 */ > 2673 void axienet_ethtools_get_stats(struct net_device *ndev, 2674 struct ethtool_stats *stats, 2675 u64 *data) 2676 { 2677 unsigned int i = 0; 2678 2679 data[i++] = ndev->stats.tx_packets; 2680 data[i++] = ndev->stats.rx_packets; 2681 data[i++] = ndev->stats.tx_bytes; 2682 data[i++] = ndev->stats.rx_bytes; 2683 data[i++] = ndev->stats.tx_errors; 2684 data[i++] = ndev->stats.rx_missed_errors + ndev->stats.rx_frame_errors; 2685 2686 #ifdef CONFIG_AXIENET_HAS_MCDMA 2687 axienet_get_stats(ndev, stats, data); 2688 #endif 2689 } 2690 2691 /** 2692 * axienet_ethtools_strings - Set of strings that describe 2693 * the requested objects. 2694 * @ndev: Pointer to net_device structure 2695 * @sset: Get the set strings 2696 * @data: Data of Transmit and Receive statistics 2697 * 2698 * Return: None. 2699 */ > 2700 void axienet_ethtools_strings(struct net_device *ndev, u32 sset, u8 *data) 2701 { 2702 int i; 2703 2704 for (i = 0; i < AXIENET_ETHTOOLS_SSTATS_LEN; i++) { 2705 if (sset == ETH_SS_STATS) 2706 memcpy(data + i * ETH_GSTRING_LEN, 2707 axienet_get_ethtools_strings_stats[i].name, 2708 ETH_GSTRING_LEN); 2709 } 2710 #ifdef CONFIG_AXIENET_HAS_MCDMA 2711 axienet_strings(ndev, sset, data); 2712 #endif 2713 } 2714 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel