From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67917C54EAA for ; Mon, 30 Jan 2023 03:41:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Message-Id:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2g6rPFEUSi0/HDCuhH3Y9j3aW8Vl+Dky4lZJWHXliwA=; b=VTs4K7gEVppk3M ffirk8Luh1wYZycvs+KTBu5yeqMolOXgslo1y43ZGfFaEQuN5tull0CMSGqRLvtEPrqTkthWHeVO4 w59EodE6vzKZk2Im/BYJOtYZ3qrEq21H+YU32sHdu/eAnripK8DX9pwBD0DXjo1jiuBBGRv8IUH6C z84InhJWCjVrR5evAbOwcQ69mVGW6Sa1u3Zblfip4atD0kJWfhW+pDwFCgGXjTsPfigqthCIjwu1A ZaQjt5Kov1cHHiKKvIP4VXd/yJKL3MPiNJz+9otdT3ILh0cf6brKNH3Zz+cxdtOdminDCZlS/LGO9 mLS5NGlL2nF0qO2P+Pjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pML0r-002I4K-8w; Mon, 30 Jan 2023 03:39:21 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pML0A-002I3c-QP for linux-arm-kernel@lists.infradead.org; Mon, 30 Jan 2023 03:38:40 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6513DB808CD; Sun, 29 Jan 2023 21:41:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93234C433D2; Sun, 29 Jan 2023 21:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1675028508; bh=hqXHTO4VkNQRccP0ht1WlUlKvTkgK5Dy4nZapxrAJPw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XIojVudBxrOJhjBRRvRiy+4k16/u4kp1zbQwV9TS/l210sipQl1kb+pKGFKMiqcwl nn6Uzusfp1gjNyW518MN8oXHnXMQWooV3x57CK0cSuaZLDD7RzynjNZ/iPqbaLHUcs MQnptE2bVS1qXGchZq62tR8LUM+dkbUTAybnrL8o= Date: Sun, 29 Jan 2023 13:41:47 -0800 From: Andrew Morton To: Liu Shixin Cc: Catalin Marinas , Will Deacon , Uladzislau Rezki , Christoph Hellwig , , , Subject: Re: [PATCH RFC] arm64/vmalloc: use module region only for module_alloc() if CONFIG_RANDOMIZE_BASE is set Message-Id: <20230129134147.f19ca0641f1133f3e3bc185b@linux-foundation.org> In-Reply-To: References: <20221227092634.445212-1-liushixin2@huawei.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230129_193839_163794_0C6AB444 X-CRM114-Status: GOOD ( 21.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 29 Jan 2023 10:44:31 +0800 Liu Shixin wrote: > Hi, > > > This patch seems to have been lost in the corner. Recently I've meet this problem again > > on v6.1, so I would like to propose this patch again. > > > Thanks, > > > On 2022/12/27 17:26, Liu Shixin wrote: > > After I add a 10GB pmem device, I got the following error message when > > insert module: > > > > insmod: vmalloc error: size 16384, vm_struct allocation failed, > > mode:0xcc0(GFP_KERNEL), nodemask=(null),cpuset=/,mems_allowed=0 > > > > If CONFIG_RANDOMIZE_BASE is set, the module region can be located in the > > vmalloc region entirely. Although module_alloc() can fall back to a 2GB > > window if ARM64_MODULE_PLTS is set, the module region is still easily > > exhausted because the module region is located at bottom of vmalloc region > > and the vmalloc region is allocated from bottom to top. > > > > Skip module region if not calling from module_alloc(). > > I'll assume this is for the arm tree. Acked-by: Andrew Morton _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel