From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC482C54EED for ; Mon, 30 Jan 2023 13:02:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fgVYLrY9BbAjCinMs/LKeLtL/IGYIC5Rd+re9e1jVGc=; b=O/mh/ep+nnfuOO IXWPBlK/4Gbd20+TggPa4y3sW25ypAVU66WIL67PySnlOVs16F/sJQwqkiOE6urHkzkwlo5eNMyQH d10F/zmtjSAZK1r5m3QNQKsPk+0wJC6Qr748eJ/tkqfCg9ddhJkxcvNIHSXTR4Pn9Tt/Ly+Br7wcL pF47KprLpu+X0iKHK0VNPs/lZoeNWLPW5ceBARMpGBRuwFDIZK2zaPcaU15JpUg4ubQYV1NbELfi9 HP9zEOzRF3BInMQZ2VVWkjeeR3t4il39Hq9WPEsO3JoGfQYWSwzmx9zcyX0mIAI5NCGvrUZgHKv3u rxc2m73BtppguMwoPGhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMTlj-003aE4-7p; Mon, 30 Jan 2023 13:00:19 +0000 Received: from new3-smtp.messagingengine.com ([66.111.4.229]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMTiW-003ZU7-E0 for linux-arm-kernel@lists.infradead.org; Mon, 30 Jan 2023 12:57:02 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 37C9A582269; Mon, 30 Jan 2023 07:56:52 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 30 Jan 2023 07:56:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1675083412; x= 1675090612; bh=qHYBYqPItFEfJ7P/fVhrn/EUsBFwwjGYixrdWPu1haw=; b=I ofWpm5+KolRBGZBlrubmed5zH3WXoj0SRjQRfkZQPHr3Eitv6rN6olSd049GPAjx diZY7Ppan4Zr36fQndfzWrX84ATmf06kTzcYx0ohRmJud1I4dRapcGDlygO81qLo uPKsFeYJyekBIPmT9CnL7OMq6/OV+u84DanBQgsqbEavsmLxmWOfMByEcUTHY/jq hwYqq2W79Jpg8DHoJ/ko0N1+QtKkeOzcMtBbSHFXodJVYgDw2y3Jl4+76kW2f3ID pnPnqT7FMBBOm1WVadpxBRTxC1W6tzKsUIerO0e9pBFTjKuB1NB7iE4f2PK3HDHE MGi9yvhTcR4piQeeygN2Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1675083412; x= 1675090612; bh=qHYBYqPItFEfJ7P/fVhrn/EUsBFwwjGYixrdWPu1haw=; b=Q BgmBfVJnJFlFdLD8O4ERMPxf4/9EJUzx5V5tQbR8RIcCtYa53Hv8oR71tFzygwAJ hVfQWuNVMLTbJYLPfOwJ9qsO64E3EIvl+fGAKQzUKerE/2fKEZ8DBkuQw5G3Dc/Q pyV+rZ4U8WT0DgQo9oGfNUblzTsme+kGkj+mfbtGm4RfS3mwD0rl9eYyR9IZHVTo A0G4iDMAIf81WjRBiH0YwVXQG7Rk1aYLrM/l8MJTYtu59p8Ke+Dt1Epvpefqm4FM jtmwYvQw8FOFoHQkBLPgLj+feb/lbRNfj2u4yzQtPFkR5ywWw9SePoFLfcXHg1Vp bO4B66KGPqDBbm42hwNXA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudefvddggeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggugfgjsehtqhertddttddvnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhephfduvdejlefhteetffdvgfeuhedvueeggfetheeihfektefftddtieff vddtueehnecuffhomhgrihhnpehgihhthhhusgdrtghomhdpfhhrvggvuggvshhkthhoph drohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm pehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 30 Jan 2023 07:56:50 -0500 (EST) Date: Mon, 30 Jan 2023 13:56:48 +0100 From: Maxime Ripard To: Jagan Teki Cc: Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , Marek Vasut , Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Linus Walleij , Maarten Lankhorst Subject: Re: [RESEND PATCH v11 02/18] drm: bridge: panel: Add devm_drm_of_dsi_get_bridge helper Message-ID: <20230130125648.mlrtubymeooejvhg@houat> References: <20230123151212.269082-1-jagan@amarulasolutions.com> <20230123151212.269082-3-jagan@amarulasolutions.com> <20230126121227.qcnftqvgiz44egpg@houat> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230130_045700_565250_E527FB3A X-CRM114-Status: GOOD ( 24.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 27, 2023 at 11:09:26PM +0530, Jagan Teki wrote: > Hi, > > On Thu, Jan 26, 2023 at 8:48 PM Jagan Teki wrote: > > > > On Thu, Jan 26, 2023 at 5:42 PM Maxime Ripard wrote: > > > > > > Hi, > > > > > > On Mon, Jan 23, 2023 at 08:41:56PM +0530, Jagan Teki wrote: > > > > Add devm OF helper to return the next DSI bridge in the chain. > > > > > > > > Unlike general bridge return helper devm_drm_of_get_bridge, this > > > > helper uses the dsi specific panel_or_bridge helper to find the > > > > next DSI device in the pipeline. > > > > > > > > Helper lookup a given child DSI node or a DT node's port and > > > > endpoint number, find the connected node and return either > > > > the associated struct drm_panel or drm_bridge device. > > > > > > I'm not sure that using a device managed helper is the right choice > > > here. The bridge will stay longer than the backing device so it will > > > create a use-after-free. You should probably use a DRM-managed action > > > here instead. > > > > Thanks for the comments. If I understand correctly we can use > > drmm_panel_bridge_add instead devm_drm_panel_bridge_add once we found > > the panel or bridge - am I correct? > > Look like it is not possible to use DRM-managed action helper here as > devm_drm_of_dsi_get_bridge is calling from the DSI host attach hook in > which we cannot find drm_device pointer (as drm_device pointer is > mandatory for using DRM-managed action). > https://github.com/openedev/kernel/blob/imx8mm-dsi-v12/drivers/gpu/drm/bridge/samsung-dsim.c#L1545 > > Please check and correct me if I mentioned any incorrect details. You shouldn't call that function from attach anyway: https://dri.freedesktop.org/docs/drm/gpu/drm-kms-helpers.html#special-care-with-mipi-dsi-bridges Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel