From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 795C0C54EAA for ; Tue, 31 Jan 2023 00:22:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5szKQktQWB+wePmgf4pNjp0mafHp2rkYM2ByE4l2i1Q=; b=i6gqtSIrahCbcA 4aL7csmJSvW5haJxlSlXZpoA/twFhSujPO4s2ILmhikh03wJGQk6MISUulT/9BiMPot3iC7g7V+ay uuSMl78PennkKVovNidBXXMtVoWRC4XDTXIAMFKKRJsTkUt00bKtQkDkYW9I1cI8xUOKAck75jd6X 1R7dYTu97qncWk+2gSCSE5EKWZl/2f7VA2iOhqs3QZSfL3f/7dQyDlQH0SevWx7wxDbASR+o4Y4Fe 2IwHy8Epc5fJDDFhnqXp8QcmWqX/q8h9/u/zSUM/VQ0+CpqIBMcyhbuRpK1o6sgw0agqa7KingT1V FbhTfMkAQSFnBaLZXFDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMeOc-005rzh-8G; Tue, 31 Jan 2023 00:21:10 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMeOD-005rna-It for linux-arm-kernel@lists.infradead.org; Tue, 31 Jan 2023 00:20:52 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B7826B818C8; Tue, 31 Jan 2023 00:20:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CD92C433D2; Tue, 31 Jan 2023 00:20:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675124442; bh=f0WFrBoNisBu4HeLhCYksUS7yduuDKSx/ZePuzgqPVQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uawK88ZnmfjpDQge6p3uXopoAXViRqFHNl+3GssRAXWdwJQEvCy5ioPRRfs12CVV1 zLquWpzub6UliGLnQ9uGTOk+cQ6BKdYf/rXtY7faYroYXD5hWs9uFTglMW3WxMmHnB kMY4sdL9lv6rBqdE62RUZuRMAhYnyEDUKi61rUxn4W04dz+vzS5FxnOvMG8AN8R8og mlyYwYk4IS7QZJS+2i2SDnLyJDw6NgVENnW+bFmTIS+aKUkUmbfyYenLnNrYxVWMWx JPhnzHNQxLAmTaaCCbk1Yh+NSf8PZNMb4bKJ9uUSjpqMb73WNkrdzoadviRbuzqJgB hNpHUhwACUhLw== Date: Mon, 30 Jan 2023 16:20:41 -0800 From: Jakub Kicinski To: Christophe JAILLET Cc: Jonas Suhr Christensen , netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, michal.simek@xilinx.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, esben@geanix.com Subject: Re: [PATCH 1/2] net: ll_temac: fix DMA resources leak Message-ID: <20230130162041.556b34b3@kernel.org> In-Reply-To: <810730f9-5097-4fb1-bea0-13e3e7084f9c@wanadoo.fr> References: <20230126101607.88407-1-jsc@umbraculum.org> <810730f9-5097-4fb1-bea0-13e3e7084f9c@wanadoo.fr> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230130_162045_842840_B7016EDC X-CRM114-Status: GOOD ( 10.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 30 Jan 2023 22:56:04 +0100 Christophe JAILLET wrote: > > - dma_unmap_single(ndev->dev.parent, lp->rx_bd_v[i].phys, > > + > > + bd = &lp->rx_bd_v[1]; > > Hi, > just a naive question from s.o. who knows nothing of this code: > > Is really [1] ([one]) expected here? > [i] would look more "standard" in a 'for' loop. Wow, good eye. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel