From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18B02C636CD for ; Mon, 30 Jan 2023 22:30:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E8zgkKnwPwkwKQ3Qz8sgGxTSuaaOUxWn/2mMsQjytro=; b=K4eTMJWvLGpS7A nZlgLuLOy49/sSeMtP7hCFcP+eSYbzrqFmpNkdgiuidqNzCJtyVAzsPdtzihq4n/7qiocnXV8a7Dr Oo8rAFAV3V6IvAV5PoltzkpfiZZYpAAicKmjIjZIESWCpmRnLgKiAPnILppfIkiZ5yaLW40DO+BZm 3RkEACa7RL8PWLNiy5jZmwjAdFVnAtjGJcb5Q4Pk49h4+Jfr2Kahou/KTRx04uIZYM0Bhhoodym9J ZV2Q/m83rxUmgt8YhXO0WDLJePQ5bfxthq1CQsg7AhOuLV8nfUInlVUlyYuxwaWsVfIJmPmQxNLVL dpYRdO/3qRwWNjBwyhEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMceg-005eHb-1X; Mon, 30 Jan 2023 22:29:38 +0000 Received: from mail-oi1-f177.google.com ([209.85.167.177]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMcec-005eGk-Gh for linux-arm-kernel@lists.infradead.org; Mon, 30 Jan 2023 22:29:36 +0000 Received: by mail-oi1-f177.google.com with SMTP id dt8so8282427oib.0 for ; Mon, 30 Jan 2023 14:29:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8LRTaCsYupaKAIxJ4u3XR2A11yw5IpehNtdsJbn/NTo=; b=DWZDTOm07SVJXcLEZ6+txWGn21+T+i7BbB8QLG5A+NqKeAH8fM3nNsAJhYBtCFic5o yxGWaADCWW2HpjDhL4oA1A5MxSFlgA9qDLgYnVGGh65dkpFVETAYJmko3vBXYgWVgTiw BfNdmFBlMvhLQDcto5H4nSl2BvL+O+gd0qHixw3dzn9fqAb64f/3FV7ef1ecTn0zTKb1 bSmI8WdYEhuMUek3II4MfdQlHtklMIyGuM6kq+yshNXiySenSAXCnUlFcYO0BY4wukD4 /WG7QNAOxrHhcVra/adKYtDn2gifM12NiwFpaRexsmZsfTOpux/bX9rzyLwjY60cxJUG WNDA== X-Gm-Message-State: AFqh2kpUmPuJaHaTXX3ng+vpedEfM0sms59pWxf87gbaYU2qd3TW+7ZL NzTpXWOfqAimlj7Oqrg7kZOoZeQ4Dg== X-Google-Smtp-Source: AMrXdXtsZN18JtBDPLJvQi4F9AvmMcMq/hDOjEtb7fzc6IuLtWh0PJy6kGEcLqiUe29fbQATyakg+w== X-Received: by 2002:a05:6808:4247:b0:36e:b7bf:e3d7 with SMTP id dp7-20020a056808424700b0036eb7bfe3d7mr18464727oib.52.1675117773208; Mon, 30 Jan 2023 14:29:33 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id g131-20020acab689000000b0036e9160f57csm5170753oif.20.2023.01.30.14.29.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 14:29:32 -0800 (PST) Received: (nullmailer pid 3642109 invoked by uid 1000); Mon, 30 Jan 2023 22:29:32 -0000 Date: Mon, 30 Jan 2023 16:29:32 -0600 From: Rob Herring To: Richard Zhu Cc: krzysztof.kozlowski+dt@linaro.org, l.stach@pengutronix.de, shawnguo@kernel.org, lorenzo.pieralisi@arm.com, peng.fan@nxp.com, marex@denx.de, marcel.ziswiler@toradex.com, tharvey@gateworks.com, frank.li@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com Subject: Re: [PATCH v7 2/5] dt-bindings: imx6q-pcie: Add schema for i.MX8M PCIe Endpoint modes Message-ID: <20230130222932.GA3634639-robh@kernel.org> References: <1675049539-14976-1-git-send-email-hongxing.zhu@nxp.com> <1675049539-14976-3-git-send-email-hongxing.zhu@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1675049539-14976-3-git-send-email-hongxing.zhu@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230130_142934_572416_E2CA3A75 X-CRM114-Status: GOOD ( 23.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 30, 2023 at 11:32:16AM +0800, Richard Zhu wrote: > Add support for i.MX8M PCIe Endpoint modes, and update the MAINTAINER > accordingly. > > Signed-off-by: Richard Zhu > --- > .../bindings/pci/fsl,imx6q-pcie-ep.yaml | 317 ++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 318 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml > new file mode 100644 > index 000000000000..7c594ae53067 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml > @@ -0,0 +1,317 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pci/fsl,imx6q-pcie-ep.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale i.MX6 PCIe Endpoint controller > + > +maintainers: > + - Lucas Stach > + - Richard Zhu > + > +description: |+ > + This PCIe controller is based on the Synopsys DesignWare PCIe IP and > + thus inherits all the common properties defined in snps,dw-pcie-ep.yaml. > + The controller instances are dual mode where in they can work either in > + Root Port mode or Endpoint mode but one at a time. > + > +properties: > + compatible: > + enum: > + - fsl,imx8mm-pcie-ep > + - fsl,imx8mq-pcie-ep > + - fsl,imx8mp-pcie-ep > + > + reg: > + minItems: 2 > + > + reg-names: > + items: > + - const: dbi > + - const: addr_space > + > + interrupts: > + items: > + - description: builtin eDMA interrupter. > + > + interrupt-names: > + items: > + - const: dma > + > + clocks: > + minItems: 3 > + items: > + - description: PCIe bridge clock. > + - description: PCIe bus clock. > + - description: PCIe PHY clock. > + - description: Additional required clock entry for imx6sx-pcie-ep, > + imx8mq-pcie-ep. > + > + clock-names: > + minItems: 3 > + items: > + - const: pcie > + - const: pcie_bus > + - enum: [ pcie_phy, pcie_aux ] > + - enum: [ pcie_inbound_axi, pcie_aux ] Are the clocks in endpoint mode suddenly different? I can't tell, but will assume so since they added here. > + > + num-lanes: > + const: 1 You shouldn't need this if it can only be 1 value. > + > + fsl,imx7d-pcie-phy: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: A phandle to an fsl,imx7d-pcie-phy node. Additional > + required properties for imx7d-pcie-ep and imx8mq-pcie-ep. > + > + power-domains: > + minItems: 1 > + items: > + - description: The phandle pointing to the DISPLAY domain for > + imx6sx-pcie-ep, to PCIE_PHY power domain for imx7d-pcie-ep and > + imx8mq-pcie-ep. > + - description: The phandle pointing to the PCIE_PHY power domains > + for imx6sx-pcie-ep. > + > + power-domain-names: > + minItems: 1 > + items: > + - const: pcie > + - const: pcie_phy > + > + resets: > + minItems: 2 > + maxItems: 3 > + description: Phandles to PCIe-related reset lines exposed by SRC > + IP block. Additional required by imx7d-pcie-ep and imx8mq-pcie-ep. > + > + reset-names: > + minItems: 2 > + maxItems: 3 Same question for resets. > + > + fsl,tx-deemph-gen1: > + description: Gen1 De-emphasis value (optional required). > + $ref: /schemas/types.yaml#/definitions/uint32 > + default: 0 > + > + fsl,tx-deemph-gen2-3p5db: > + description: Gen2 (3.5db) De-emphasis value (optional required). > + $ref: /schemas/types.yaml#/definitions/uint32 > + default: 0 > + > + fsl,tx-deemph-gen2-6db: > + description: Gen2 (6db) De-emphasis value (optional required). > + $ref: /schemas/types.yaml#/definitions/uint32 > + default: 20 > + > + fsl,tx-swing-full: > + description: Gen2 TX SWING FULL value (optional required). > + $ref: /schemas/types.yaml#/definitions/uint32 > + default: 127 > + > + fsl,tx-swing-low: > + description: TX launch amplitude swing_low value (optional required). > + $ref: /schemas/types.yaml#/definitions/uint32 > + default: 127 Now we'd duplicated defining the type for all these properties... This needs to be restructured into a schema of all the common properties and then the host and endpoint schema can reference it. IOW, like how other schemas have been done. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel