From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0EF95C38142 for ; Tue, 31 Jan 2023 20:54:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Message-Id:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6sQYwp4mFd4AtqAcJEj8o8HyUcwUqniJbDmY6i5+ddA=; b=aplHNieTBsSQeE wgSITDnkitjqnVfbnIdwGXPO6bB0484162TuYlH92sC/CVPHg+Uq9QNzmQgzgUoHBAEszIF/tAjJf eJtuAyYFMMYEoV4jp1MV45EQO5VOKO/csmVYgPGygnJTNrNo+Z2zFE27KkKl6+vt9J632QauD92ko WnguKXbJ3WM4XUJq2qnKwmh3tAk7rvxd4oxAXwzafk2vU9Jjj1Prsu2eM4fY/rMDyYZ6j9Y30ptT3 b9B8fi+W5Z3wxf+w3NbfD/FtBbU8/dJxzaegshIqXQofIbfEK3cmIJ//uZFl8q1shCZXLs8g4/T6w JN1/aTu0f8gXlZjcXS3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMxdi-009JzV-Jr; Tue, 31 Jan 2023 20:54:02 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMxde-009Jy5-Ue for linux-arm-kernel@lists.infradead.org; Tue, 31 Jan 2023 20:54:00 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 030BF61708; Tue, 31 Jan 2023 20:53:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB5F4C433EF; Tue, 31 Jan 2023 20:53:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1675198437; bh=jHy4qpmBfs5JB+49uMUbT6ZlxxySVk0qKxcOzh21LsU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hHngKerx0MW9zufZtMuQZEzHh3CP4ijBQc0AQ3au4woHogCVYIXIgmCDTB3X1PFRX FoL9w9mszj2lnuZGJN/zx9flw95uDHtCKgSsx9iQE3VP9KxUjOpK8pO+iR/Iaaw1/A H0saKzFa8Zb51o2dQFJzCGUfalgCpK/aouzY88j4= Date: Tue, 31 Jan 2023 12:53:55 -0800 From: Andrew Morton To: Suren Baghdasaryan Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, leewalsh@google.com, posk@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Sebastian Reichel Subject: Re: [PATCH v4 4/7] mm: replace vma->vm_flags direct modifications with modifier calls Message-Id: <20230131125355.f07f42af56b23bfa28b2a58c@linux-foundation.org> In-Reply-To: References: <20230126193752.297968-1-surenb@google.com> <20230126193752.297968-5-surenb@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230131_125359_058311_5A5439FF X-CRM114-Status: GOOD ( 13.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 31 Jan 2023 10:54:22 -0800 Suren Baghdasaryan wrote: > > > - vma->vm_flags &= ~VM_MAYWRITE; > > > + vm_flags_clear(vma, VM_MAYSHARE); > > > } > > > > I think it should be: > > s/VM_MAYSHARE/VM_MAYWRITE/ > I added the fixup. Much better than resending a seven patch series for a single line change. Unless you have substantial other changes pending. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel