From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DC1CC636CD for ; Wed, 1 Feb 2023 17:14:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=awrpfcXPVaoMST6sE2hUxdn+1ufWidZhYuAGaoeJARg=; b=t30fpqRvM1w7FV ujolbRzA5aXj42uwlR4o+jvFxKqVOajMaNYHps+nlzrZ9ccu95p+AIyAMIM3eNzO2PATv/FuSQZ9Q 0SAoz+QupgyKmdDX6lR+9L9K+QQbi7CQmGDT+t0dcdEZtq/DwtRLVNECtiuufIYih3t1LZnJ/T40g N5HPdidd/yBVvKi3iG5EjsYp9yx30sGUMJyQGGQGjhHIT7mO6r8Zor70sn3O4gQcmzZ04G0krVaYq 3X9xmwkaXKs1dfLvbG8+AgIctO4GFaybdBzEEq0bXj7WG1xACVJrmJOMTHIurTMWxJXcoPmupxTCN 8ACufEpDn9H8rUYVjmvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNGfc-00Cz9r-Sh; Wed, 01 Feb 2023 17:13:17 +0000 Received: from mail-oi1-f174.google.com ([209.85.167.174]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNGfZ-00Cz5j-6D for linux-arm-kernel@lists.infradead.org; Wed, 01 Feb 2023 17:13:14 +0000 Received: by mail-oi1-f174.google.com with SMTP id r205so16278661oib.9 for ; Wed, 01 Feb 2023 09:13:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pTT6vZ5iHjnalpPNssmSbl29PhZdc5VcdM+DVzHurmw=; b=jHq5MqJMjnv7zbsKlaf6zLk8o+bIysNLtBG73jU+Qy4VyKideUYUCRQWu3CgMgU0qE M31l6cbUBYOUpcmQu/+ZCIs4EM2gzrp5PfqBqDg1WGlf1IkJKOlXssGpYULnISgdg7pI MP381wIxKA4P5wEghCnnZ5yCCt1iYfxXFNNRaQtwZvYV3h2l6emvn9nu++u7boSp2KWs BY8m1rDWndF9F+GIy6G5DAYUxxAso8pLSUW9PorTXGEZyFGrvnitKhk6TJsj117DHdx2 Ok+rjCsDdLG6ss3AqgsX2RvYs73s0v+zw6CSpmWwh0gHbY4fknUCETfJzO+TKEYJGIum CVRQ== X-Gm-Message-State: AO0yUKXlzdGViesC6CvLs8xyq++16F926OiitpAI9p06gSXRBWCh/7Ix xzDdjD/fWnXVByDdAOZMtg== X-Google-Smtp-Source: AK7set/Q3V23dp7mKwXccI7KFQBUKCUaOUrzdXAxKdKGV/QYcZJThdLz6qKE6su4zvbCHkKcRjF+Qw== X-Received: by 2002:a05:6808:1913:b0:378:5f8c:45b4 with SMTP id bf19-20020a056808191300b003785f8c45b4mr1874203oib.18.1675271583392; Wed, 01 Feb 2023 09:13:03 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id r133-20020acaa88b000000b00367080ab4casm525848oie.35.2023.02.01.09.13.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 09:13:03 -0800 (PST) Received: (nullmailer pid 3681788 invoked by uid 1000); Wed, 01 Feb 2023 17:13:01 -0000 Date: Wed, 1 Feb 2023 11:13:01 -0600 From: Rob Herring To: Nipun Gupta Cc: krzysztof.kozlowski+dt@linaro.org, gregkh@linuxfoundation.org, rafael@kernel.org, eric.auger@redhat.com, alex.williamson@redhat.com, cohuck@redhat.com, song.bao.hua@hisilicon.com, mchehab+huawei@kernel.org, maz@kernel.org, f.fainelli@gmail.com, jeffrey.l.hugo@gmail.com, saravanak@google.com, Michael.Srba@seznam.cz, mani@kernel.org, yishaih@nvidia.com, jgg@ziepe.ca, jgg@nvidia.com, robin.murphy@arm.com, will@kernel.org, joro@8bytes.org, masahiroy@kernel.org, ndesaulniers@google.com, rdunlap@infradead.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, okaya@kernel.org, harpreet.anand@amd.com, nikhil.agarwal@amd.com, michal.simek@amd.com, git@amd.com Subject: Re: [PATCH v7 3/7] dt-bindings: bus: add CDX bus controller for versal net Message-ID: <20230201171301.GA3606391-robh@kernel.org> References: <20230131084049.23698-1-nipun.gupta@amd.com> <20230131084049.23698-4-nipun.gupta@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230131084049.23698-4-nipun.gupta@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230201_091313_249044_DAF6176F X-CRM114-Status: GOOD ( 26.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 31, 2023 at 02:10:45PM +0530, Nipun Gupta wrote: > Add CDX bus controller device tree bindings for versal-net > devices. > > Signed-off-by: Nipun Gupta > --- > .../bindings/bus/xlnx,versal-net-cdx.yaml | 68 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 69 insertions(+) > create mode 100644 Documentation/devicetree/bindings/bus/xlnx,versal-net-cdx.yaml > > diff --git a/Documentation/devicetree/bindings/bus/xlnx,versal-net-cdx.yaml b/Documentation/devicetree/bindings/bus/xlnx,versal-net-cdx.yaml > new file mode 100644 > index 000000000000..8452185b9d70 > --- /dev/null > +++ b/Documentation/devicetree/bindings/bus/xlnx,versal-net-cdx.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/bus/xlnx,versal-net-cdx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: AMD CDX bus controller > + > +description: | > + CDX bus controller for AMD devices is implemented to dynamically > + detect CDX bus and devices on these bus using the firmware. > + The CDX bus manages multiple FPGA based hardware devices, which > + can support network, crypto or any other specialized type of > + devices. These FPGA based devices can be added/modified dynamically > + on run-time. > + > + All devices on the CDX bus will have a unique streamid (for IOMMU) > + and a unique device ID (for MSI) corresponding to a requestor ID > + (one to one associated with the device). The streamid and deviceid > + are used to configure SMMU and GIC-ITS respectively. > + > + iommu-map property is used to define the set of stream ids > + corresponding to each device and the associated IOMMU. > + > + The MSI writes are accompanied by sideband data (Device ID). > + The msi-map property is used to associate the devices with the > + device ID as well as the associated ITS controller. > + > + rproc property (xlnx,rproc) is used to identify the remote processor > + with which APU (Application Processor Unit) interacts to find out > + the bus and device configuration. > + > +maintainers: > + - Nipun Gupta > + - Nikhil Agarwal > + > +properties: > + compatible: > + const: xlnx,versal-net-cdx > + > + iommu-map: true > + > + msi-map: true > + > + xlnx,rproc: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + phandle to the remoteproc_r5 rproc node using which APU interacts > + with remote processor. > + > +required: > + - compatible > + - iommu-map > + - msi-map > + - xlnx,rproc > + > +additionalProperties: false > + > +examples: > + - | > + cdx { > + compatible = "xlnx,versal-net-cdx"; > + /* define map for RIDs 250-259 */ > + iommu-map = <250 &smmu 250 10>; > + /* define msi map for RIDs 250-259 */ > + msi-map = <250 &its 250 10>; > + xlnx,rproc = <&remoteproc_r5>; There's no addresses associated with this bus? Like the address range the devices are at. You should have 'ranges' whether Linux needs it yet or not. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel