From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E24AAC05027 for ; Wed, 1 Feb 2023 22:00:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=bfCAqSBb6uD2t/nkyK7QLchlNbpn/cIPfXUYwT8cIOQ=; b=DThrmy79GPGpfH SybYisyawPm8HnZG3ylPMMpyObKy8YB1flNVzKaT+2FLO01khQzJAGjYRTzLLV474OIK/0uvYEqnh Ny37Vmx2H56CB3PyllBV8QOu31mlY4vwQD6lD382Wm/PD4lAg5UAhpyk41uPPLJ2MLUWoUl+IttlL vQ5YtLRGKJstSowZOSqGgHENSXGBEUVytU1FIRTPL+lOIqtOrClaWhYnwXlnPiDt/ce6fuNfxz2+c 6T7KgbxUWuhp38R9h21t9t8bTN9iFlrfAbXopDQvA+USFsy5wy6L0rkoak026H0yKGaIZh25ouetm 284zMcc0u1xeBMKgxIMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNL9B-00DinO-HT; Wed, 01 Feb 2023 22:00:05 +0000 Received: from mail-ot1-f44.google.com ([209.85.210.44]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNL99-00DimF-C4 for linux-arm-kernel@lists.infradead.org; Wed, 01 Feb 2023 22:00:04 +0000 Received: by mail-ot1-f44.google.com with SMTP id v24-20020a05683011d800b0068bdd29b160so2420253otq.13 for ; Wed, 01 Feb 2023 14:00:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KnsdEPYwX/ZNMl/l3teqeX2/D7jKm45H92eGfCLGbh4=; b=FKTnoWwSG3wn1s6D9He5uCpfMGd9NCtVYQ0+g3ysRZqDFcylfF5hotU1fHVMJng0BG ZLkQJJpu4uT8k5/JYwk6LJY0OU+3CbWVNMsEC2kvuFinnH2PpxSYSlJhIBakEHS8w6kS EPyFEEHCw/y18BOaAAczkFZ83ku0aR/E5ZOW1DNmxz7FvAvm7WBKeCc7Gl3nvv1RcvA7 WJukFSx1r9STT4SpINILQwB6pAVFaVUgReYKwnuOSqk+TVUZBinc8AXQGrgXTv9uUSdu 0FQQQepcXE7X2I03HreYKbh33FrwwSsZXDMvQtnu6dvh9oYmGJA6aR3s/EkwkNrv4Rmq tBXg== X-Gm-Message-State: AO0yUKXbHJB7yDBhT087b4YAZ6XsKSEfDgxpMSOVzRuTnHk4FjFPjcAM pxZNb+1ADFNogWwseaKkBw== X-Google-Smtp-Source: AK7set8fYP5ut+0fIMu4n6g8KX0Oo7nzolLnmWQejXZ1w2vjX6IVqmiiQcmf+ccbkdd0V+RX7ktD4A== X-Received: by 2002:a05:6830:381a:b0:68b:ba4d:1c94 with SMTP id bh26-20020a056830381a00b0068bba4d1c94mr2361983otb.4.1675288800384; Wed, 01 Feb 2023 14:00:00 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id m6-20020a9d4c86000000b0068d3f341dd9sm1333849otf.62.2023.02.01.13.59.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 13:59:59 -0800 (PST) Received: (nullmailer pid 246856 invoked by uid 1000); Wed, 01 Feb 2023 21:59:59 -0000 From: Rob Herring To: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] bus: imx-weim: Remove open coded "ranges" parsing Date: Wed, 1 Feb 2023 15:58:54 -0600 Message-Id: <20230201215854.245717-1-robh@kernel.org> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230201_140003_432777_427F7F1B X-CRM114-Status: GOOD ( 15.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org "ranges" is a standard property and we have common helper functions for parsing it, so let's use them. Signed-off-by: Rob Herring --- Compile tested only! --- drivers/bus/imx-weim.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c index 828c66bbaa67..bb9d1f5ed73b 100644 --- a/drivers/bus/imx-weim.c +++ b/drivers/bus/imx-weim.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include @@ -86,8 +87,8 @@ MODULE_DEVICE_TABLE(of, weim_id_table); static int imx_weim_gpr_setup(struct platform_device *pdev) { struct device_node *np = pdev->dev.of_node; - struct property *prop; - const __be32 *p; + struct of_range_parser parser; + struct of_range range; struct regmap *gpr; u32 gprvals[4] = { 05, /* CS0(128M) CS1(0M) CS2(0M) CS3(0M) */ @@ -106,13 +107,13 @@ static int imx_weim_gpr_setup(struct platform_device *pdev) return 0; } - of_property_for_each_u32(np, "ranges", prop, p, val) { - if (i % 4 == 0) { - cs = val; - } else if (i % 4 == 3 && val) { - val = (val / SZ_32M) | 1; - gprval |= val << cs * 3; - } + if (of_range_parser_init(&parser, np)) + goto err; + + for_each_of_range(&parser, &range) { + cs = range.bus_addr >> 32; + val = (range.size / SZ_32M) | 1; + gprval |= val << cs * 3; i++; } -- 2.39.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel