From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 081DFC05027 for ; Thu, 2 Feb 2023 21:57:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h3bBbiuEr4SkEOQH5oCmncettPFtACbHzJMUgxD0E/8=; b=Xo2c0qg9ZEiKfc E/Q7fcfDDIJxr31UO/ebVBf0R4dc4v3zTUeF5i2SBZUnVpLQ6BJP/T49KAxs/h/WwVJ925nO1l63f Z8Q7YP1ue3JQbiW3S8ycGR5BwuopPmsA9oChDk4tXVPdlDamoXXH2Ek57kQlhVZPRpkudMk72ux11 JEfOpzst5P8TwNr7IjdcfiHpAAj2VV7pYVpUfTGd2+LIC8cCK2aHm+e6Cf6dkqQ49OXoc3WrgyJOP Vre3FMnImhCkRMGLMT22llE85kMvziPe2TJiFG9T46D0JISXAkmCZquLmhTzHAdGV2rJ13mn2wqfa +2kOQsI/B3f6Yq4KAMAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNhZO-00HHat-Fp; Thu, 02 Feb 2023 21:56:38 +0000 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNhZL-00HHZs-Hs for linux-arm-kernel@lists.infradead.org; Thu, 02 Feb 2023 21:56:37 +0000 Received: by mail-pg1-x536.google.com with SMTP id 7so2339038pgh.7 for ; Thu, 02 Feb 2023 13:56:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zMwlRpkq9CUjLciSPcd5+pqtbJtQxFyxa7YlVYfafe0=; b=dhjxYIRXRWeVQ6xcykloqXco/9Oe5ZSV9joCqNU/biA3/B57ff1tuda8tj7roNFEGc oCw0UPiZ72XP9Y37t/5ewo//KGLGKS3ZxHzpmtwfGUHn9+Rah8KZIgsRZn5td3hcEp3N 3kPNl3e+vlPG4TNtE6WSpmMkqMFNwn/du9nuOwed72AxpJZll38PAjidZjj1zgHoNKSV R+zyFwcz16lzmlEfale7T1esTS9WodnPK2QHU2hEaJagjjUhHIHNHbWK92GlEodnCMpN 0GDxb3C4daAN6meejhLN0DLBcyizuIoZ4gc+A0bc8gxOlz/RBT3S/qULcvXgiSmlwGDN ZchQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zMwlRpkq9CUjLciSPcd5+pqtbJtQxFyxa7YlVYfafe0=; b=41TfP/cueOt3pbXrWNPYpi3VIR3mlpFKrK54C0e2ZXyom02VbYbwkIIMep1cONMYT5 vtBNJY16LaAMTdqOWaAUOQpEwoo6zjrXi0ZksyMUz+yUMpDH0nq75Q9khrtiNRx4ozLY T48F+dmSDXWKmCiEcMdFO+DbBIuwsgpl3MsCMTh21OYG2gIdb8P+9xdbcqZzpGL+OMuM 3K3asN23uuTnZc/4JCnebaKYEwi9U42SBaAfpmJbjj6MmP1lF+GCqq3Rj1aD4VVRucRL VK1u/P3MXNMQKLYOjPmFp/O6XuLWWOXA8IZJuFU5oWI53LuTjMGcT2Q8sxPL6xOYk9Ud iVBQ== X-Gm-Message-State: AO0yUKXFT9+4tBNs2wFSJCZOTMMKPxcprfsh2PT4XwJLIjVyDT/4el+1 IU78Jnl5TBniXLguPP19q3yLPQ== X-Google-Smtp-Source: AK7set+fwyRorG4sv5PBqZsi46Y0vpw5s6YN28pLqvaogJ6j0urfyqhb7hJThiO8+FprZTADE3wE9A== X-Received: by 2002:a05:6a00:b4e:b0:575:b783:b6b3 with SMTP id p14-20020a056a000b4e00b00575b783b6b3mr8898810pfo.28.1675374992168; Thu, 02 Feb 2023 13:56:32 -0800 (PST) Received: from p14s ([2604:3d09:148c:c800:bb50:10cc:f6a5:2176]) by smtp.gmail.com with ESMTPSA id p67-20020a622946000000b0059390c02c22sm179324pfp.30.2023.02.02.13.56.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Feb 2023 13:56:31 -0800 (PST) Date: Thu, 2 Feb 2023 14:56:29 -0700 From: Mathieu Poirier To: "Peng Fan (OSS)" Cc: andersson@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, arnaud.pouliquen@foss.st.com, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH V2 5/6] remoteproc: imx_rproc: set Cortex-M stack/pc to TCML Message-ID: <20230202215629.GC1147631@p14s> References: <20230127092246.1470865-1-peng.fan@oss.nxp.com> <20230127092246.1470865-6-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230127092246.1470865-6-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230202_135635_623088_279C223E X-CRM114-Status: GOOD ( 30.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 27, 2023 at 05:22:45PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > The i.MX8M Cortex-M core not has ROM. It has a requirement is > the stack, pc value should be set in address 0 and 4 from the view of > itself. From Cortex-A core view, the region is at TCML start address. > > The stack and pc value are the first two words stored in section > ".interrupts" of the firmware, and the section is the first section in > the firmware. > > When the firmware is built to run in TCML, there is no issue, because > when copying elf segments, the first two words are copied to TCML also. > > However when the firmware is built ro run in DDR, the first two words > are not copied to TCML start address. > > This patch is to find the ".interrupts" section, read out the first > two words and write to TCML start address at offset 0 and 4. > > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 37 +++++++++++++++++++++++++++++++++- > 1 file changed, 36 insertions(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 295e0e0e869a..f5ee0c9bb09d 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -7,6 +7,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -23,6 +24,7 @@ > #include > > #include "imx_rproc.h" > +#include "remoteproc_elf_helpers.h" > #include "remoteproc_internal.h" > > #define IMX7D_SRC_SCR 0x0C > @@ -634,6 +636,39 @@ static struct resource_table *imx_rproc_get_loaded_rsc_table(struct rproc *rproc > return (struct resource_table __force *)priv->rsc_table; > } > > +static u64 imx_rproc_get_boot_addr(struct rproc *rproc, const struct firmware *fw) > +{ > + struct imx_rproc *priv = rproc->priv; > + const u8 *elf_data = (void *)fw->data; > + u8 class = fw_elf_get_class(fw); > + u64 bootaddr = rproc_elf_get_boot_addr(rproc, fw); > + const void *shdr; > + void __iomem *va; > + u64 sh_addr, offset; > + > + if (priv->dcfg->devtype == IMX_RPROC_IMX8M) { > + /* > + * i.MX8M Cortex-M requires [stack, pc] be put in address > + * [0, 4], so the da address is 0, size is 8 words. > + */ > + va = (__force void __iomem *)rproc_da_to_va(rproc, 0, 8, NULL); > + shdr = rproc_elf_find_shdr(rproc, fw, ".interrupts"); > + if (!shdr || !va) > + return bootaddr; > + sh_addr = elf_shdr_get_sh_addr(class, shdr); This isn't used - why is it still there? > + offset = elf_shdr_get_sh_offset(class, shdr); > + > + /* > + * Write stack, pc to TCML start address. The TCML region > + * is marked with ATT_IOMEM, so use writel. > + */ > + writel(*(u32 *)(elf_data + offset), va); > + writel(*(u32 *)(elf_data + offset + 4), va + 4); Here you are writing 2 words at address 0x0 and 2 words at address 0x4. Why are you saying the size is 8 words in the comment above? > + } > + > + return bootaddr; > +} > + > static const struct rproc_ops imx_rproc_ops = { > .prepare = imx_rproc_prepare, > .attach = imx_rproc_attach, > @@ -647,7 +682,7 @@ static const struct rproc_ops imx_rproc_ops = { > .find_loaded_rsc_table = rproc_elf_find_loaded_rsc_table, > .get_loaded_rsc_table = imx_rproc_get_loaded_rsc_table, > .sanity_check = rproc_elf_sanity_check, > - .get_boot_addr = rproc_elf_get_boot_addr, > + .get_boot_addr = imx_rproc_get_boot_addr, > }; > > static int imx_rproc_addr_init(struct imx_rproc *priv, > -- > 2.37.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel