From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EA21C61DA4 for ; Thu, 2 Feb 2023 22:07:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SH3MCAqoPpwDYPNU1EyAYAWL4B5yXedbFJwzZy1lB1c=; b=n/1Wa34oN3Nyag ropn0W/a80S3SriNIAgXfW7S3QlZTzw9VanmXsMnUgWuw01gaIaXDpy5rCpWqVdYachZHuIQGCDRU mME8oNufqNqDDBaGsWHFGpYOm7mr9zdBNN3TQAkGBCEtbbY/Q50FdgHJJUwc+LHhoP0btLTxzxrGP VzPMMqHTTtIrS0n4LGfEnhiJruGT2uWCHKyw5EjWzfy44UJodMJ3aKG0w5tnohgdZhRjjcBTafshp ZuTOKRA3DzL+ShXXx4JwRLcnsJaTiaSvgsGNh7oMyqU4DTk1VwS9C7GC0WvRtEXd3YmnYH3Qh7twW dhG0BEmDGGNzQPH/ruzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNhia-00HJ8d-Cs; Thu, 02 Feb 2023 22:06:08 +0000 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNhiX-00HJ7Z-5Q for linux-arm-kernel@lists.infradead.org; Thu, 02 Feb 2023 22:06:06 +0000 Received: by mail-pl1-x62d.google.com with SMTP id 5so3356498plo.3 for ; Thu, 02 Feb 2023 14:06:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=r1ye01WI+eBlxGiG8i4OkUQCbltzh8nKDNLaIpK8ceY=; b=ik1o9/JtrPKMKusKTI46qe0qj4LftbwYR8nDPq8BCbTLl9Ze/qHTMyyYgNvcmtJ7Rk zJ5IAiKEkRoqK89qcvZxGzgIl0K/d9hmeck54vr+zFdA8iKNVPBi/dYfODJWYn2nJBso dY7B03cqi3bFxGH9dpHXE3M0Axj0PrN4oEbxN+6XGnd4ScQDA46bQtkitEhE1vsdGxN0 5xklxDJPnlGiCFT+07iQMQnpbpbe4rumxYfNH8QQjYmzdIZYIylF7JwimRV4U34UOZnf 4OuCYH/0DxCoz4daQzt8SwJmVLD/33YO0GN9TPlqYxU9CCXXetNH49/OFduzLummQzmQ 0nag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=r1ye01WI+eBlxGiG8i4OkUQCbltzh8nKDNLaIpK8ceY=; b=jq/0H7QI3W4jvQjQU2ZwtqWYqZ1YpDb/WVF0jJ1zB1WnwC6YeLJTvlzYhKzJwhjqqr iT6ogZ9rq9wWk090Ms3WSXNT+v9g9lhD4pWsNRrDuthht4NkCloXUPw5ycP5mkHUvzGM vafAbAVfHytXcWDBEPaNiDiu3StP4DwOAQOB6A7vcX9GtMUUBrlRU7cuVkv8b94KzAi0 RCK1ZWnB17AfkKyFimW+2O7aRxhluHqzsRK+JfKaVU+QCu3zSBtezJzZ7LzONCSvwr0p HLjHlvZfwD1N7Xto2L1innP1cId75fhVoWAfQ0Ni7m3XpDRfbJf6SiPGD7sSO2EdgpG1 8ByQ== X-Gm-Message-State: AO0yUKW4hrLXj32JchBt+irSdg5gHN0KNAwLiKEQiw6aOoqkCcwp1iuo gwvYlCPsVUouiszdWXvvnNxZ+F3qSz6vV4O7 X-Google-Smtp-Source: AK7set81S39Ao6gE5/Hxr9lmLg/eu9AraFlQtH80ai7THAwFkPtKdNOlr3O7FnoGOJ1ndeFVf9OGeA== X-Received: by 2002:a17:903:3307:b0:198:adc4:228e with SMTP id jk7-20020a170903330700b00198adc4228emr2526252plb.9.1675375560570; Thu, 02 Feb 2023 14:06:00 -0800 (PST) Received: from p14s ([2604:3d09:148c:c800:bb50:10cc:f6a5:2176]) by smtp.gmail.com with ESMTPSA id p4-20020a1709028a8400b00177efb56475sm159532plo.85.2023.02.02.14.05.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Feb 2023 14:06:00 -0800 (PST) Date: Thu, 2 Feb 2023 15:05:57 -0700 From: Mathieu Poirier To: "Peng Fan (OSS)" Cc: andersson@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, arnaud.pouliquen@foss.st.com, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , iuliana.prodan@nxp.com, daniel.baluta@nxp.com Subject: Re: [PATCH V2 6/6] remoteproc: imx_rproc: set address of .interrupts section as bootaddr Message-ID: <20230202220557.GD1147631@p14s> References: <20230127092246.1470865-1-peng.fan@oss.nxp.com> <20230127092246.1470865-7-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230127092246.1470865-7-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230202_140605_263470_E3FA819B X-CRM114-Status: GOOD ( 23.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 27, 2023 at 05:22:46PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > i.MX93 M33 has ROM, it needs the ".interrupts" section address to start > M33 firmware. In current design, the Arm Trusted Firmware(ATF) use TCML > start address when the 2nd arg is 0 when SMC call. So When the M33 firmware > is built with TCML address, it works well. > > However when M33 firmware is built to run in DDR, we need pass the > ".interrupts" address as 2nd arg to ATF to start M33 firmwrae. > > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index f5ee0c9bb09d..59cca5ac3045 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -374,7 +374,8 @@ static int imx_rproc_start(struct rproc *rproc) > dcfg->src_start); > break; > case IMX_RPROC_SMC: > - arm_smccc_smc(IMX_SIP_RPROC, IMX_SIP_RPROC_START, 0, 0, 0, 0, 0, 0, &res); > + arm_smccc_smc(IMX_SIP_RPROC, IMX_SIP_RPROC_START, rproc->bootaddr, > + 0, 0, 0, 0, 0, &res); > ret = res.a0; > break; > case IMX_RPROC_SCU_API: > @@ -664,6 +665,13 @@ static u64 imx_rproc_get_boot_addr(struct rproc *rproc, const struct firmware *f > */ > writel(*(u32 *)(elf_data + offset), va); > writel(*(u32 *)(elf_data + offset + 4), va + 4); > + } else if (priv->dcfg->devtype == IMX_RPROC_IMX93) { > + /* i.MX93 Cortex-M33 has ROM, it only needs the section address */ > + shdr = rproc_elf_find_shdr(rproc, fw, ".interrupts"); > + if (!shdr) > + return bootaddr; This contradicts what you wrote in the cover letter of the patchset about an ".interrupts" section always being present. There is enough in this patchset to make me look for a second opinion. As such I am CC'ing Iuliana and Daniel. Please respin this, adding both of them to the recipient list. I will do another revision only when they have provided an RB tag. Thanks, Mathieu > + > + return elf_shdr_get_sh_addr(class, shdr); > } > > return bootaddr; > -- > 2.37.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel