From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95D95C05027 for ; Fri, 3 Feb 2023 14:30:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s/vDYkpBn22M5OwB+0O0C+9bm14NuznSacgWZTK6Sl4=; b=g2wJAlwd+eZtyB zS50RGRwSgyut7StZcRtHc34nv2R42o5UL+mvKeOEwiRQVhK0upFYGTffA9x937SFa9DRajJMtCo7 kbpg/ArjW7Op6flUInjpTyga3OsPUz2G4yjURUjocLuPyymhfrpgQcGfuDT9I018PunpiSPXhe0BR 3Fiqcf2ADW8CtflHLQbIqJ8DcQUJ+kEC0uYqHbINuOdzelBGNxzf9US5Tlmf8o+c2H23EiIDHMOy7 GsdQZ7vPMapgVEMoj0lFfIaqQ0Ab9n5w49vSOaiJ3Wq6wUXghYDRqxoHqP1KwFzYEa8A59e5/nAl/ 3gc/FT64yxbytqGRyo3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNx3w-002QyW-Ib; Fri, 03 Feb 2023 14:29:13 +0000 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNwtr-002LlB-Pt; Fri, 03 Feb 2023 14:18:49 +0000 Received: by mail-ed1-x532.google.com with SMTP id be12so5324765edb.4; Fri, 03 Feb 2023 06:18:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Y5QSL2KQ7I6Qbye6De1VwL36uZ19OhoWx467Nfxob8I=; b=oFKxvoCUuD0kdQrD8wLZOBSp4dHJc3BesofQGhdR7hhRNemcXWTuC9jlIJMSzYBv6J HWsVLvltQhLxb2O0lC8FYLFaeo7pyIwbRKuD1kaGN16r9MZtpHmd0/208Al5d8lgaehP SxTSa/gXboj+rMT6TaruMb4KyVGzEsJUU3gsAsCAhLnje1V8dMb5WDjsrieanlUJ+QnE fhimA7zv+xBh6GNsEu4+yeUz/94V0Uw2dAsEucDF//vkBtOWM36Y9NEwBd/KJ8cAqqYM /JMO04RD4Xz56hR45fxx6t+Mv9oW6qya25MeWIEpVcCq1h+xluL4//pKeBINs1uIow2l BNVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Y5QSL2KQ7I6Qbye6De1VwL36uZ19OhoWx467Nfxob8I=; b=wIXSq80qpowFPvid1Ry2B9GxePSUjKqN+1KPm7fdPtIHyB6Up5pKtWx1vsvl+i0Thp uWtUZYMYhlxpo6WtsLwATKpAuPQhpbCv6ME3/QbKB1dtq3OZpidlWWdUG11J3sfyUb1x tIfpfTSyMuQ0EJF7ZXIUK+8Dr+vyKxiH98U7X35rBpttk/rJg9X23gL7T2Ng6Sn5T+hE Xx8aFKO3oY/8uRdtvBytrXCIPP/DmnSP6+7VWYmX7G4PZ8R8CdB3l9OOe6AWtOSBtf2v 1/0MTg/tkuipI1apwXV5qsLWeIB9BEIe6fCoK2AemunoOAVmeTg6vsjIFG3foUiHLRb3 0BSQ== X-Gm-Message-State: AO0yUKV4578GiJrnHCkWW39nNYLEI8Tp8ksD+KT9Py20oMaITSy4WMOx njdm+wGXolfhMQNnyd9fQHVu2V4QOw9BAQ== X-Google-Smtp-Source: AK7set/lqhJkKG1jhrlMZ7tsVU350vT6gguJgctsAvHm76Udi3CWQAiKtESaORNQaAbHnXKFxJ2QPQ== X-Received: by 2002:a05:6402:124b:b0:49b:63ea:b5d8 with SMTP id l11-20020a056402124b00b0049b63eab5d8mr10962336edw.4.1675433923587; Fri, 03 Feb 2023 06:18:43 -0800 (PST) Received: from skbuf ([188.26.57.116]) by smtp.gmail.com with ESMTPSA id h23-20020a170906855700b00872a726783dsm1408158ejy.217.2023.02.03.06.18.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 06:18:43 -0800 (PST) Date: Fri, 3 Feb 2023 16:18:40 +0200 From: Vladimir Oltean To: Daniel Golle Cc: netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Russell King , Heiner Kallweit , Lorenzo Bianconi , Mark Lee , John Crispin , Felix Fietkau , AngeloGioacchino Del Regno , Matthias Brugger , DENG Qingfang , Landen Chao , Sean Wang , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Florian Fainelli , Andrew Lunn , Jianhui Zhao , =?utf-8?B?QmrDuHJu?= Mork Subject: Re: [PATCH 1/9] net: ethernet: mtk_eth_soc: add support for MT7981 SoC Message-ID: <20230203141840.chljzf3opxbxyp33@skbuf> References: <301fa3e888d686283090d58a060579d8c2a5bebb.1675407169.git.daniel@makrotopia.org> <301fa3e888d686283090d58a060579d8c2a5bebb.1675407169.git.daniel@makrotopia.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <301fa3e888d686283090d58a060579d8c2a5bebb.1675407169.git.daniel@makrotopia.org> <301fa3e888d686283090d58a060579d8c2a5bebb.1675407169.git.daniel@makrotopia.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230203_061847_889959_ED828B16 X-CRM114-Status: GOOD ( 12.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 03, 2023 at 07:00:21AM +0000, Daniel Golle wrote: > The MediaTek MT7981 SoC comes two 1G/2.5G SGMII, just like MT7986. > > In addition MT7981 comes with a built-in 1000Base-T PHY which can be > used with GMAC1. > > As many MT7981 boards make use of swapping SGMII phase and neutral, add > new device-tree attribute 'mediatek,pn_swap' to support them. > > Signed-off-by: Daniel Golle > --- Phase and neutral? What is this, a power plug? Since SGMII uses differential signaling, I wonder if this isn't about the polarity of the TX lane (which pin carries the Positive signal and which the Negative one). I think there is room for a more general device tree property name than "mediatek,pn_swap". The Designware XPCS also supports this, see DW_VR_MII_DIG_CTRL2_TX_POL_INV and the comments in nxp_sja1105_sgmii_pma_config(). _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel