From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C8FAC61DA4 for ; Fri, 3 Feb 2023 17:06:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B3tLGsHznu1ycL9iKN9SZljvg0bkym1Sremdf+I7P08=; b=BKo+Evrhb/G6Z3 lTVUbWqXP4dMB0YMFctEcOsGb0cW2KMnYSTe7jKNpI2GvbWZ8wN2abnjd1Il9cGWQqpXCbqgLffM+ 53rXgUoxFurgOrUGv1TGQEI+DFIeQegz3Xkox4G4wGFu8bvti7kowT2zDi/RqrzhiY25LOtKQfURt dbQ9zMjFORIJq3rmjvlmcUhsiyII4MmnqF5nPLrnjOnlsFuUZoRNPkuOLKDwg2fxzi4gjDN3gklRg VlGA+srN53vTvP6NJQFz3fdhDL5Ngv3bPzcegHy/9wk86NG34MBoYuOoQyyZBYInCB3PVtS3KiIze qxT+RJ+NQi1AMQ18ANQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNzUg-0031aU-Rr; Fri, 03 Feb 2023 17:04:58 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNzUd-0031Zt-Iw for linux-arm-kernel@lists.infradead.org; Fri, 03 Feb 2023 17:04:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 58449C14; Fri, 3 Feb 2023 09:05:34 -0800 (PST) Received: from bogus (unknown [10.57.12.205]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AC3EF3F71E; Fri, 3 Feb 2023 09:04:50 -0800 (PST) Date: Fri, 3 Feb 2023 17:04:48 +0000 From: Sudeep Holla To: Cristian Marussi Cc: Etienne Carriere , Sudeep Holla , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jens Wiklander , Sumit Garg Subject: Re: [PATCH 2/2] firmware: arm_scmi: optee: use optee system invocation Message-ID: <20230203170448.v5iduw2rhpxc47f3@bogus> References: <20230130094157.1082712-1-etienne.carriere@linaro.org> <20230130094157.1082712-2-etienne.carriere@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230203_090455_740116_E830E271 X-CRM114-Status: GOOD ( 19.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 03, 2023 at 02:36:26PM +0000, Cristian Marussi wrote: > On Mon, Jan 30, 2023 at 10:41:57AM +0100, Etienne Carriere wrote: > > Changes SCMI optee transport to enable sys_service capability of > > its tee context to leverage provisioned system resources in OP-TEE > > preventing possible deadlock. > > > > Such deadlock could happen when many Linux clients invoke OP-TEE are > > are all suspended waiting for an OP-TEE RPC request access an SCMI > > resource through the SCMI OP-TEE PTA service. > > > > Signed-off-by: Etienne Carriere > > --- > > drivers/firmware/arm_scmi/optee.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/firmware/arm_scmi/optee.c b/drivers/firmware/arm_scmi/optee.c > > index 2a7aeab40e54..91840345e946 100644 > > --- a/drivers/firmware/arm_scmi/optee.c > > +++ b/drivers/firmware/arm_scmi/optee.c > > @@ -559,6 +559,9 @@ static int scmi_optee_service_probe(struct device *dev) > > if (IS_ERR(tee_ctx)) > > return -ENODEV; > > > > + /* SCMI agent can used TEE system service resources */ > > + tee_ctx->sys_service = true; > > + > > agent = devm_kzalloc(dev, sizeof(*agent), GFP_KERNEL); > > if (!agent) { > > ret = -ENOMEM; > > LGTM. > > I suppose you'll sync-up with Sudeep for how to queue this whole series. > I thought I had responded to this but not. Anyways since TEE changes are significant than SCMI, you can route it via TEE tree. In that case, Acked-by: Sudeep Holla Let me know if that was not your plan. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel