From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECB53C636CD for ; Tue, 7 Feb 2023 03:39:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=p9+kUtkzP6+N1UEMBg/6qz9YOudqmrlmmxNYojlDENc=; b=d2Stu1Kq5kj1zy dakhhGdWS1tSq20RoXx9RmY/ZqgxXE1XVe1JPVICKHY6E1Jg5dy67DmLHrsP4q4pNkzhs//P5rxoA 7RjAtRsBx9/3MW0f8QD5k0uaeWIqNGDph9dOWRInFq+7IgJSnrSObEdVoV2/hTWAxCeCUDcQMa+j5 wQzRcqi7VcAGE14cMRqsCv0ELOWsiKVn09id15zuzRSzJ/UOX1DV1u07lyC+DsoB8tZZLlXxukx2t nIJEjh74EE5h1nJ4OFFCyqyWcxYflDYN6blNg9ob5jEzBEyA8qpFKPHoLKnamWy+GfxWxwegTvhku rvRJ3AvAM3SHESk8zYlQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPEot-00AenS-Ud; Tue, 07 Feb 2023 03:39:00 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPEoq-00Aeml-VC for linux-arm-kernel@lists.infradead.org; Tue, 07 Feb 2023 03:38:58 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 41B4B60C07; Tue, 7 Feb 2023 03:38:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8842C433D2; Tue, 7 Feb 2023 03:38:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675741135; bh=R8a0vravU3c65KQLuU/vTGT6AoF58hfs3+rHNo3Q9NM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GSdYP+zHlVSasdMOXsFH4C48jxqxf2QyOeklqErXVleHaj8VrgVGd8Q4bXdUC2cMN r8ik8/vJ03h8TXd3IEm/bKXSfMOZj9xR4APatoz/L/nQED+MKf/XQJNLl6hGe7+YGC wVXfMKzlP9Jgu9isTyV3YlMQTOz0ojX9b8o377jDauBg/gMNT+m53W3lqmSYyPehQt HVUBvW35eOMjizIDDCViGQofoLN3BW6KrHHxIaNpC2nG7zZUGV9hcJUBA92KGXzCLQ E8ccBwVfC471CGIePoxxo9ETALqwOXnTLfFRJcY3Y8Z/KmdVjNKI8PPFv4knhoY4Wh YIANxzavD/duQ== Date: Mon, 6 Feb 2023 19:41:08 -0800 From: Bjorn Andersson To: Kathiravan T Cc: krzysztof.kozlowski@linaro.org, agross@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, linus.walleij@linaro.org, catalin.marinas@arm.com, will@kernel.org, shawnguo@kernel.org, arnd@arndb.de, dmitry.baryshkov@linaro.org, marcel.ziswiler@toradex.com, nfraprado@collabora.com, robimarko@gmail.com, quic_gurus@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, quic_varada@quicinc.com, quic_srichara@quicinc.com Subject: Re: [PATCH V3 5/9] clk: qcom: add Global Clock controller (GCC) driver for IPQ5332 SoC Message-ID: <20230207034108.bypitlfxicpz6wqb@ripper> References: <20230206071217.29313-1-quic_kathirav@quicinc.com> <20230206071217.29313-6-quic_kathirav@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230206071217.29313-6-quic_kathirav@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230206_193857_060752_5049DB30 X-CRM114-Status: GOOD ( 12.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 06, 2023 at 12:42:13PM +0530, Kathiravan T wrote: > diff --git a/drivers/clk/qcom/gcc-ipq5332.c b/drivers/clk/qcom/gcc-ipq5332.c [..] > + > +enum { > + DT_SLEEP_CLK, > + DT_XO, > + DT_PCIE_2LANE_PHY_PIPE_CLK, > + DT_PCIE_2LANE_PHY_PIPE_X1_CLK, > + DT_USB_PCIE_WRAPPER_PIPE_CLK, This list does not match the clocks as defined in the binding. > +}; > + > +enum { > + P_PCIE3X2_PIPE, > + P_PCIE3X1_0_PIPE, > + P_PCIE3X1_1_PIPE, > + P_USB3PHY_0_PIPE, > + P_CORE_BI_PLL_TEST_SE, > + P_GCC_GPLL0_OUT_MAIN_DIV_CLK_SRC, > + P_GPLL0_OUT_AUX, > + P_GPLL0_OUT_MAIN, > + P_GPLL2_OUT_AUX, > + P_GPLL2_OUT_MAIN, > + P_GPLL4_OUT_AUX, > + P_GPLL4_OUT_MAIN, > + P_SLEEP_CLK, > + P_XO, > +}; > + > +static const struct clk_parent_data gcc_parent_data_xo = { .index = DT_XO }; > + > +static struct clk_alpha_pll gpll0_main = { > + .offset = 0x20000, > + .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_STROMER_PLUS], > + .clkr = { > + .enable_reg = 0xb000, > + .enable_mask = BIT(0), > + .hw.init = &(const struct clk_init_data){ Please add a space between ')' and '{ on all these. > + .name = "gpll0_main", > + .parent_data = &gcc_parent_data_xo, > + .num_parents = 1, > + .ops = &clk_alpha_pll_stromer_ops, > + }, > + }, > +}; [..] > +static const struct qcom_cc_desc gcc_ipq5332_desc = { > + .config = &gcc_ipq5332_regmap_config, > + .clks = gcc_ipq5332_clocks, > + .num_clks = ARRAY_SIZE(gcc_ipq5332_clocks), > + .resets = gcc_ipq5332_resets, > + .num_resets = ARRAY_SIZE(gcc_ipq5332_resets), > + .clk_hws = gcc_ipq5332_hws, > + .num_clk_hws = ARRAY_SIZE(gcc_ipq5332_hws), No GDSCs? Regards, Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel