From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C9C8C636CC for ; Tue, 7 Feb 2023 15:36:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1/cVRL9q6diqQ/INui/5HhbZ70oQjHq+6Ztntm1jEvw=; b=KquzqX/ASNB/oV klmHoWF41sQ8AyuOn1ccsh4+Cpy8HPytJHo839SGPOZzMDAPKpo4AvVRIDTROIW4XQXAp0GFEhZMG O0RbocD59Iu9i1HR3ZPMy046gRtp/b79T2KMtpPSGkE0Ln9igQQ5wfADHczo4N21zHa1Uu6XWVt6A Tc1EJnJVUYBx8Bit0yMlbzxlvNh3LDbRug97RWdu6x1TRtLpGNXocs4nGOBiT5c8KYz0222eZ5Xgy 9V5M91Ig6vg/FKIWj80jD14+MDf7A3xunymHCuctc5XcRZ27Db3c1wpUBGvYzlQQ06ImnJUkBbLj+ C8ca5HF4FSnCIP1MA1mw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPQ0I-00CjdP-3g; Tue, 07 Feb 2023 15:35:30 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPQ0E-00Cjcd-7c for linux-arm-kernel@lists.infradead.org; Tue, 07 Feb 2023 15:35:27 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7604BB816D7; Tue, 7 Feb 2023 15:35:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F11EC433D2; Tue, 7 Feb 2023 15:35:21 +0000 (UTC) Date: Tue, 7 Feb 2023 10:35:19 -0500 From: Steven Rostedt To: Florent Revest Cc: Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, mhiramat@kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kpsingh@kernel.org, jolsa@kernel.org, xukuohai@huaweicloud.com Subject: Re: [PATCH 1/8] ftrace: Replace uses of _ftrace_direct APIs with _ftrace_direct_multi Message-ID: <20230207103519.1f0ef013@gandalf.local.home> In-Reply-To: References: <20230201163420.1579014-1-revest@chromium.org> <20230201163420.1579014-2-revest@chromium.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230207_073526_447308_B51D4A49 X-CRM114-Status: GOOD ( 17.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 7 Feb 2023 16:21:49 +0100 Florent Revest wrote: > Actually, I'm not sure anymore if we should delete the !multi samples... > > I realized that they are also used as part of the ftrace selftests in: > - tools/testing/selftests/ftrace/test.d/direct/ftrace-direct.tc > - tools/testing/selftests/ftrace/test.d/direct/kprobe-direct.tc > > It does not really make sense to use the ftrace-direct-muti sample as > a drop-in replacement for the ftrace-direct sample there since they > don't really do the same thing so we would either need to change the > test a bit or the multi sample. > Also, we would still need to adapt the ftrace-direct-too sample since > it has no multi equivalent and is required there. Let's not delete the samples, and they do test slightly different use cases (although the code may be somewhat the same). I rather still keep that test coverage. -- Steve _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel