From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Dinh Nguyen <dinguyen@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH 2/2] dt-bindings: altera: Add enclustra mercury PE1
Date: Tue, 7 Feb 2023 13:47:31 +0100 [thread overview]
Message-ID: <20230207124731.GB793@pengutronix.de> (raw)
In-Reply-To: <6ee3eeef-3443-aa74-16a4-6854c166c378@linaro.org>
On Tue, Feb 07, 2023 at 11:48:56AM +0100, Krzysztof Kozlowski wrote:
> On 07/02/2023 10:41, Steffen Trumtrar wrote:
> > Add binding for the enclustra PE1 baseboard from enclustra GmbH.
> >
> > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> > ---
> > Documentation/devicetree/bindings/arm/altera.yaml | 1 +
>
> Bindings are before the usage. Otherwise you have checkpatch error.
>
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/altera.yaml b/Documentation/devicetree/bindings/arm/altera.yaml
> > index 3eee03aa935c..6f306f9f2f9d 100644
> > --- a/Documentation/devicetree/bindings/arm/altera.yaml
> > +++ b/Documentation/devicetree/bindings/arm/altera.yaml
> > @@ -32,6 +32,7 @@ properties:
> > items:
> > - enum:
> > - google,chameleon-v3
> > + - enclustra,mercury-pe1
>
> Messed order, keep alphabetical order.
>
> > - const: enclustra,mercury-aa1
> > - const: altr,socfpga-arria10
> > - const: altr,socfpga
>
Ack.
Thanks,
Steffen Trumtrar
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-07 12:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 9:41 [PATCH 1/2] ARM: dts: socfpga: Add enclustra PE1 devicetree Steffen Trumtrar
2023-02-07 9:41 ` [PATCH 2/2] dt-bindings: altera: Add enclustra mercury PE1 Steffen Trumtrar
2023-02-07 10:48 ` Krzysztof Kozlowski
2023-02-07 12:47 ` Steffen Trumtrar [this message]
2023-02-07 10:49 ` [PATCH 1/2] ARM: dts: socfpga: Add enclustra PE1 devicetree Krzysztof Kozlowski
2023-02-07 12:46 ` Steffen Trumtrar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230207124731.GB793@pengutronix.de \
--to=s.trumtrar@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).