From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52CADC05027 for ; Wed, 8 Feb 2023 15:04:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KrMZErI5iBEHVLvW865OPoPb//5kAXUY8BjvX7/paUU=; b=bFAhUzOoUZ69cl bSw7w8GP7gS70DNaZojuumMJmSAtGlR1VfVrM7aLcyeRE8U2rd6clMMnUUPk1Zw+yp76RzVdwxCPI ++z33Dwov9hCXhrpI6dylKO/oRnXkk6KglGwEEk2ZeMPiYIulC8tBRpt8Qr1ooxlXZ/r7hsFV7zmi FJTqGksJpKaA1gIE8p04dolVHbJpDvLOdZ0QWWjOAQCyR+3gcw7433AqAr3pYPmcVZdMOZW3Cq81R nD3r8fVxaKVJsGzBI3JZ2lpN3sDyA4S8tbDELkjWwaAi9WDbRZ8oMwiJpoJN2EB+obb7MYaxo3aTk vf/gIuatot0ZhIJg1H2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPlyg-00G0Mj-EY; Wed, 08 Feb 2023 15:03:18 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPlyb-00G0Lm-Vj for linux-arm-kernel@lists.infradead.org; Wed, 08 Feb 2023 15:03:15 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 102221477; Wed, 8 Feb 2023 07:03:54 -0800 (PST) Received: from bogus (unknown [10.57.10.143]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8EB9C3F8C6; Wed, 8 Feb 2023 07:03:09 -0800 (PST) Date: Wed, 8 Feb 2023 15:03:06 +0000 From: Sudeep Holla To: Kazuki Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Rafael J. Wysocki" , Daniel Lezcano , Lorenzo Pieralisi , Hector Martin , Sven Peter , Len Brown , Pavel Machek Subject: Re: s2idle breaks on machines without cpuidle support Message-ID: <20230208150306.ve2pnt3pvlmf5wbu@bogus> References: <20230204152747.drte4uitljzngdt6@kazuki-mac> <20230206101239.dret3fv65cnzpken@bogus> <20230207194818.exskn3dhyzqwr32v@kazuki-mac> <20230208103511.w7jzxw6spy6humdn@bogus> <20230208112031.sdfuluajjerf4wwp@kazuki-mac> <20230208141658.kede5ylqk4zqvrnj@bogus> <20230208144327.3ftjxnquwhsdykfc@kazuki-mac> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230208144327.3ftjxnquwhsdykfc@kazuki-mac> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230208_070314_082359_DC6F894B X-CRM114-Status: GOOD ( 16.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 08, 2023 at 11:43:27PM +0900, Kazuki wrote: > On Wed, Feb 08, 2023 at 02:16:58PM +0000, Sudeep Holla wrote: [...] > > I was about ask you earlier as why can't you implement just system > > suspend in PSCI where the last cpu just calls WFI if you are interested > > in system sleep state. Or you can implement CPU_SUSPEND with an additional > > retention state which enters PSCI implementation just to make sure there is > > an active cpuidle driver and the s2idle state machinery works as expected. > > The machine I have (Macbook with Apple M1) doesn't have PSCI. Well, if we are allowing to boot on such a system, then we must allow adding a platform specific idle driver. It may be useful once we info to add deeper than WFI states. > I guess we should ensure that systems without a cpuidle driver > will not suspend maybe around here then. > Are we ? I thought were making changes to enable it. Or are you saying we allow to enter into such a state and render the system unusable, if so we need to fix it. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel