From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02C7BC05027 for ; Wed, 8 Feb 2023 15:35:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T20Irkz9ifXrAWc6ncgN4kJGUQmbtoUmWd5lvOeRC2M=; b=Lzhc/qLS/pbQhI iYu4UVvdm3I02rltrm47Oc/IxmKJa9lMkCIRaajIQB5D5Yo77OatOTiHMkjkbOKFO4ueYdnoJ4r/f rpEneQjpE84YRE9ZRCrhlwc7LyHW0Okx/rLuOe+LvzYkGSP9HKIuSJlXuP1fsAbfVFwL15UZi1+zt I+fQTuyPkA8fuQ4212CAG9AP6u9J8avgQFxplXU6ksFEMhcCcMJo2vkaV4vuX2dI8kMgzFlBmaUoU yPMfDtRNnFg/aArdVTcJgvUPqv1tvvmZ7/TPOlKn2cRaggLXFSwnBu8pYgUN+yD5CsAfEuOFS0vZN XDYrZGUcLQ3r7Ln6EkLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPmSk-00G62v-IX; Wed, 08 Feb 2023 15:34:22 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPmSf-00G620-OF for linux-arm-kernel@lists.infradead.org; Wed, 08 Feb 2023 15:34:20 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DD9ED1477; Wed, 8 Feb 2023 07:34:55 -0800 (PST) Received: from bogus (unknown [10.57.10.143]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 23E203F8C6; Wed, 8 Feb 2023 07:34:10 -0800 (PST) Date: Wed, 8 Feb 2023 15:34:07 +0000 From: Sudeep Holla To: Kazuki Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Holla , "Rafael J. Wysocki" , Daniel Lezcano , Lorenzo Pieralisi , Hector Martin , Sven Peter , Len Brown , Pavel Machek Subject: Re: s2idle breaks on machines without cpuidle support Message-ID: <20230208153407.4a5vnbctf77xf5vf@bogus> References: <20230204152747.drte4uitljzngdt6@kazuki-mac> <20230206101239.dret3fv65cnzpken@bogus> <20230207194818.exskn3dhyzqwr32v@kazuki-mac> <20230208103511.w7jzxw6spy6humdn@bogus> <20230208112031.sdfuluajjerf4wwp@kazuki-mac> <20230208141658.kede5ylqk4zqvrnj@bogus> <20230208144327.3ftjxnquwhsdykfc@kazuki-mac> <20230208150306.ve2pnt3pvlmf5wbu@bogus> <20230208151939.meya6c5gayspvmtr@kazuki-mac> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230208151939.meya6c5gayspvmtr@kazuki-mac> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230208_073417_850633_7CE747F6 X-CRM114-Status: GOOD ( 18.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 09, 2023 at 12:19:39AM +0900, Kazuki wrote: > On Wed, Feb 08, 2023 at 03:03:06PM +0000, Sudeep Holla wrote: [...] > > Well, if we are allowing to boot on such a system, then we must allow > > adding a platform specific idle driver. It may be useful once we info > > to add deeper than WFI states. > > Hmmm, I thought for arm64, non-PSCI idle drivers were prohibited? Or am > I mistaken here? I don't know. I am not against it especially now that we have allowed a non-PSCI based production system to boot the kernel. > > Are we ? I thought were making changes to enable it. Or are you saying > > we allow to enter into such a state and render the system unusable, if > > so we need to fix it. > > Both as I mentioned in my first email. Apologies if it turned out to > be confusing. Sorry still confusing. Are you saying you can enter s2idle and crash or hang the system without changes(especially around this s2idle code) ? If yes, then it is a bug. If the hang/crash is only after your changes, we need to check. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel