From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C67FC636D3 for ; Wed, 8 Feb 2023 23:13:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JAF7swlwC4+535dPyAWYkngV9KgXF+hdFClDy6Uc1es=; b=kkqeL815kN1pbY CwRhCE80LbQAFMWZKhHPYTE0yQ3xzRklIidF31XPxdqxU08Wh7cOLlN9n7mBsU4oM7ZR8lU47+2vw YXkud1Rv90X7EDFIy2U5kofse8npFJXI8hePFeRlRrcLCmhpJ1QauACM7em+2kAqaK7ZgdUGvA29p YI7qPuvsCATBVjhmZGJxarHaqiuw1pa/HTJdBO89wjq+H/v/lTQ5+7dHgCu/4lBQtzJ6Mk/3KalcN QIXGLxvIOa5zt6oNidjEDYMI2jftO76RFwM5RKpmVC4+7qPzo0x+2Tc60vpeS7R4NkRYcPYnwDr9h HxSPsM9OIBXfO+nJWjaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPtbk-00H9pJ-7T; Wed, 08 Feb 2023 23:12:08 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPtbg-00H9oa-Nz for linux-arm-kernel@lists.infradead.org; Wed, 08 Feb 2023 23:12:06 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F0DE4B81F37; Wed, 8 Feb 2023 23:12:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9807C433EF; Wed, 8 Feb 2023 23:11:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675897921; bh=gufkRKfxWieX6HKMKArJihwskH/QJRSmt/NO9zfWLT8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hBN8j/fttWOPC34Cxzc6MS1JwPv/SldB1DaPlkbchtqv3Lkya5gpnQ/qRjxiyco0M qEdmTzcSrJH0eVKpoRwks3hVFNliY8AuoGZG72PJnOEx2bglI6LGe4lK0eW6muftQG 9osNQpAJUTqE3CmZVOZyT4rga+U2FHZJalbkx6pG2fpNxChcqsyG9WsKPWiHO0VmJH VyzYnuW5eerHDtkXf9hj9xL5hkMQNRcEgAbj+bSE5lLGH3scp8FRS5jM9KNJTTLVVQ qLVSDJ2dvwA89lE1zfz0k/GcM1bxkE7YVqasU3seN0SSl7YkzT9SD9sib0qMFZR7dY LE3dX4FzKlpOA== Date: Wed, 8 Feb 2023 15:14:12 -0800 From: Bjorn Andersson To: devi priya Cc: agross@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, linus.walleij@linaro.org, catalin.marinas@arm.com, will@kernel.org, p.zabel@pengutronix.de, shawnguo@kernel.org, arnd@arndb.de, marcel.ziswiler@toradex.com, dmitry.baryshkov@linaro.org, nfraprado@collabora.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, quic_srichara@quicinc.com, quic_gokulsri@quicinc.com, quic_sjaganat@quicinc.com, quic_kathirav@quicinc.com, quic_arajkuma@quicinc.com, quic_anusha@quicinc.com, quic_poovendh@quicinc.com Subject: Re: [PATCH V3 4/7] pinctrl: qcom: Add IPQ9574 pinctrl driver Message-ID: <20230208231412.yqp3rvokvmbb7ixi@ripper> References: <20230130125528.11509-1-quic_devipriy@quicinc.com> <20230130125528.11509-5-quic_devipriy@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230130125528.11509-5-quic_devipriy@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230208_151204_949327_75EC53BC X-CRM114-Status: UNSURE ( 9.54 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 30, 2023 at 06:25:25PM +0530, devi priya wrote: > +static const struct msm_pingroup ipq9574_groups[] = { > + PINGROUP(0, sdc_data, qspi_data, qdss_traceclk_b, _, _, _, _, _, _), > + PINGROUP(1, sdc_data, qspi_data, qdss_tracectl_b, _, _, _, _, _, _), > + PINGROUP(2, sdc_data, qspi_data, qdss_tracedata_b, _, _, _, _, _, _), > + PINGROUP(3, sdc_data, qspi_data, qdss_tracedata_b, _, _, _, _, _, _), > + PINGROUP(4, sdc_cmd, qspi_cs, qdss_tracedata_b, _, _, _, _, _, _), > + PINGROUP(5, sdc_clk, qspi_clk, qdss_tracedata_b, _, _, _, _, _, > + _), Please avoid line wrapping these, it just makes it hard to read. [..] > +}; > + > +/* Reserving GPIO59 for controlling the QFPROM LDO regulator */ This seems like a property of the board, please use gpio-reserved-ranges in the DT node instead. Thanks, Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel