From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2E5BC636D3 for ; Fri, 10 Feb 2023 08:52:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DFKHOHIwQTuw97FOn0EIVzqqgpJfw/FunaJJ6QIcifg=; b=x3flMudh3MpeHT opNSYN13OkPudSAJGDDHZA2h51Oof3PNgnUrVNPblFiQaGPn/ruGwOiLPl+KYuXsoOA2oJGWnUUaT vevaRhWbqOv8qkrwKik4hpwj5/y7hAeAmyVfxpMG4uiYIqYv1OkITOrT/tADqL31IvTx+7vvssmoS V8wU9SULNQfh4WOlmnzYx5hgGSY6ndhAEsxQZjdZzLanaFYDVwF6KriQZJfLEUsgVAQb8x8WJbo+Q lu9fBhxKkLNf9PHvthto+GkCbIirJkhAQyaZf7GNlbj8Z78T7oOihV+8y8rlcdU510FUzNtk4MLtA MVR4L4VWmMQhD9C5pq1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQP8P-004qWs-Ua; Fri, 10 Feb 2023 08:51:58 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQP8M-004qVh-U4 for linux-arm-kernel@lists.infradead.org; Fri, 10 Feb 2023 08:51:56 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 918E461CDB; Fri, 10 Feb 2023 08:51:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4E48C433D2; Fri, 10 Feb 2023 08:51:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676019112; bh=pfgbWjkFK1mgUz1QuuWRK/O1mo8JlviZmKYugkLWa18=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ueAv5VOuGWpJ2RknL7PoMZ4XDZBvCd2OYFra0a/qsC2U+lHINIlad2rQxJGwRbsMo 80mWmA1XyE3RUgLtKBmPAXVHCHidCrZG3K5xZWnyXPGSGPqT0jiwaPI60SQnvb0k0c 5ZX8uowVEzcMFgZ537dC3Hve+4M1CDCEzZgcZEBb8oPaLzUBTVQhKzBf9X5Swf1N23 64nY3AyOTesVRSKN6nsxC5LgCKQ4X/FrT24j/SeatqDJp/9NP7eBlf9ToppQhc0eJ1 k1M4e1MA0ISIkiJoOFr8hYIfBdTH/vVRfH1l5saZAglGvgm7WkUX/6oTYMeleDIngm VQwVl4W/UJTSg== Date: Fri, 10 Feb 2023 16:51:40 +0800 From: Peter Chen To: Alexander Stein Cc: Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Fabio Estevam , Pengutronix Kernel Team , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/1] usb: chipidea: ci_hdrc_imx: use dev_err_probe Message-ID: <20230210085140.GB1991028@nchen-desktop> References: <20230130094151.95174-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230130094151.95174-1-alexander.stein@ew.tq-group.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230210_005155_046366_7D286C45 X-CRM114-Status: GOOD ( 19.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23-01-30 10:41:51, Alexander Stein wrote: > Add error message if finding USB PHY fails or is deferred. > > Signed-off-by: Alexander Stein Acked-by: Peter Chen Peter > --- > drivers/usb/chipidea/ci_hdrc_imx.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c > index 0dc482542d85..2eeccf4ec9d6 100644 > --- a/drivers/usb/chipidea/ci_hdrc_imx.c > +++ b/drivers/usb/chipidea/ci_hdrc_imx.c > @@ -413,15 +413,19 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev) > data->phy = devm_usb_get_phy_by_phandle(dev, "fsl,usbphy", 0); > if (IS_ERR(data->phy)) { > ret = PTR_ERR(data->phy); > - if (ret != -ENODEV) > + if (ret != -ENODEV) { > + dev_err_probe(dev, ret, "Failed to parse fsl,usbphy\n"); > goto err_clk; > + } > data->phy = devm_usb_get_phy_by_phandle(dev, "phys", 0); > if (IS_ERR(data->phy)) { > ret = PTR_ERR(data->phy); > - if (ret == -ENODEV) > + if (ret == -ENODEV) { > data->phy = NULL; > - else > + } else { > + dev_err_probe(dev, ret, "Failed to parse phys\n"); > goto err_clk; > + } > } > } > > -- > 2.34.1 > -- Thanks, Peter Chen _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel