From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6EE1C05027 for ; Fri, 10 Feb 2023 18:38:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EvrDTe/kFofHnVjlqz4g0TjqKeHPotBVxAgqAjNU0rI=; b=C3vrtO+HNaJHTf Yf0kQ6DCWYnJcGd4WH9WROxSBdZOtoGciwzrH3MwsAeD4n+N6vIm0mkYCo8RZ5Ug2sY1h0fWaKiKp 7jJOi/TS89A960YyU1hrNLepzpz2iKtXx8b2fS6qaMyeRPrsPxf8Zuf04uoB8p+MYGYvjmQ3EowBC 03bYWP23UlrN0V52fQy6M22kNGKAhuTsBWzL0YabZhvJ73LSYsAblMvZqeMO4j+ldqhkz0NSW+65X wjgiHFkke1sDGlUB9arx5fe0wfmxeakvnWRLL1Tf/NBjTLkvuHGsMfc8RfOZVaOKf73jl/BkRD2e/ UhFnweKVTFKDh0ol+TMQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQYHP-006y49-I7; Fri, 10 Feb 2023 18:37:51 +0000 Received: from mail-oo1-f49.google.com ([209.85.161.49]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQYHM-006y3E-6m for linux-arm-kernel@lists.infradead.org; Fri, 10 Feb 2023 18:37:49 +0000 Received: by mail-oo1-f49.google.com with SMTP id w3-20020a4aa443000000b0051ac1e0f6b7so612546ool.11 for ; Fri, 10 Feb 2023 10:37:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j7h/WebataPPaEa1u0vdSZ4RcwWXCSihrRS9Y13n00s=; b=fGs3a1e8Oh3EuooLxlrFwFsh0taeNzvnta/fKrPjoYv4SGwzmrqByz+Fv0GuIiWxOq 0o3xmPksD82mZR/TR5XWwvvz7d4fei6JHcFYly1lDK+2kGIukVQXD4do+n1g7eIIVzlo q/isWkrfp5tIMqBSPnLh+Ff+JWeJtF7TEbCZCPf0VQRVCsUkvbJm7yaZ8UGYa+uzCFXW jJSFa6zm6ekqM2UWQdtDcS1L05EauM+7gSRZkd/uZQcA/McJra+pRWLwIZ1y0e2NIYCS +KWAC4LaAaqreELPw9BH4QGG5fMWRW/WUFLOpSU7QsrgI4/AQXDHfn5Az2I+JTae80aS Ah1w== X-Gm-Message-State: AO0yUKUlofym9iT2jRh6Jccrda3OMKU7g7v5IrRghUPnfwwXaFfta/vd 4+LxGa+qDWmkEKnhGAgmt39MCWKy1g== X-Google-Smtp-Source: AK7set830zF5ycsji4Hw2LbzEHyGO0HXDM7rD8uyVm2n3BwbUfUR1WJMnLdu6EWioWTCmNi77JlAxA== X-Received: by 2002:a05:6820:449:b0:51a:7a15:9758 with SMTP id p9-20020a056820044900b0051a7a159758mr7198969oou.5.1676054266872; Fri, 10 Feb 2023 10:37:46 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id t5-20020a4adbc5000000b00511e01623bbsm2286985oou.7.2023.02.10.10.37.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Feb 2023 10:37:46 -0800 (PST) Received: (nullmailer pid 2925630 invoked by uid 1000); Fri, 10 Feb 2023 18:37:45 -0000 Date: Fri, 10 Feb 2023 12:37:45 -0600 From: Rob Herring To: Md Danish Anwar Subject: Re: [EXTERNAL] Re: [PATCH v5 1/2] dt-bindings: net: Add ICSSG Ethernet Message-ID: <20230210183745.GA2923614-robh@kernel.org> References: <20230210114957.2667963-1-danishanwar@ti.com> <20230210114957.2667963-2-danishanwar@ti.com> <167603709479.2486232.8105868847286398852.robh@kernel.org> <69f54246-5541-7899-f4ed-76d0a600e1b0@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <69f54246-5541-7899-f4ed-76d0a600e1b0@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230210_103748_266895_C4854112 X-CRM114-Status: GOOD ( 21.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: srk@ti.com, andrew@lunn.ch, nm@ti.com, linux-omap@vger.kernel.org, Vignesh Raghavendra , devicetree@vger.kernel.org, netdev@vger.kernel.org, YueHaibing , linux-kernel@vger.kernel.org, MD Danish Anwar , "Andrew F. Davis" , Roger Quadros , Eric Dumazet , Krzysztof Kozlowski , ssantosh@kernel.org, Jakub Kicinski , Paolo Abeni , "David S. Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 10, 2023 at 09:00:59PM +0530, Md Danish Anwar wrote: > > > On 10/02/23 19:28, Rob Herring wrote: > > > > On Fri, 10 Feb 2023 17:19:56 +0530, MD Danish Anwar wrote: > >> From: Puranjay Mohan > >> > >> Add a YAML binding document for the ICSSG Programmable real time unit > >> based Ethernet hardware. The ICSSG driver uses the PRU and PRUSS consumer > >> APIs to interface the PRUs and load/run the firmware for supporting > >> ethernet functionality. > >> > >> Signed-off-by: Puranjay Mohan > >> Signed-off-by: Md Danish Anwar > >> --- > >> .../bindings/net/ti,icssg-prueth.yaml | 184 ++++++++++++++++++ > >> 1 file changed, 184 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml > >> > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > ./Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/remoteproc/ti,pru-consumer.yaml > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/ti,icssg-prueth.example.dtb: ethernet: False schema does not allow {'compatible': ['ti,am654-icssg-prueth'], 'pinctrl-names': ['default'], 'pinctrl-0': [[4294967295]], 'ti,sram': [[4294967295]], 'ti,prus': [[4294967295, 4294967295, 4294967295, 4294967295, 4294967295, 4294967295]], 'firmware-name': ['ti-pruss/am65x-pru0-prueth-fw.elf', 'ti-pruss/am65x-rtu0-prueth-fw.elf', 'ti-pruss/am65x-txpru0-prueth-fw.elf', 'ti-pruss/am65x-pru1-prueth-fw.elf', 'ti-pruss/am65x-rtu1-prueth-fw.elf', 'ti-pruss/am65x-txpru1-prueth-fw.elf'], 'ti,pruss-gp-mux-sel': [[2, 2, 2, 2, 2, 2]], 'dmas': [[4294967295, 49920], [4294967295, 49921], [4294967295, 49922], [4294967295, 49923], [4294967295, 49924], [4294967295, 49925], [4294967295, 49926], [4294967295, 49927], [4294967295, 17152], [4294967295, 17153]], 'dma-names': ['tx0-0', 'tx0-1', 'tx0-2', 'tx0-3', 'tx1-0', 'tx1-1', 'tx1-2', 'tx1-3', 'rx0', 'rx1'], 'ti,mii-g-rt': [[429! > > 4967295]], 'interrupts': [[24, 0, 2], [25, 1, 3]], 'interrupt-names': ['tx_ts0', 'tx_ts1'], 'ethernet-ports': {'#address-cells': [[1]], '#size-cells': [[0]], 'port@0': {'reg': [[0]], 'phy-handle': [[4294967295]], 'phy-mode': ['rgmii-id'], 'interrupts-extended': [[4294967295, 24]], 'ti,syscon-rgmii-delay': [[4294967295, 16672]], 'local-mac-address': [[0, 0, 0, 0, 0, 0]]}, 'port@1': {'reg': [[1]], 'phy-handle': [[4294967295]], 'phy-mode': ['rgmii-id'], 'interrupts-extended': [[4294967295, 25]], 'ti,syscon-rgmii-delay': [[4294967295, 16676]], 'local-mac-address': [[0, 0, 0, 0, 0, 0]]}}, '$nodename': ['ethernet']} > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/ti,icssg-prueth.example.dtb: ethernet: Unevaluated properties are not allowed ('firmware-name', 'ti,prus', 'ti,pruss-gp-mux-sel' were unexpected) > > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml > > > > doc reference errors (make refcheckdocs): > > > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230210114957.2667963-2-danishanwar@ti.com > > Hi Rob, > This patch depends on the patch [1] which is posted through series [2]. Patch > [1] is currently approved, reviewed and will soon be merged to mainline Linux. > Once it is merged this patch won't throw the above error. > > In the meantime I have posted this patch to get it reviewed so that once patch > [1] gets merged, this will be ready to be merged. > > [1] https://lore.kernel.org/all/20230106121046.886863-2-danishanwar@ti.com/ > [2] https://lore.kernel.org/all/20230106121046.886863-1-danishanwar@ti.com/ State that in *this* patch if you don't want to get the report. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel