From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83156C636D4 for ; Fri, 10 Feb 2023 19:21:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QTll7O/ID/EdkKmUPBXTH3drYRpz8xeUz/tD7Nz4c/0=; b=vJ0aEFk7LTyewL deBlYAxRH6VCLKl5f9nTJRbTPomVvvxH8TXnQ0XY1KFbagUC0sGHHVw87K+M9t3VT8FcNu1HulCw8 L70kAPW8Y5Blt3Kh3EEV+aCrxrDOJlp/m8ofJH+IerI9Fj+MK44HDE7mfzoGFLz38K/J3K3EMTSBV 7E0CL3ZENBbeP3aXKh/vVCesDNohkK1S5CPCECsyRdyC7IkmNl5dUkYNa5SWkdK5K9YodMIclvg8I a6V14iHZ+s7DqAb8Vt9LvhqzEcmT7Jo0yAa3wVmS3R44/ZjCSWQwNvEHC9Z2aLFL5b9GCn5AGOXFg ax3cTB/v3zpwFsZkC/+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQYwJ-0074Tt-RD; Fri, 10 Feb 2023 19:20:07 +0000 Received: from mail-oa1-f53.google.com ([209.85.160.53]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQYwH-0074Ss-0v for linux-arm-kernel@lists.infradead.org; Fri, 10 Feb 2023 19:20:06 +0000 Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-16aca2628c6so5724738fac.7 for ; Fri, 10 Feb 2023 11:20:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=O0/BgPoPhr1KWdvyyKwGYcpVH7e6nXDxaQdDCUHcTK4=; b=STbrwWVrYonV2mxxWun9umBU70ULn+grtvEGMgybaNsnQGbWUmU5HcRNtYg+ThJLOr TAfU5BCnmm6Cw5DtPjA0jFVHWqqxcaI1YWes1XppjeEKAP+GAW1y8nB8OjKFni8xf2mA PXBvgrsNuVxV97ivd9xx+Y1tpPKJH0ruGUMxpg7HT/16hXytEafLxWIBbBJlTBr/NEHO O2WINbc9D7/e+aPf0sTfYfSeIbqBfiQ0N7GXa/Qua8Bav9MioGrQOUmLFd5NNx5HpRk8 IH46IJc4Y3T/kTZ3jEA9CblcbhvPoU6OwE+9SFn0D+/8xJu5aKdsw9bEAnSwfDIdugnu TMQw== X-Gm-Message-State: AO0yUKWK2PKk92whQE4Q9QgsyaVI1WqfQV3yKxq7/DgVKIniEviMf1MT XJJtE+o1+tKVCvWr2rATgw== X-Google-Smtp-Source: AK7set8JG94u8QaNAm6pZm73hOXlkC85NrnHVuzZmEXNlw4rAyD6NZ3YROCBaC4KXKBQbSt/GVtidw== X-Received: by 2002:a05:6870:f106:b0:16a:b020:d05 with SMTP id k6-20020a056870f10600b0016ab0200d05mr2055688oac.19.1676056802853; Fri, 10 Feb 2023 11:20:02 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id ea53-20020a056870073500b0014fb4bdc746sm2264560oab.8.2023.02.10.11.20.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Feb 2023 11:20:02 -0800 (PST) Received: (nullmailer pid 3034804 invoked by uid 1000); Fri, 10 Feb 2023 19:20:01 -0000 Date: Fri, 10 Feb 2023 13:20:01 -0600 From: Rob Herring To: MD Danish Anwar Subject: Re: [PATCH v5 1/2] dt-bindings: net: Add ICSSG Ethernet Message-ID: <20230210192001.GB2923614-robh@kernel.org> References: <20230210114957.2667963-1-danishanwar@ti.com> <20230210114957.2667963-2-danishanwar@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230210114957.2667963-2-danishanwar@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230210_112005_090314_C5B33FA9 X-CRM114-Status: GOOD ( 23.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, andrew@lunn.ch, Paolo Abeni , Vignesh Raghavendra , linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, YueHaibing , srk@ti.com, "Andrew F. Davis" , Roger Quadros , Eric Dumazet , netdev@vger.kernel.org, Krzysztof Kozlowski , ssantosh@kernel.org, Jakub Kicinski , "David S. Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 10, 2023 at 05:19:56PM +0530, MD Danish Anwar wrote: > From: Puranjay Mohan > > Add a YAML binding document for the ICSSG Programmable real time unit > based Ethernet hardware. The ICSSG driver uses the PRU and PRUSS consumer > APIs to interface the PRUs and load/run the firmware for supporting > ethernet functionality. > > Signed-off-by: Puranjay Mohan > Signed-off-by: Md Danish Anwar > --- > .../bindings/net/ti,icssg-prueth.yaml | 184 ++++++++++++++++++ > 1 file changed, 184 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml > > diff --git a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml > new file mode 100644 > index 000000000000..8b860f29ecc0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml > @@ -0,0 +1,184 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/ti,icssg-prueth.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments ICSSG PRUSS Ethernet > + > +maintainers: > + - Md Danish Anwar > + > +description: > + Ethernet based on the Programmable Real-Time > + Unit and Industrial Communication Subsystem. Odd line wrap length. It should be 80 chars. > + > +allOf: > + - $ref: /schemas/remoteproc/ti,pru-consumer.yaml# > + > +properties: > + compatible: > + enum: > + - ti,am654-icssg-prueth # for AM65x SoC family > + > + ti,sram: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + phandle to MSMC SRAM node I believe we have a standard 'sram' property to point to SRAM nodes assuming this is just mmio-sram or similar. > + > + dmas: > + maxItems: 10 > + > + dma-names: > + items: > + - const: tx0-0 > + - const: tx0-1 > + - const: tx0-2 > + - const: tx0-3 > + - const: tx1-0 > + - const: tx1-1 > + - const: tx1-2 > + - const: tx1-3 > + - const: rx0 > + - const: rx1 > + > + ti,mii-g-rt: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: | > + phandle to MII_G_RT module's syscon regmap. > + > + ti,mii-rt: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: | > + phandle to MII_RT module's syscon regmap > + > + interrupts: > + maxItems: 2 > + description: | Don't need '|' > + Interrupt specifiers to TX timestamp IRQ. > + > + interrupt-names: > + items: > + - const: tx_ts0 > + - const: tx_ts1 > + > + ethernet-ports: > + type: object > + additionalProperties: false > + > + properties: > + '#address-cells': > + const: 1 > + '#size-cells': > + const: 0 > + > + patternProperties: > + ^port@[0-1]$: > + type: object > + description: ICSSG PRUETH external ports > + $ref: ethernet-controller.yaml# > + unevaluatedProperties: false > + > + properties: > + reg: > + items: > + - enum: [0, 1] > + description: ICSSG PRUETH port number > + > + interrupts: > + maxItems: 1 > + > + ti,syscon-rgmii-delay: > + items: > + - items: > + - description: phandle to system controller node > + - description: The offset to ICSSG control register > + $ref: /schemas/types.yaml#/definitions/phandle-array > + description: > + phandle to system controller node and register offset > + to ICSSG control register for RGMII transmit delay > + > + required: > + - reg > + anyOf: > + - required: > + - port@0 > + - required: > + - port@1 > + > +required: > + - compatible > + - ti,sram > + - dmas > + - dma-names > + - ethernet-ports > + - ti,mii-g-rt > + - interrupts > + - interrupt-names > + > +unevaluatedProperties: false > + > +examples: > + - | > + /* Example k3-am654 base board SR2.0, dual-emac */ > + pruss2_eth: ethernet { > + compatible = "ti,am654-icssg-prueth"; > + pinctrl-names = "default"; > + pinctrl-0 = <&icssg2_rgmii_pins_default>; > + ti,sram = <&msmc_ram>; > + > + ti,prus = <&pru2_0>, <&rtu2_0>, <&tx_pru2_0>, > + <&pru2_1>, <&rtu2_1>, <&tx_pru2_1>; > + firmware-name = "ti-pruss/am65x-pru0-prueth-fw.elf", > + "ti-pruss/am65x-rtu0-prueth-fw.elf", > + "ti-pruss/am65x-txpru0-prueth-fw.elf", > + "ti-pruss/am65x-pru1-prueth-fw.elf", > + "ti-pruss/am65x-rtu1-prueth-fw.elf", > + "ti-pruss/am65x-txpru1-prueth-fw.elf"; > + ti,pruss-gp-mux-sel = <2>, /* MII mode */ > + <2>, > + <2>, > + <2>, /* MII mode */ > + <2>, > + <2>; > + dmas = <&main_udmap 0xc300>, /* egress slice 0 */ > + <&main_udmap 0xc301>, /* egress slice 0 */ > + <&main_udmap 0xc302>, /* egress slice 0 */ > + <&main_udmap 0xc303>, /* egress slice 0 */ > + <&main_udmap 0xc304>, /* egress slice 1 */ > + <&main_udmap 0xc305>, /* egress slice 1 */ > + <&main_udmap 0xc306>, /* egress slice 1 */ > + <&main_udmap 0xc307>, /* egress slice 1 */ > + <&main_udmap 0x4300>, /* ingress slice 0 */ > + <&main_udmap 0x4301>; /* ingress slice 1 */ > + dma-names = "tx0-0", "tx0-1", "tx0-2", "tx0-3", > + "tx1-0", "tx1-1", "tx1-2", "tx1-3", > + "rx0", "rx1"; > + ti,mii-g-rt = <&icssg2_mii_g_rt>; > + interrupt-parent = <&icssg2_intc>; > + interrupts = <24 0 2>, <25 1 3>; > + interrupt-names = "tx_ts0", "tx_ts1"; > + ethernet-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + pruss2_emac0: port@0 { > + reg = <0>; > + phy-handle = <&pruss2_eth0_phy>; > + phy-mode = "rgmii-id"; > + interrupts-extended = <&icssg2_intc 24>; > + ti,syscon-rgmii-delay = <&scm_conf 0x4120>; > + /* Filled in by bootloader */ > + local-mac-address = [00 00 00 00 00 00]; > + }; > + > + pruss2_emac1: port@1 { > + reg = <1>; > + phy-handle = <&pruss2_eth1_phy>; > + phy-mode = "rgmii-id"; > + interrupts-extended = <&icssg2_intc 25>; > + ti,syscon-rgmii-delay = <&scm_conf 0x4124>; > + /* Filled in by bootloader */ > + local-mac-address = [00 00 00 00 00 00]; > + }; > + }; > + }; > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel