From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96D08C636CC for ; Mon, 13 Feb 2023 08:46:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TIIjNNMci6CaAdDIhMuahBPH9+oZ62NlN0gxDJqym5M=; b=LdZ3nEqX8Q+UoJ ef9VGyw7aHFyZmdigQYNL86tOOOcFR/11fXRskyksPIQLDUJuLKmwjS0sCRI+FIJ16lWfyGJBEmAm S/ii01qpIOoEXaiPr8K3a6M67Bsf6oVlHyxAXvKL6v0zeZRdbuoKdbBcnHyetGOHh1uNV+hDW6hBo JJ3IeC1ZvXMIfm9NLvKm7Ll698/8ig3GO/7Fkq/aiGRkR3WrzQac6Szy5fif4WNwkq5viTawcNCYN V5lDem/8LI0VTCuP2KysWS5OZMiPjRQ7A22mPBGx/YlMevqjT8IX6G3D27i6lGIsILsgyCK8khwHQ VWLDsDqbmhEBdX3d69rg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRUSr-00DeRv-Tx; Mon, 13 Feb 2023 08:45:34 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRUSo-00DeQi-EF for linux-arm-kernel@lists.infradead.org; Mon, 13 Feb 2023 08:45:31 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 84ACE3200903; Mon, 13 Feb 2023 03:45:28 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 13 Feb 2023 03:45:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1676277928; x= 1676364328; bh=CHr6ZXr+PKDm6XjaoSQUGvnP/21g+79OjDTwDq5gaPY=; b=W t3ThRa6m8G//ZEGPBt9bSSWQHtwhnV+V66r8PioCLDbu2gujONsSUIE6N7CaMz8n ky2KFbzjefwT+/SKdn5N7Hs5kcanFKFDxmSDuNwwUF+1JMt6i/XtTjrGoyiU6WHE ZPg80dNS3oXlCNbStquw7YzXLUjfuWiVAoXw17rwPPDa9Cw0/bQwWXNgz4PymR3B HDYjzC19w2gxR6IRQl3+u5X9lzRGR742qBYNwugmKqE0UmSvA7uyi/F66odrIbHY 1m8Y7Y9taEsgdqPPvpR0qDQTfcLrWboPvxK9BoqDzdFDQZDCW/k6XO/eyrkNFpcS zTpUGZzmPB0KfFlm+GfUg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1676277928; x= 1676364328; bh=CHr6ZXr+PKDm6XjaoSQUGvnP/21g+79OjDTwDq5gaPY=; b=U 3B8svi7ofTzNzNfCrAkG5k+OjjSV6n2kG450pJCl56tjYBA/tn63V0XsL6DCIZNf RWG7zesab0Z+Nxa4xd9OQuLFKTOmdmlF4tLUheQxeGtwZCh80zmaRTXKjeGtNb6y Nc4U16cHZaseGwb4xi+mXt74vqE4mTUfsIdd8NqFa4eX1hS5UDXoOQgVmUd6+X36 W5KwL5iVYYbdIVBwpB3NLThPZHtf/IUW0o4lYCPMLPD64b6WGxnkG7w4Qa5LsrGb oTWrqf3qOwKzwDBd6BHZLmOELaIA/T5xOQeIvFZCidmSUeVyv/v1Sv9R5SsMN0pD SLp6d1fwrM40ctXRApsZw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeitddguddvvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtugfgjgesthhqredttddtvdenucfhrhhomhepofgr gihimhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtf frrghtthgvrhhnpeetgfelgefggeekkefggfeludeiudffjeffgeevveekjedukedtudeu teefteefgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 13 Feb 2023 03:45:27 -0500 (EST) Date: Mon, 13 Feb 2023 09:45:25 +0100 From: Maxime Ripard To: Andreas Feldner Cc: Andre Przywara , Linus Walleij , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] pinctrl: sunxi: set minimal debounce on input-debounce 0 Message-ID: <20230213084525.gr4urlvygsmonati@houat> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230213_004530_539407_77BA018A X-CRM114-Status: GOOD ( 12.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Sun, Feb 12, 2023 at 07:21:03PM +0100, Andreas Feldner wrote: > sunxi-h3-h5 based boards have no support for switching > off IRQ debouncing filter. This would be the expected > behaviour of value 0 for the general pinctl parameter > input-debounce. > The current driver implementation ignores value 0 > for input-debounce, leaving the chip's default. This > default, however, is not minimal, but equivalent to > value 31 (microseconds). > > This patch does not ignore value 0 but instead makes > sure the corresponding IRQ debounce filter is set > to the shortest time selectable, i. e. the fast > oscillator with a divider of 1 == (2 ^ 0). > > Fixes: 7c926492d38a ("pinctrl: sunxi: Add support for interrupt debouncing") > > Signed-off-by: Andreas Feldner Like I said in the other thread, I don't think that deviating from the generic property semantics is a good thing. Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel