From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB29FC636D4 for ; Mon, 13 Feb 2023 12:34:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=acrzKLQZSFDiLWFhCIy2YO60R9EuQcnOzPSUbD/FGaA=; b=iY0mbUUzpYXyPQ Tb13wcxw2n+3eBUdVVbK72n7oRMqlojpdWjpjP/gNAm5Rx/gQuPMS8r2qjlzz37LA3N5ega5Q1H2K D4PriXqgKCTaIN99DWxuBGgIVyjTuvqHpi4rWhIdAU0vZ7swlBfeZ7ktcoILfdlAlRQAP3D82VJWy E7HYF1VqfcKfDb7nVj1Ij1S4aX9pMAV2MkhyrHb92qw73EmCoLsVwoFODvibKwJW8hRv/j8Itgkhn WcwSp8uLmBTqTZm7d4OCl57Vu04WerSwzvcMsfGedHmWVhAfm4VbElbr/YZ5H4Af379X5bvJmdb5F xeUDHNtC2Pmsx/H7wJYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRY1p-00EeMa-HV; Mon, 13 Feb 2023 12:33:53 +0000 Received: from soltyk.jannau.net ([144.76.91.90]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRY1k-00EeLJ-Qj for linux-arm-kernel@lists.infradead.org; Mon, 13 Feb 2023 12:33:51 +0000 Received: by soltyk.jannau.net (Postfix, from userid 1000) id 7763A26F77E; Mon, 13 Feb 2023 13:33:46 +0100 (CET) Date: Mon, 13 Feb 2023 13:33:46 +0100 From: Janne Grunau To: Krzysztof Kozlowski Cc: Hector Martin , Sven Peter , Alyssa Rosenzweig , Rob Herring , Krzysztof Kozlowski , Mark Kettenis , Thomas Gleixner , Marc Zyngier , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/17] dt-bindings: interrupt-controller: apple,aic2: Add apple,t8112-aic compatible Message-ID: <20230213123346.GB17933@jannau.net> References: <20230202-asahi-t8112-dt-v1-0-cb5442d1c229@jannau.net> <20230202-asahi-t8112-dt-v1-5-cb5442d1c229@jannau.net> <2f5a63ba-f4de-da89-7621-3fe1d79cdc94@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2f5a63ba-f4de-da89-7621-3fe1d79cdc94@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230213_043349_036848_18B604FD X-CRM114-Status: GOOD ( 18.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023-02-13 12:12:25 +0100, Krzysztof Kozlowski wrote: > On 12/02/2023 16:41, Janne Grunau wrote: > > The Apple M2 SoC uses AICv2 and is compatible with the existing driver. > > Add its per-SoC compatible. > > Since multi-die versions of the M2 are not expected decrease > > '#interrupt-cells' to 3 for apple,t8112-aic. This is seamlessly handled > > inside the driver. > > > > Signed-off-by: Janne Grunau > > > > --- > > This trivial dt-bindings update should be merged through the asahi-soc > > tree to ensure validation of the Apple M2 (t8112) devicetrees in this > > series. > > --- > > .../bindings/interrupt-controller/apple,aic2.yaml | 23 +++++++++++++++++++--- > > 1 file changed, 20 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml b/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml > > index 06948c0e36a5..120e23ff668c 100644 > > --- a/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml > > +++ b/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml > > @@ -31,19 +31,22 @@ description: | > > properties: > > compatible: > > items: > > - - const: apple,t6000-aic > > + - enum: > > + - apple,t8112-aic > > + - apple,t6000-aic > > - const: apple,aic2 > > > > interrupt-controller: true > > > > '#interrupt-cells': > > - const: 4 > > + minimum: 3 > > + maximum: 4 > > description: | > > The 1st cell contains the interrupt type: > > - 0: Hardware IRQ > > - 1: FIQ > > > > - The 2nd cell contains the die ID. > > + The 2nd cell contains the die ID (optional). > > > > The next cell contains the interrupt number. > > - HW IRQs: interrupt number > > @@ -98,6 +101,20 @@ properties: > > - apple,fiq-index > > - cpus > > > > +if: > > Put it under allOf. After "required:", just like example-schema asks for. moved > > + properties: > > + compatible: > > + contains: > > + const: apple,t8112-aic > > +then: > > + properties: > > + '#interrupt-cells': > > + maximum: 3 > > Shouldn't this be: > const: 3 same effect but more explicit, bot changed > > +else: > > + properties: > > + '#interrupt-cells': > > + minimum: 4 > > const: 4 thanks Janne _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel