From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4070EC636CC for ; Mon, 13 Feb 2023 13:43:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e5IGCIUD11Qb6k5JpdHZrHZEv/quh1Id+kHIQv+CnO8=; b=WLj4lpdRonSFuS M+Gv1ukylgZAmIOBSHGHIg+qVWJM87GieM6nTmXUte/zy4w8mJw+b9XJbVeXiRI5talY4MMjxjcjC K1mwh7dwjKZcgNU50caabpJW8AMAgo25I/DtaWsFmEtmKIGVUz2iABGHWXUt2HHDkAP4Goe66smis 0rLcSgoObQBTmWtyfbB+YfNnheJmsncdj5J+UVemnK/nCVXQVySa975bp2dRdM7Xnlwr4PGn3h5vl bsnzdKavm0nnK6Zuz+Q0RKLomLURoFPUQGqQqjIYSsLjLGKI5VRZpalWJYc4OTUQGVpuStCVB8aJH 3wErda5zplUYFZNMFkcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRZ6F-00EqIi-4D; Mon, 13 Feb 2023 13:42:31 +0000 Received: from soltyk.jannau.net ([144.76.91.90]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRZ6B-00EqH2-H0 for linux-arm-kernel@lists.infradead.org; Mon, 13 Feb 2023 13:42:28 +0000 Received: by soltyk.jannau.net (Postfix, from userid 1000) id EE68226F77F; Mon, 13 Feb 2023 14:42:25 +0100 (CET) Date: Mon, 13 Feb 2023 14:42:25 +0100 From: Janne Grunau To: Krzysztof Kozlowski Cc: Hector Martin , Sven Peter , Alyssa Rosenzweig , Rob Herring , Krzysztof Kozlowski , Mark Kettenis , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 16/17] dt-bindings: arm: apple: Add t8112 j413/j473/j493 compatibles Message-ID: <20230213134225.GD17933@jannau.net> References: <20230202-asahi-t8112-dt-v1-0-cb5442d1c229@jannau.net> <20230202-asahi-t8112-dt-v1-16-cb5442d1c229@jannau.net> <101940e8-c149-dd81-4abc-2a1479c19a9f@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <101940e8-c149-dd81-4abc-2a1479c19a9f@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230213_054227_756777_F791A976 X-CRM114-Status: GOOD ( 14.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023-02-13 12:15:55 +0100, Krzysztof Kozlowski wrote: > On 12/02/2023 16:41, Janne Grunau wrote: > > This adds the following apple,t8112 platforms: > > > > - apple,j413 - MacBook Air (M2, 2022) > > - apple,j473 - Mac mini (M2, 2023) > > - apple,j493 - MacBook Pro (13-inch, M2, 2022) > > > > Signed-off-by: Janne Grunau > > --- > > Documentation/devicetree/bindings/arm/apple.yaml | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/apple.yaml b/Documentation/devicetree/bindings/arm/apple.yaml > > index da78c69774f2..883fd67e3752 100644 > > --- a/Documentation/devicetree/bindings/arm/apple.yaml > > +++ b/Documentation/devicetree/bindings/arm/apple.yaml > > @@ -19,6 +19,12 @@ description: | > > - MacBook Air (M1, 2020) > > - iMac (24-inch, M1, 2021) > > > > + Devices based on the "M2" SoC: > > + > > + - MacBook Air (M2, 2022) > > + - MacBook Pro (13-inch, M2, 2022) > > + - Mac mini (M2, 2023) > > Aren't you now repeating exactly what is in the schema? Keep only one... yes but I think the duplication is OK. I consider the description for human consumption and the schema for computer consumption. The comments in the schema are aids to for editing the schema. This follows the existing pattern for M1 and M1 Pro/Max/Ultra based devices in this file. Janne _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel