From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C0DAC636D4 for ; Mon, 13 Feb 2023 22:58:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=kpM6IKZY4RP/4TTyqA085trXYlFc7lPk9IM/EGk+4SM=; b=lN+mfzb3TS+CSe dTpj+FgB1Qju6LBXWEKwK/mhXgMMw+MMm6lrBcZTI7afZ25zAiKQ7oFbTId37WfcFsL8P4rDP5XBR aNUks3QBVnlxQv69kt9JD0weFwoXfkhtetYWAw9A7hqF6hBgbr3/xhy2NGSFI4I8SexDqNSuJIUMZ J8RTK7YoMhGUg4CD4FFGHAwtvgk1qi4leBpeckD8zrRRI9gLow+KVuBB+ionBeLmVN7B20lJG4kiY rtVZmr8iV/RqfzfGFgGSHHXIegLehaTvD0Xjw9K8cBbzDvimAgQ+0iVT43xcfecipb743QqNfLamy YR+oLg0lFxgnZlTFAHkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRhlO-00Ghh4-4t; Mon, 13 Feb 2023 22:57:34 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRhlI-00GhfB-H9 for linux-arm-kernel@lists.infradead.org; Mon, 13 Feb 2023 22:57:32 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 28DFCB819CA; Mon, 13 Feb 2023 22:57:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B84DFC433D2; Mon, 13 Feb 2023 22:57:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676329044; bh=6B74k2/9qoR7D5Y3uyBNWCUwY/n8BT4T+JeDx0KNIXE=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=f3wYtIAg3DxNfUnDnm0X/pWYI0y83wxQTitkXRK6dqcedIMDfdNHPwCF4EEgfTdbU KcEx7Lmqm31hk/JKTYTwXE0TjCDOZbX3WpvRAjD91UD1t9tP7aXQgkHKcUHiOLA2i9 8x+qC919a3RrSzB8/vbepPYd/xekMKpaD0KAzWYOFUnDcwV0wFd00arf3ywQP+M9ja UKz0KsEcCyHJSbo3qwVjzxCN5qUnjnICshiBfwztBKADD3+u6nzFa0X/9Knhw6Jqy7 348KeZdLxIUtDsjIBiR5fkzMmN1yq9lFKal94PtmQZuzclAc1EgD9dcmdNEWIPBBIo RNdHpPkyh8Mrw== Date: Mon, 13 Feb 2023 16:57:23 -0600 From: Bjorn Helgaas To: Nick Alcock Cc: mcgrof@kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/8] kbuild, PCI: generic,versatile: comment out MODULE_LICENSE in non-modules Message-ID: <20230213225723.GA2941414@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230210164749.368998-2-nick.alcock@oracle.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230213_145731_049417_457CC69B X-CRM114-Status: GOOD ( 16.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 10, 2023 at 04:47:42PM +0000, Nick Alcock wrote: > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So comment out all uses of MODULE_LICENSE that are not in real modules > (the license declaration is left in as documentation). Weird that all the patches are for drivers/pci/, but the cover letter didn't go to linux-pci@vger.kernel.org. - Please drop "kbuild," from the subject; I don't think it's really relevant. - Please follow the subject line convention for each file. They're mostly there after dropping "kbuild", but do capitalize the sentence that follows the prefix. The prefix should always be "PCI/: " - Remove the MODULE_LICENSE instead of commenting it out. - I think every file in drivers/pci that needs one already has SPDX. - AFAICT, SPDX is the dispositive license and MODULE_LICENSE just determines which interfaces are available to the module, so dropping MODULE_LICENSE shouldn't be a problem as far as legal issues. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel