From: Andre Przywara <andre.przywara@arm.com>
To: Bastian Germann <bage@debian.org>
Cc: Wilken Gottwalt <wilken.gottwalt@posteo.net>,
Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <andersson@kernel.org>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Chen-Yu Tsai <wens@csie.org>,
Samuel Holland <samuel@sholland.org>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: allwinner: a64: Add hwspinlock node
Date: Tue, 14 Feb 2023 00:12:00 +0000 [thread overview]
Message-ID: <20230214001200.54504034@slackpad.lan> (raw)
In-Reply-To: <20230213231931.6546-4-bage@debian.org>
On Tue, 14 Feb 2023 00:19:30 +0100
Bastian Germann <bage@debian.org> wrote:
Hi,
> Add the hwspinlock to A64 which is already implemented for A31.
>
> Signed-off-by: Bastian Germann <bage@debian.org>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> index 77b5349f6087..d4be8be0f2f3 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -851,6 +851,16 @@ wdt0: watchdog@1c20ca0 {
> clocks = <&osc24M>;
> };
>
> + hwspinlock: hwlock@1c18000 {
> + compatible = "allwinner,sun6i-a31-hwspinlock";
I wonder if we should add a more specific compatible string here
(sun50i-a64-hwspinlock), with the existing one as a fallback.
Checked the address and the clock/reset against the manual.
I am not entirely sure if it's the best practice to unconditionally
enable those devices, but since it needs explicit consumers to be used,
it's probably fine.
Cheers,
Andre
> + reg = <0x01c18000 0x1000>;
> + clocks = <&ccu CLK_BUS_SPINLOCK>;
> + clock-names = "ahb";
> + resets = <&ccu RST_BUS_SPINLOCK>;
> + reset-names = "ahb";
> + #hwlock-cells = <1>;
> + };
> +
> spdif: spdif@1c21000 {
> #sound-dai-cells = <0>;
> compatible = "allwinner,sun50i-a64-spdif",
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-14 0:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 23:19 [PATCH 0/3] Enable hwlock on Allwinner A64 Bastian Germann
2023-02-13 23:19 ` [PATCH 1/3] dt-bindings: hwlock: sun6i: Add missing #hwlock-cells Bastian Germann
2023-02-14 0:04 ` Andre Przywara
2023-02-14 8:08 ` Krzysztof Kozlowski
2023-02-14 16:12 ` Rob Herring
2023-02-15 14:07 ` Rob Herring
2023-02-16 8:39 ` Bastian Germann
2023-02-13 23:19 ` [PATCH 2/3] dt-bindings: hwlock: sun6i: Add missing names Bastian Germann
2023-02-14 0:07 ` Andre Przywara
2023-02-14 8:09 ` Krzysztof Kozlowski
2023-02-14 9:45 ` Wilken Gottwalt
2023-02-14 12:12 ` Andre Przywara
2023-02-14 12:39 ` Krzysztof Kozlowski
2023-02-14 12:37 ` Krzysztof Kozlowski
2023-02-14 18:11 ` Andre Przywara
2023-02-16 8:15 ` Krzysztof Kozlowski
2023-02-14 12:38 ` Krzysztof Kozlowski
2023-02-13 23:19 ` [PATCH 3/3] arm64: dts: allwinner: a64: Add hwspinlock node Bastian Germann
2023-02-14 0:12 ` Andre Przywara [this message]
2023-02-14 0:18 ` [PATCH 0/3] Enable hwlock on Allwinner A64 Andre Przywara
2023-02-14 21:55 ` Bastian Germann
2023-02-15 5:01 ` Wilken Gottwalt
2023-02-14 20:57 ` (subset) " Bjorn Andersson
2023-02-15 22:31 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230214001200.54504034@slackpad.lan \
--to=andre.przywara@arm.com \
--cc=andersson@kernel.org \
--cc=bage@debian.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
--cc=wilken.gottwalt@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).