From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D02CEC6379F for ; Tue, 14 Feb 2023 17:21:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=fzTafdd94IgzgBj7d2pav7yWyybBsOnQcZiEcj+Ykk0=; b=N6H0E+Y50lW0IZ keSow0rH14CXVt9kPl6nNXKgM5N5WWP/2Duau32++3ml7GXqhSZJWbrtB7O1p/p/kJPhkRPUsIJEB U7Gu/GeQw9LRcEvYbCfA8TNpt8VVvrR2wbprPxJMVqsE884cA/rR0xSC+nKgbILStsQQUnIYdtNFP ODkV1Y+KfsaZCBRuPWC2MKtJMfT3sHUUDnhPk2umxa4TbVkKMucA8BomaKdSutN1QzVsKwUuXzbF5 leyUuGBkrS9JDjZH8LLneH0lYGosegce20Yn2XBqMk0Jo3nAc4nbNEc63gqxF33cC1/P9IGnTslYy ZEsYYr+dkFSA76kyUDaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRyzF-002zI2-Cq; Tue, 14 Feb 2023 17:21:01 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRyzB-002zGY-Ka for linux-arm-kernel@lists.infradead.org; Tue, 14 Feb 2023 17:20:59 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 10E28B81E48; Tue, 14 Feb 2023 17:20:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8ECADC433D2; Tue, 14 Feb 2023 17:20:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676395254; bh=2rnYZIWvntoiAMAXipAB60LfQP8MvT54/ijVfPKhiMM=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=osxFZtRQZ3e8WBFLbfRcZ9lBiJBPcOv9KF5UEjxutLEmzld+H06GEuv+aULQRfHga TSdCu37hj2ix401iIq1mbxClKqMqgN3j+HiIuQLOsD3M5GAONsDwp2ByXsCw7FfG/d UbobfT5bpz63ReUqHkkPnlsGH6HNmINPzhSgOC7v3WQowYcn7HGwkyK/CHDhp6A/Vs USdkzsbI8ykxkB3gTeAKpjs+WYRT4kokkZlVZqAIOnN04fzZRYYwzduPtnkeUXhefW GvpKX1mlt9q3HRuBrZ9+UICcLTIAx+gylljc8KZ7VSMpcZ5VMq1RuGjsK/xhrKTDy9 1tprqIGQ5LDQA== Date: Tue, 14 Feb 2023 11:20:53 -0600 From: Bjorn Helgaas To: Nick Alcock Cc: mcgrof@kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/8] kbuild, PCI: generic,versatile: comment out MODULE_LICENSE in non-modules Message-ID: <20230214172053.GA3044917@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <873578xnir.fsf@esperi.org.uk> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230214_092057_835947_F0305DAA X-CRM114-Status: GOOD ( 17.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 14, 2023 at 03:41:32PM +0000, Nick Alcock wrote: > On 13 Feb 2023, Bjorn Helgaas spake thusly: > > On Fri, Feb 10, 2023 at 04:47:42PM +0000, Nick Alcock wrote: > > - Please follow the subject line convention for each file. They're > > mostly there after dropping "kbuild", but do capitalize the > > sentence that follows the prefix. The prefix should always be > > "PCI/: " I misspoke about "PCI/". I use "PCI/" for things like MSI, AER, ASPM, etc. "PCI: " is the usual pattern for things specific to a driver, and it sounds like this is what you've already done: $ git log --oneline drivers/pci/controller/pci-versatile.c 6086987bdeb5 PCI: versatile: Remove redundant variable retval b64aa11eb2dd PCI: Set bridge map_irq and swizzle_irq to default functions 669cbc708122 PCI: Move DT resource setup into devm_pci_alloc_host_bridge() d3bb94d06aae PCI: Drop unnecessary zeroing of bridge fields 6a589900d050 PCI: Set default bridge parent device 79cbde56f98b PCI: versatile: Drop flag PCI_ENABLE_PROC_DOMAINS 3cf0eead9fb8 PCI: controller: Convert to devm_platform_ioremap_resource() a4b21b858b56 PCI: versatile: Use pci_host_probe() to register host 331f63457165 PCI: of: Add inbound resource parsing to helpers 2999dea8e94a PCI: versatile: Remove usage of PHYS_OFFSET f9f4fdaa3509 PCI: versatile: Use pci_parse_request_of_pci_ranges() 0018b265adf7 PCI: versatile: Fix I/O space page leak > ... If the rules for generating prefixes vary by subsystem this means > I'll have to fight through God knows how many annoyed maintainers to get > this incredibly trivial change in.) I think your script generally does the right thing, and it's already far more than most folks do, so thank you for that! I normally do that sort of minimal fixup silently when applying because there's no point in reposting when it's faster to make those trivial edits myself. In this case, removing MODULE_LICENSE instead of commenting it out is just a little more than I like to do when keeping your signed-off-by. Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel