From: Sudeep Holla <sudeep.holla@arm.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: walter.chang@mediatek.com,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
"Maciej W . Rozycki" <macro@orcam.me.uk>,
John Stultz <jstultz@google.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
wsd_upstream@mediatek.com, stanley.chu@mediatek.com,
Chun-hung.Wu@mediatek.com, Freddy.Hsin@mediatek.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 4/4] clocksource/drivers/timer-mediatek: Make timer-mediatek become loadable module
Date: Wed, 15 Feb 2023 14:46:27 +0000 [thread overview]
Message-ID: <20230215144627.ddjc7x365qdnhymi@bogus> (raw)
In-Reply-To: <53f0e612-b5cc-262e-df98-add1e8a06573@collabora.com>
On Wed, Feb 15, 2023 at 02:30:51PM +0100, AngeloGioacchino Del Regno wrote:
>
> Both. I mean that these platforms do have architected timers, but they are stopped
> before the bootloader jumps to the kernel, or they are never started at all.
>
> Please refer to:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/clocksource/timer-mediatek.c?h=next-20230215&id=327e93cf9a59b0d04eb3a31a7fdbf0f11cf13ecb
>
> For a nice explanation.
>
Thanks for that. Well then I see no point in making these modules if you
can't have generic Image that boots on all the platform. I now tend to think
that these are made modules just because GKI demands and it *might* work
on one or 2 platforms. One we move this as modules, how will be know the
Image without these timers or with them built as modules will boot or not
on a given mediatek platform. Sorry, I initially saw some point in making
these timers as modules but if they are required for boot on some systems
then I see no point. So if that is the case, NACK for these as it just
creates more confusion after these are merged as why some Images or
even why defconfig image(if we push the config change as well) is not
booting on these platforms.
It is no longer just for system timer useful in low power CPU idle states
as I initial thought.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-15 14:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 10:53 [PATCH v2 0/4] Support timer drivers as loadable modules walter.chang
2023-02-14 10:53 ` [PATCH v2 1/4] time/sched_clock: Export sched_clock_register() walter.chang
2023-02-14 10:53 ` [PATCH v2 2/4] clocksource/drivers/mmio: Export clocksource_mmio_init() walter.chang
2023-02-14 10:53 ` [PATCH v2 3/4] clocksource/drivers/timer-of: Remove __init markings walter.chang
2023-02-14 10:53 ` [PATCH v2 4/4] clocksource/drivers/timer-mediatek: Make timer-mediatek become loadable module walter.chang
2023-02-14 11:09 ` Krzysztof Kozlowski
2023-02-14 23:20 ` John Stultz
2023-02-15 18:35 ` Krzysztof Kozlowski
2023-02-15 20:59 ` John Stultz
2023-02-14 22:20 ` Sudeep Holla
2023-02-15 12:43 ` AngeloGioacchino Del Regno
2023-02-15 13:18 ` Sudeep Holla
2023-02-15 13:30 ` AngeloGioacchino Del Regno
2023-02-15 14:46 ` Sudeep Holla [this message]
2023-02-16 1:03 ` John Stultz
2023-02-16 10:22 ` AngeloGioacchino Del Regno
2023-02-16 11:23 ` Matthias Brugger
2023-02-16 11:36 ` AngeloGioacchino Del Regno
2023-03-29 6:22 ` Walter Chang (張維哲)
2023-04-10 6:58 ` Walter Chang (張維哲)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230215144627.ddjc7x365qdnhymi@bogus \
--to=sudeep.holla@arm.com \
--cc=Chun-hung.Wu@mediatek.com \
--cc=Freddy.Hsin@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=daniel.lezcano@linaro.org \
--cc=jstultz@google.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=macro@orcam.me.uk \
--cc=matthias.bgg@gmail.com \
--cc=stanley.chu@mediatek.com \
--cc=tglx@linutronix.de \
--cc=walter.chang@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox