From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BE49C636CC for ; Wed, 15 Feb 2023 21:19:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1O8DiBUnFsiYerbGtyY+ij4vVDJXUfOV+pZXumR4RqY=; b=X1ygUJPREf5+dM wGmpcsEgb5FvW5KgByZsec2XSHuQrmOyFM64rvEa5wKneww3yliiJkZsyrUPm06t7XZykQq+QiHit YTxTqQpQ+o+igPVewvfDlVCCKPY54o6XGiLhIb7sbh5y3p+3wCSSN/BFxWBaCDJF+JxgZqWfj5HZP B8HRbZwbqln19LE79MH1IA2iY+EpUdnc3MwCVHyrZFeXrxLEw4briXxhUe+3dEteEW1KQSG/983WI faiPyuXFwmK6FolBv9Cvv2FGBKTLuU0QsSTFN+nrG9TWkgoShJYspO/BMgmyEIgdxr88ttZFjqLs9 mLkamvgnDmDzXBqPcmRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSPAN-007Usw-WC; Wed, 15 Feb 2023 21:18:16 +0000 Received: from mail-ot1-f50.google.com ([209.85.210.50]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSOzh-007Odb-HO for linux-arm-kernel@lists.infradead.org; Wed, 15 Feb 2023 21:07:15 +0000 Received: by mail-ot1-f50.google.com with SMTP id 70-20020a9d084c000000b0068bccf754f1so42186oty.7 for ; Wed, 15 Feb 2023 13:07:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ACXVCP2Nz0t94MyXD0VgkPCtOTirt4h7S8UZxA7gzko=; b=1dGPiZc6PbuemQ6b7VS+FQQspYHJpAv8uHSR7lt1qmP3gJ+QEkiOomHgiIIyXHNx8K eAbHrr3wpwSNosyIcH2kwoelOL2TOeVfoVJK47Pr32DVignc7qRQ4hsOseyppd38s7RB PVbCHRU4EzJYz6QDPMMJ8C0ZRaTmKvjLal0b31JcjtSA8LkCQO2xa/dQOIOwZPWhDLlT 175GVm2Dg4W3QfL2sWvGEtC+UnIL9SkpN8YHdTjzteQW3CHOFpDfrGrooM+DPowdQHB9 C5l70CeNgbsIoJCYyeVtyh812NCiYk+UPmXoAh2B72dzIXmfMk6z6vupdPAjYstJivc1 PwYQ== X-Gm-Message-State: AO0yUKXaVLajJ9zxZfUnptXpt2zWiL4IpY3GKpqE2AroQLF/YE+02B2p 5MHT/8FrTalmJGk8sQZuWA== X-Google-Smtp-Source: AK7set8nu4Bd81ga9Ubuve+TR7XEKtYN0Cik76DAf/5sGr49KQGfEY9nwfU1J3WBilDHRSo3ZTlLEQ== X-Received: by 2002:a05:6830:113:b0:690:bf1e:9eef with SMTP id i19-20020a056830011300b00690bf1e9eefmr1852422otp.21.1676495230458; Wed, 15 Feb 2023 13:07:10 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id d21-20020a056830005500b0068664355604sm8038251otp.22.2023.02.15.13.07.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Feb 2023 13:07:10 -0800 (PST) Received: (nullmailer pid 582985 invoked by uid 1000); Wed, 15 Feb 2023 21:07:09 -0000 Date: Wed, 15 Feb 2023 15:07:09 -0600 From: Rob Herring To: Sarath Babu Naidu Gaddam Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, krzysztof.kozlowski+dt@linaro.org, michal.simek@xilinx.com, radhey.shyam.pandey@xilinx.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, anirudha.sarangi@amd.com, harini.katakam@amd.com, git@amd.com Subject: Re: [PATCH net-next V5] dt-bindings: net: xlnx,axi-ethernet: convert bindings document to yaml Message-ID: <20230215210709.GA544482-robh@kernel.org> References: <20230214112259.4076450-1-sarath.babu.naidu.gaddam@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230214112259.4076450-1-sarath.babu.naidu.gaddam@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230215_130713_620349_E5FA2858 X-CRM114-Status: GOOD ( 34.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 14, 2023 at 04:52:59PM +0530, Sarath Babu Naidu Gaddam wrote: > From: Radhey Shyam Pandey > > Convert the bindings document for Xilinx AXI Ethernet Subsystem > from txt to yaml. No changes to existing binding description. > > Signed-off-by: Radhey Shyam Pandey > Signed-off-by: Sarath Babu Naidu Gaddam > --- > Chanages in V5: > 1) Removed .txt file which was missed in V4 > > Changes in V4: > 1)Changed the interrupts property and add allOf:if:then for it. > > Changes in V3: > 1) Moved RFC to PATCH. > 2) Addressed below review comments > a) Indentation. > b) maxItems:3 does not match your description. > c) Filename matching compatibles. > > Changes in V2: > 1) remove .txt and change the name of file to xlnx,axiethernet.yaml. > 2) Fix DT check warning('device_type' does not match any of the regexes: > 'pinctrl-[0-9]+' From schema: Documentation/devicetree/bindings/net > /xilinx_axienet.yaml). > --- > .../bindings/net/xilinx_axienet.txt | 101 ----------- > .../bindings/net/xlnx,axi-ethernet.yaml | 166 ++++++++++++++++++ > MAINTAINERS | 1 + > 3 files changed, 167 insertions(+), 101 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/net/xilinx_axienet.txt > create mode 100644 Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml > diff --git a/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml b/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml > new file mode 100644 > index 000000000000..d2d276d4858f > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml > @@ -0,0 +1,166 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/xlnx,axi-ethernet.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: AXI 1G/2.5G Ethernet Subsystem > + > +description: | > + Also called AXI 1G/2.5G Ethernet Subsystem, the xilinx axi ethernet IP core > + provides connectivity to an external ethernet PHY supporting different > + interfaces: MII, GMII, RGMII, SGMII, 1000BaseX. It also includes two > + segments of memory for buffering TX and RX, as well as the capability of > + offloading TX/RX checksum calculation off the processor. > + > + Management configuration is done through the AXI interface, while payload is > + sent and received through means of an AXI DMA controller. This driver > + includes the DMA driver code, so this driver is incompatible with AXI DMA > + driver. > + > +maintainers: > + - Radhey Shyam Pandey > + > +properties: > + compatible: > + enum: > + - xlnx,axi-ethernet-1.00.a > + - xlnx,axi-ethernet-1.01.a > + - xlnx,axi-ethernet-2.01.a > + > + reg: > + description: > + Address and length of the IO space, as well as the address > + and length of the AXI DMA controller IO space, unless > + axistream-connected is specified, in which case the reg > + attribute of the node referenced by it is used. > + maxItems: 2 > + > + interrupts: > + items: > + - description: Ethernet core interrupt > + - description: Tx DMA interrupt > + - description: Rx DMA interrupt > + description: > + Ethernet core interrupt is optional. If axistream-connected property is > + present DMA node should contains TX/RX DMA interrupts else DMA interrupt > + resources are mentioned on ethernet node. > + minItems: 1 > + > + phy-handle: true > + > + xlnx,rxmem: > + description: > + Set to allocated memory buffer for Rx/Tx in the hardware. > + $ref: /schemas/types.yaml#/definitions/uint32 > + > + phy-mode: true > + > + xlnx,phy-type: > + description: > + Do not use, but still accepted in preference to phy-mode. > + deprecated: true > + $ref: /schemas/types.yaml#/definitions/uint32 > + > + xlnx,txcsum: > + description: > + TX checksum offload. 0 or empty for disabling TX checksum offload, > + 1 to enable partial TX checksum offload and 2 to enable full TX > + checksum offload. > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [0, 1, 2] > + > + xlnx,rxcsum: > + description: > + RX checksum offload. 0 or empty for disabling RX checksum offload, > + 1 to enable partial RX checksum offload and 2 to enable full RX > + checksum offload. > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [0, 1, 2] > + > + xlnx,switch-x-sgmii: > + type: boolean > + description: > + Indicate the Ethernet core is configured to support both 1000BaseX and > + SGMII modes. If set, the phy-mode should be set to match the mode > + selected on core reset (i.e. by the basex_or_sgmii core input line). > + > + clocks: > + items: > + - description: Clock for AXI register slave interface. > + - description: AXI4-Stream clock for TXD RXD TXC and RXS interfaces. > + - description: Ethernet reference clock, used by signal delay primitives > + and transceivers. > + - description: MGT reference clock (used by optional internal PCS/PMA PHY) > + > + clock-names: > + items: > + - const: s_axi_lite_clk > + - const: axis_clk > + - const: ref_clk > + - const: mgt_clk > + > + axistream-connected: > + type: object > + description: Reference to another node which contains the resources > + for the AXI DMA controller used by this device. If this is specified, > + the DMA-related resources from that device (DMA registers and DMA > + TX/RX interrupts) rather than this one will be used. > + > + mdio: true > + > + pcs-handle: > + description: Phandle to the internal PCS/PMA PHY in SGMII or 1000Base-X > + modes, where "pcs-handle" should be used to point to the PCS/PMA PHY, > + and "phy-handle" should point to an external PHY if exists. > + $ref: /schemas/types.yaml#/definitions/phandle Drop this and add a $ref to ethernet-controller.yaml > + > +required: > + - compatible > + - interrupts > + - reg > + - xlnx,rxmem > + - phy-handle > + > +allOf: > + - if: > + required: > + - axistream-connected > + > + then: > + properties: > + interrupts: > + minItems: 2 > + maxItems: 3 > + > + else: > + properties: > + interrupts: > + maxItems: 1 > + > +additionalProperties: false > + > +examples: > + - | > + axi_ethernet_eth: ethernet@40c00000 { > + compatible = "xlnx,axi-ethernet-1.00.a"; > + interrupt-parent = <µblaze_0_axi_intc>; Not relevant to the binding. > + interrupts = <2 0 1>; > + clock-names = "s_axi_lite_clk", "axis_clk", "ref_clk", "mgt_clk"; > + clocks = <&axi_clk>, <&axi_clk>, <&pl_enet_ref_clk>, <&mgt_clk>; > + phy-mode = "mii"; > + reg = <0x40c00000 0x40000>,<0x50c00000 0x40000>; > + xlnx,rxcsum = <0x2>; > + xlnx,rxmem = <0x800>; > + xlnx,txcsum = <0x2>; > + phy-handle = <&phy0>; > + > + axi_ethernetlite_0_mdio: mdio { Drop unused labels. > + #address-cells = <1>; > + #size-cells = <0>; > + phy0: ethernet-phy@1 { > + device_type = "ethernet-phy"; > + reg = <1>; > + }; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 2cf9eb43ed8f..0bf527552dc9 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -22895,6 +22895,7 @@ F: drivers/iio/adc/xilinx-ams.c > XILINX AXI ETHERNET DRIVER > M: Radhey Shyam Pandey > S: Maintained > +F: Documentation/devicetree/bindings/net/xlnx,axi-ethernet.yaml > F: drivers/net/ethernet/xilinx/xilinx_axienet* > > XILINX CAN DRIVER > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel