From: Andre Przywara <andre.przywara@arm.com>
To: Bastian Germann <bage@debian.org>
Cc: Wilken Gottwalt <wilken.gottwalt@posteo.net>,
Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <andersson@kernel.org>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Chen-Yu Tsai <wens@csie.org>,
Samuel Holland <samuel@sholland.org>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/5] dt-bindings: hwlock: sun6i: Add #hwlock-cells to example
Date: Wed, 15 Feb 2023 23:09:43 +0000 [thread overview]
Message-ID: <20230215223813.0a578985@slackpad.lan> (raw)
In-Reply-To: <aefc027c-e330-c117-87d2-3ea3023f610e@debian.org>
On Wed, 15 Feb 2023 21:43:50 +0100
Bastian Germann <bage@debian.org> wrote:
> Am 15.02.23 um 21:40 schrieb Andre Przywara:
> > On Wed, 15 Feb 2023 21:37:07 +0100
> > Bastian Germann <bage@debian.org> wrote:
> >
> > Hi,
> >
> >> The dt-bindings tools will compile the yaml dt examples
> >> and this prevents an error about this node not existing.
> >
> > This needs to be part of patch 1/5, otherwise it will break
> > bisecting. Just squash the two patches together.
>
> Is this also okay with 1/5 already being applied in linux-next?
The idea of -next is to spot those things before they cause problems. I
don't know if it's already too late, let's see what Bjorn says (see
the other mail).
You could either send a totally separate fix patch (outside of a
series), or a new series with the correct patch. But for now let's wait
how this ends up.
Cheers,
Andre
>
> >
> > Cheers,
> > Andre
> >
> >> Signed-off-by: Bastian Germann <bage@debian.org>
> >> ---
> >> .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml
> >> index 01b1bbb3061f..38478dad8b25 100644
> >> --- a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml
> >> +++ b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml
> >> @@ -48,5 +48,6 @@ examples:
> >> reg = <0x01c18000 0x1000>;
> >> clocks = <&ccu CLK_BUS_SPINLOCK>;
> >> resets = <&ccu RST_BUS_SPINLOCK>;
> >> + #hwlock-cells = <1>;
> >> };
> >> ...
> >
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-16 0:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 20:37 [PATCH v2 0/5] Enable hwlock on Allwinner A64 Bastian Germann
2023-02-15 20:37 ` [PATCH v2 1/5] dt-bindings: hwlock: sun6i: Add missing #hwlock-cells Bastian Germann
2023-02-15 20:37 ` [PATCH v2 2/5] dt-bindings: hwlock: sun6i: Add #hwlock-cells to example Bastian Germann
2023-02-15 20:40 ` Andre Przywara
2023-02-15 20:43 ` Bastian Germann
2023-02-15 23:09 ` Andre Przywara [this message]
2023-02-16 8:39 ` Krzysztof Kozlowski
2023-02-15 20:37 ` [PATCH v2 3/5] dt-bindings: hwlock: sun6i: Add missing names Bastian Germann
2023-02-15 20:45 ` Andre Przywara
2023-02-15 20:49 ` Bastian Germann
2023-02-16 8:36 ` Krzysztof Kozlowski
2023-02-16 8:54 ` Wilken Gottwalt
2023-02-15 20:37 ` [PATCH v2 4/5] dt-bindings: hwlock: sun6i: Add a64 compatible string Bastian Germann
2023-02-15 20:49 ` Andre Przywara
2023-02-15 21:31 ` Rob Herring
2023-02-16 8:38 ` Krzysztof Kozlowski
2023-02-15 20:37 ` [PATCH v2 5/5] arm64: dts: allwinner: a64: Add hwspinlock node Bastian Germann
2023-02-15 20:50 ` Andre Przywara
2023-02-16 8:36 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230215223813.0a578985@slackpad.lan \
--to=andre.przywara@arm.com \
--cc=andersson@kernel.org \
--cc=bage@debian.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
--cc=wilken.gottwalt@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).