From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5786AC636D7 for ; Thu, 16 Feb 2023 08:56:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HxxQeSGlT8H/V06rLq6H/111mGmKAF8KRrfZ74fNdzc=; b=vZBxULbn7hepaJ 6tUfNpLi5oH9j4iOsghK2wpnyodtzB6AXkEpQZhNihZpXvyQOFa/TaretW66zoWItiEBoPDX+cMRg U9+aUXlEYJsPgWQ/6K65yJrif1MKNiXcvLXEmNH+B6Nvh/LmS//LP2zNk4iliFujc1jQF1qRAlOTf cOD5Ju6yjiCq2hKiJFb5v2Nm/tnYrPLxlj1+pq6zDPrivgJjp/GrxkCHfwItTKUSMeuWQXg0Qq+fm WoRIICljCP/Kzf0lJ9vqA9W3ZWHJ4cvRMfTuX0kXjdG7SrpM6TXt7yK49fNvtiDzUr2TKlh6Cba3B +NVfEovOD4+JyP7awBiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSa2p-0098Dm-Lu; Thu, 16 Feb 2023 08:55:11 +0000 Received: from mout02.posteo.de ([185.67.36.66]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSa2m-0098Bk-81 for linux-arm-kernel@lists.infradead.org; Thu, 16 Feb 2023 08:55:09 +0000 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id CFB29240480 for ; Thu, 16 Feb 2023 09:54:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1676537700; bh=CdZyo6JjpXiyHzEMPe2wM0kSGNglA5FAaZGZKnEZChU=; h=Date:From:To:Cc:Subject:From; b=NGtca2mSTcpvtekUIjKzkrHEIHC+UHhv88b1aw+jRKufVi+0h0ygloe6bBUPDwYJs 46kEdMmv9M2erO+rabUK83bApS0HO6RyeDpfoUQv/vMjFb1SJacigxS0XSU1lFbx/R zS1OWAQY22di8YdjuAP80wJVZmgslAum3Ifz1wmDKTXK3KMt7CnB0cGN3uAGhRDaxl AU7e0YG8ICCtbB/0HwEi2jxDp2GK/+0z3peGxXX/YixjcJgVQFBvb42x9k8DCTcSK+ cq2nRdCHvml1tvPK8euO9bXDgxVlGov1pTNFeoZUnrtg7WL7ea7EHwxWnq7/pc2CBn Usq6M+qxEZYeQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PHTKW4zcRz6tm5; Thu, 16 Feb 2023 09:54:55 +0100 (CET) Date: Thu, 16 Feb 2023 08:54:54 +0000 From: Wilken Gottwalt To: Krzysztof Kozlowski Cc: Bastian Germann , Ohad Ben-Cohen , Bjorn Andersson , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Samuel Holland , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org Subject: Re: [PATCH v2 3/5] dt-bindings: hwlock: sun6i: Add missing names Message-ID: <20230216095454.54f4d5ca@posteo.net> In-Reply-To: References: <20230215203711.6293-1-bage@debian.org> <20230215203711.6293-4-bage@debian.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230216_005508_485090_3A1AD223 X-CRM114-Status: GOOD ( 16.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 16 Feb 2023 09:36:08 +0100 Krzysztof Kozlowski wrote: > On 15/02/2023 21:37, Bastian Germann wrote: > > The allwinner,sun6i-a31-hwspinlock.yaml binding needs clock-names and > > reset-names set to "ahb" as required by the Linux driver. > > > > Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock") > > Signed-off-by: Bastian Germann > > With new data, I changed my opinion and NAKed this. Still NAK, sorry. > Please drop the clock/reset-names from the driver (use indices) and DTS. I won't be able to fix this in the next time. I'm currently in the state of moving and can't set up my hardware to test the changes. And I'm not willing to submit changes without testing. And with testing I really mean testing it against a running Crust firmware which touches the hwspinlock unit. If someone wants to change that, I'm happy to see it working out, but please do it properly. Just testing the locks in Linux only is not sufficient. If some directions are required, I still have my working repo up at Github: https://github.com/wgottwalt/sunxi_hwspinlock It may be a bit dated, but should be a good start. Greetings, Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel